Skip to content

fix: rearrange processing order #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jay-es
Copy link
Member

@jay-es jay-es commented Apr 10, 2024

This PR fixes the processing order, which previously started with the newest commits and now begins with the oldest ones, ensuring chronological processing.

Screenshots Before Correction

1. Upstream repo

The top is the newest.
image
(https://github.com/vuejs/docs/commits/main/)

2. ryu-cho log

Processed in reverse order. This may cause degradation.
image
(https://github.com/vuejs-translations/docs-ja/actions/runs/8522722189/job/23343524897)

@Gumball12
Copy link
Contributor

Hi @jay-es

I'm maintaining a fork of ryu-cho called yuki-no. As the original repository has been inactive for several months, I'm working on continuing its development.

Your PR fixing the commit processing order addresses an important chronological issue. I would like to include this fix in yuki-no, with proper reference to your original PR. Would you be comfortable with this?

I understand you might be busy, but I'd really appreciate your thoughts on this when you have a chance.

@Gumball12
Copy link
Contributor

Hi, since there was no response for a while, I went ahead and incorporated the changes from this PR into the project.
If you have any concerns, please feel free to leave a comment anytime.

@jay-es
Copy link
Member Author

jay-es commented Feb 15, 2025

@Gumball12 Thank you!
I'm glad you fixed this issue.
I'll switch to your library sometime soon.

@Gumball12
Copy link
Contributor

Thanks for your kind response! Hope you find the library useful. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants