Skip to content

feat: pagination component [WE-84] #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Conversation

AshTol
Copy link
Collaborator

@AshTol AshTol commented Apr 1, 2025

@AshTol AshTol self-assigned this Apr 1, 2025
Copy link

vercel bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
wpds-docs ❌ Failed (Inspect) May 16, 2025 8:50pm
wpds-ui-kit-storybook ❌ Failed (Inspect) May 16, 2025 8:50pm

@nickb-WaPo
Copy link
Contributor

Some failing validations but I know you are taking care of them

}

return pagesToShow;
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be good to set some of these numbers that repeat, such as 5, to a constant. And would these values every change or will always show 1-5 pages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants