Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1908 Implement dice_focal loss #1914

Merged
merged 2 commits into from
Apr 1, 2021
Merged

1908 Implement dice_focal loss #1914

merged 2 commits into from
Apr 1, 2021

Conversation

yiheng-wang-nv
Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv commented Apr 1, 2021 •
edited by wyli
Loading

Signed-off-by: Yiheng Wang vennw@nvidia.com

Fixes #1908 .

Description

In this PR, dice focal loss has been implemented.
In addition, I improved some places for other features:

  • added weight parameters lambda_dice and lambda_ce in DiceCELoss (include unittest)
  • added values check for the parameter weight in FocalLoss (include unittest)
  • fixed a string issue in SENet (the long string with line breaks will introduce extra spaces when printing).

Status

Ready

Types of changes

  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@yiheng-wang-nv
Implement dice_focal loss
16b55dd 
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv yiheng-wang-nv mentioned this pull request Apr 1, 2021
Merged
5 tasks
wyli
wyli approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli enabled auto-merge (squash) April 1, 2021 12:53
@wyli wyli merged commit ba127a2 into Project-MONAI:master Apr 1, 2021
@wyli wyli changed the title 1904 Implement dice_focal loss 1908 Implement dice_focal loss Apr 1, 2021
@wyli wyli mentioned this pull request Apr 1, 2021
Closed
nsrivathsa pushed a commit to nsrivathsa/MONAI that referenced this pull request Apr 12, 2021
@yiheng-wang-nv @nsrivathsa
Implement dice_focal loss (Project-MONAI#1914)
40afac8 
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Neha Srivathsa <nsrivathsa@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add DiceFocal loss function
2 participants
@yiheng-wang-nv @wyli