full 100% coverage

Author: husayt

src/findJuzHizbByAyaid.ts

@@ -14,9 +14,7 @@ export function findJuzHizbByAyaid(ayaId: AyahId): JuzHizb {
 
   const juz = findJuzByAyaid(ayaId)
   const quarterIndex = HizbQuarterList.findIndex(x => x > ayaId) - 1
-  if (quarterIndex < 0) {
-    throw new Error("Invalid Ayah ID: No corresponding Hizb found.")
-  }
+
   const hizb = quarterIndex % 8 || 8
   return { juz, hizb, id: quarterIndex }
 }

src/validation.ts

@@ -9,6 +9,11 @@ import { getAyaCountinSura } from "./getAyaCountinSura"
  * @returns True if the Surah number is valid, false otherwise.
  */
 export function checkValidSurah(surah: number, checkOnly = false): boolean {
+  if (typeof surah !== "number" || !Number.isInteger(surah)) {
+    if (checkOnly) return false
+    throw new TypeError("Ayah ID must be an integer")
+  }
+
   if (surah < 1 || surah > meta.numSuras) {
     if (checkOnly) return false
     throw new RangeError("Surah must be between 1 and " + meta.numSuras)
@@ -41,6 +46,10 @@ export function checkValidSurahAyah(surah: number, ayah: number, checkOnly = fal
  * @returns True if the Ayah ID is valid, otherwise throws a RangeError.
  */
 export function checkValidAyahId(ayahId: number, checkOnly = false): boolean {
+  if (typeof ayahId !== "number" || !Number.isInteger(ayahId)) {
+    if (checkOnly) return false
+    throw new TypeError("Ayah ID must be an integer")
+  }
   if (ayahId < 1 || ayahId > meta.numAyas) {
     if (checkOnly) return false
     throw new RangeError("Ayah ID must be between 1 and " + meta.numAyas)

tests/checkValidAyahId.spec.ts

@@ -1,12 +1,6 @@
 import { checkValidAyahId, meta } from "../src"
 
 describe("checkValidAyahId", () => {
-  it("should return true for valid ayah id", () => {
-    expect(checkValidAyahId(1)).toBe(true)
-    expect(checkValidAyahId(meta.numAyas)).toBe(true)
-    expect(checkValidAyahId(Math.floor(meta.numAyas / 2))).toBe(true)
-  })
-
   it("should throw RangeError for ayah id less than 1", () => {
     expect(() => checkValidAyahId(0)).toThrow(RangeError)
     expect(() => checkValidAyahId(-1)).toThrow(RangeError)
@@ -17,14 +11,42 @@ describe("checkValidAyahId", () => {
     expect(() => checkValidAyahId(Number.MAX_SAFE_INTEGER)).toThrow(RangeError)
   })
 
-  //   it("should throw RangeError for non-integer ayah id", () => {
-  //     expect(() => checkValidAyahId(1.5)).toThrow(RangeError);
-  //     expect(() => checkValidAyahId(2.99)).toThrow(RangeError);
-  //   });
+  it("should throw TypeError for non-integer ayah id", () => {
+    expect(() => checkValidAyahId(1.5)).toThrow(TypeError)
+    expect(() => checkValidAyahId(2.99)).toThrow(TypeError)
+    expect(() => checkValidAyahId(Math.PI)).toThrow(TypeError)
+  })
+
+  it("should throw TypeError for NaN", () => {
+    expect(() => checkValidAyahId(NaN)).toThrow(TypeError)
+  })
+
+  it("should throw TypeError for Infinity", () => {
+    expect(() => checkValidAyahId(Infinity)).toThrow(TypeError)
+    expect(() => checkValidAyahId(-Infinity)).toThrow(TypeError)
+  })
+
+  it("should handle checkOnly", () => {
+    expect(checkValidAyahId(1, true)).toBe(true)
+    expect(checkValidAyahId(meta.numAyas, true)).toBe(true)
+    expect(checkValidAyahId(Math.floor(meta.numAyas / 2), true)).toBe(true)
+    expect(checkValidAyahId(0, true)).toBe(false)
+    expect(checkValidAyahId(meta.numAyas + 1, true)).toBe(false)
+    expect(checkValidAyahId(1.5, true)).toBe(false)
+    expect(checkValidAyahId(NaN, true)).toBe(false)
+    expect(checkValidAyahId(Infinity, true)).toBe(false)
+  })
 
-//   it("should throw TypeError for non-number ayah id", () => {
-//     expect(() => checkValidAyahId("1" as any)).toThrow(TypeError);
-//     expect(() => checkValidAyahId(null as any)).toThrow(TypeError);
-//     expect(() => checkValidAyahId(undefined as any)).toThrow(TypeError);
-//   });
+  it("should handle edge cases correctly", () => {
+    expect(checkValidAyahId(1)).toBe(true)
+    expect(checkValidAyahId(meta.numAyas)).toBe(true)
+    expect(() => checkValidAyahId(meta.numAyas + 0.5)).toThrow(TypeError)
+    expect(checkValidAyahId(Math.floor(meta.numAyas / 2))).toBe(true)
+  })
+
+  it("should throw TypeError for non-number ayah id", () => {
+    expect(() => checkValidAyahId("1" as any)).toThrow(TypeError)
+    expect(() => checkValidAyahId(null as any)).toThrow(TypeError)
+    expect(() => checkValidAyahId(undefined as any)).toThrow(TypeError)
+  })
 })

tests/checkValidSurah.spec.ts

@@ -19,11 +19,24 @@ describe("checkValidSurah", () => {
 
   it("should return false for invalid surah numbers when checkOnly is true", () => {
     expect(checkValidSurah(0, true)).toBe(false)
+    expect(checkValidSurah(1.9, true)).toBe(false)
     expect(checkValidSurah(meta.numSuras + 1, true)).toBe(false)
   })
 
   it("should return true for valid surah numbers when checkOnly is true", () => {
     expect(checkValidSurah(1, true)).toBe(true)
     expect(checkValidSurah(meta.numSuras, true)).toBe(true)
   })
+
+  it("should throw TypeError for non-number surah number", () => {
+    expect(() => checkValidSurah("1" as any)).toThrow(TypeError)
+    expect(() => checkValidSurah(null as any)).toThrow(TypeError)
+    expect(() => checkValidSurah(undefined as any)).toThrow(TypeError)
+  })
+
+  it("should throw TypeError for non-integer ayah id", () => {
+    expect(() => checkValidSurah(1.5)).toThrow(TypeError)
+    expect(() => checkValidSurah(2.99)).toThrow(TypeError)
+    expect(() => checkValidSurah(Math.PI)).toThrow(TypeError)
+  })
 })

tests/findJuzHizbByAyaid.spec.ts

@@ -42,6 +42,13 @@ describe("findJuzHizbByAyaid", () => {
     expect(spy).toHaveBeenCalledWith(100)
   })
 
+  describe("findJuzHizbByAyaid error handling", () => {
+    it("should throw an error for invalid Ayah ID", () => {
+      expect(() => findJuzHizbByAyaid(6237)).toThrow()
+      expect(() => findJuzHizbByAyaid(0)).toThrow()
+    })
+  })
+
   it("should handle edge case when ayaId is at hizb boundary", () => {
     const result = findJuzHizbByAyaid(148)
     expect(result).toEqual({ juz: 1, hizb: 8, id: 8 })