Skip to content

Adding line count for each surah #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

niqueryptic
Copy link

  • Line counts are helpful for people who would like to memorize surah based on the shortest first. A use case would be that they would sort the surahs by rukuCount, then lineCount, and then number of ayah.
  • The lineList is actually not needed but keeping it there as that was the way I used to calculate the number of lines to compare with my manual calculation.

- Line counts are helpful for people who would like to memorize surah based on the shortest first. A use case would be that they would sort the surahs by rukuCount, then lineCount, and then number of ayah.
- The lineList is actually not needed but keeping it there as that was the way I used to calculate the number of lines to compare with my manual calculation.
Copy link

@husayt
Copy link
Contributor

husayt commented Mar 25, 2025

@niqueryptic thank you for your PR. I was thinking of adding lines as well, but had to rethink this as this is mushaf based. there are 15,14, 13, 16 line mushafs (see here) and lines change depending on specific mushaf. I have just recently removed pageids from surah list for the same reason. We still have page meta, but that is for uthmani mushaf and I am considering adding other mushaf page mappings and let the user specify which mushaf page meta they are looking for.

To determine shortest/longest ayah/surah there is perhaps a better way and that is including word counts per ayah/surah. This is much better as mushaf agnostic. I am attaching ayah-word-count in case if you want to reimplement that for wordcount. But for line count we have to add mushaf type first and then link pages to mushaf and lines will follow naturally.

ayah-word-count.json

@husayt husayt self-requested a review March 25, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants