Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in example code + gitignore #52

Closed
wants to merge 1 commit into from

Conversation

AdjectiveAllison
Copy link

Feel free to let me know you don't want a git ignore for some reason. I just found it strange when opening up the repo locally and working my way through the readme.

The change to the README was just a parenthesis that was missing.

I also get this from zls: use of undeclared identifier 'builtin' from here:

cova/README.md

Line 142 in b9f127a

if (builtin.mode == .Debug) try cova.utils.displayCmdInfo(CommandT, &main_cmd, alloc, &stdout);

I haven't dug into what's going on with this yet as I'm still working on implementing the example code, just wanted to push this to get it to your attention in the mean time.

Thanks for the library! I'm excited to give it a try, it's design seems rather thought out from the beginning :)

@00JCIV00
Copy link
Owner

First and foremost, glad you're enjoying the library! Thank you for trying it out.

To the issues presented here. I'm going to be moving main to v0.10.0 this week with some pretty great enhancements. Part of that will be another review of the README where I'll probably rearrange and change a few things. With that in mind, I'm going to hold off on this PR though I do appreciate it. That said, when v0.10.0 drops, I would not turn down a review and a PR fixing similar mistakes.

Regarding the ZLS error for builtin, I may have dropped the import for it accidentally when I was truncating the examples for the README. If you would like to see the full, working code please look at the basic-app example. As mentioned above, I'll do a better job during my review for the updated README.

Thanks again for the help here. Definitely feel free to reach out if you have any specific questions or suggestions regarding the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants