Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl: Add copyright #9624

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IngelaAndin
Copy link
Contributor

No description provided.

@IngelaAndin IngelaAndin self-assigned this Mar 21, 2025
@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Mar 21, 2025
Copy link
Contributor

github-actions bot commented Mar 21, 2025

CT Test Results

    2 files     66 suites   27m 1s ⏱️
  811 tests   769 ✅  42 💤 0 ❌
4 175 runs  3 358 ✅ 817 💤 0 ❌

Results for commit a5d0ef6.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

Copy link
Contributor

@kikofernandez kikofernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license of this file is missing. I am not sure if IETF was the creator of this file.
If they were, then this is correct, but the license information is missing.

@@ -1,3 +1,7 @@
%% FROM RFC 5054
%% Copyright (C) The IETF Trust (2007).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the copyright, which you should write if they were the authors of this file.
If this is the case, this file still needs a license. A copyright says who is the author, and the license grants you permission to use it.

For the license, write a SPDX identifier, e.g., SPDX-License-Identifier: Apache-2.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you mean I should add our copy-write ( we wrote the file) but the content is from RFC 5054, but modified to use erlang syntax, which is IETF has the copyright to.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea comes from RFC 5054, but this is our implementation.
It is nice to give them credit and point them out, but we are the copyright holders of this implementation AFAIK.

TLDR
You can add our Apache 2.0 license as you did in the last commit.

@IngelaAndin IngelaAndin force-pushed the ingela/ssl/copyright branch from b108011 to a5d0ef6 Compare March 21, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants