Multi-cluster Istio components status #8170
Conversation
hhovsepy
force-pushed
the
issue7724
branch
2 times, most recently
from
0f5e8bb to
231ddb7
Compare
|
|
…tip on remote cluster in overview card, midifying tests
|
|
business/istio_status.go
Outdated
| // if no control plane and no any other control plane which manages external | ||
| if len(istiodStatus) == 0 && !managesExternal { |
There was a problem hiding this comment.
I don't think this covers the case where a controlplane may be managing an external cluster but it's not the current cluster. e.g.
You have 3 clusters: A, B, C. A manages B but nothing manages C.
I don't think you need to look at ManagesExternal. You just need to know if there's a controlplane managing this cluster or not e.g. if cluster not in controlPlanes.managedClusters.
There was a problem hiding this comment.
I'm also not sure if this is always an error. You could have an "observability" cluster for instance where the observability components live separate from any istio components.
There was a problem hiding this comment.
A problem with showing an error when the istiod is not found is that a user may not have access to the cluster where the istiod lives so this would show an error even though the istiod does exist.
There was a problem hiding this comment.
do we have somewhere documented all those combinations? or it is only here? https://istio.io/latest/docs/setup/install/multicluster/
There was a problem hiding this comment.
have changed the logic
There was a problem hiding this comment.
do we have somewhere documented all those combinations? or it is only here? https://istio.io/latest/docs/setup/install/multicluster/
It's just there but there but you can also combine some of those e.g. external control plane + primary-remote.
there are existing multicluster tests which are passing now, when all components are running fine, can be added a new ones to check that all cluster are in tooltip |
Since we're adding new functionality, it'd be good to also add new tests to cover it. |
Describe the change
Kiali Masthead which shows Home cluster name and the components statuses are merged now.
It shows single icon with tooltip:
Added multicluster support of components statuses:
Always showing sorted the worst status cluster the first.
From Control plane card removed "Remote Cluster" label as all cluster's are listed in Masthead.
Steps to test the PR
Test for primary-remote and multy-primary cases.
Regression test for single cluster case.
Automation testing
Modified the cypress and unit tests.
Issue reference
#7724