Multi-cluster Istio components status #8170

hhovsepy · 2025-02-17T15:09:26Z

Describe the change

Kiali Masthead which shows Home cluster name and the components statuses are merged now.
It shows single icon with tooltip:

Added multicluster support of components statuses:

Always showing sorted the worst status cluster the first.

From Control plane card removed "Remote Cluster" label as all cluster's are listed in Masthead.

Steps to test the PR

Test for primary-remote and multy-primary cases.
Regression test for single cluster case.

Automation testing

Modified the cypress and unit tests.

Issue reference

#7724

hhovsepy · 2025-03-12T11:27:45Z

hhovsepy · 2025-03-17T11:23:37Z

nrfox · 2025-03-17T14:10:50Z

business/istio_status.go

+	// if no control plane and no any other control plane which manages external
+	if len(istiodStatus) == 0 && !managesExternal {


I don't think this covers the case where a controlplane may be managing an external cluster but it's not the current cluster. e.g.

You have 3 clusters: A, B, C. A manages B but nothing manages C.

I don't think you need to look at ManagesExternal. You just need to know if there's a controlplane managing this cluster or not e.g. if cluster not in controlPlanes.managedClusters.

I'm also not sure if this is always an error. You could have an "observability" cluster for instance where the observability components live separate from any istio components.

A problem with showing an error when the istiod is not found is that a user may not have access to the cluster where the istiod lives so this would show an error even though the istiod does exist.

do we have somewhere documented all those combinations? or it is only here? https://istio.io/latest/docs/setup/install/multicluster/

have changed the logic

do we have somewhere documented all those combinations? or it is only here? https://istio.io/latest/docs/setup/install/multicluster/

It's just there but there but you can also combine some of those e.g. external control plane + primary-remote.

business/istio_status.go

nrfox

code looks good. Any new multi-cluster cypress tests that should be added for this to test the new masthead functionality?

hhovsepy · 2025-03-18T15:21:12Z

code looks good. Any new multi-cluster cypress tests that should be added for this to test the new masthead functionality?

there are existing multicluster tests which are passing now, when all components are running fine, can be added a new ones to check that all cluster are in tooltip

nrfox · 2025-03-18T19:54:36Z

can be added a new ones to check that all cluster are in tooltip

Since we're adding new functionality, it'd be good to also add new tests to cover it.

…tip on remote cluster in overview card, midifying tests

…in backend

Added component unhealthy test

nrfox · 2025-03-26T02:10:03Z

frontend/cypress/integration/featureFiles/masthead.feature

+    Then user sees a tooltip with text "west"
+    Then user does not see any "Not" in the tooltip
+    Then user does not see any "Unreachable" in the tooltip
+    Then user hovers out the cluster icon


What is this last assertion testing? Seems like it performs an action but does no assertions afterward?

This was like a cleanup, to close the tooltip, will move it to separate after

nrfox · 2025-03-26T02:11:52Z

frontend/cypress/integration/featureFiles/masthead.feature

+  @multi-cluster
+  @component-health
+  Scenario: Istio components unhealthy
+    When user scales to "0" the "prometheus" in namespace "istio-system"


A faster way to do this is to just intercept and mock the status response to change one of them to unhealthy. I'm worried that actually scaling prom up/down could affect other tests after this one that rely on metrics data like graph tests.

by mocking, we could not really test all those changes in the backend, it will be only UI functionality check,
but I agree that up/down of prometheus can cause some flake tests in backend, maybe I can up/down another component which is less sensitive, for instance 'grafana'

@nrfox thanks for the review, made 'grafana' up/down scale instead of 'prometheus', and '@component-health-upscale' after operaton upscales it.

nrfox · 2025-03-26T02:14:16Z

frontend/cypress/integration/featureFiles/masthead.feature

+    When user hovers over the cluster icon
+    Then user does not see any "Not" in the tooltip
+    Then user does not see any "Unreachable" in the tooltip
+    Then user hovers out the cluster icon


Same question here about this action at the end. Seems like it's not being used.

ferhoyos

I reviewed the code and tested locally, everything looks fine for me, good job @hhovsepy 🙂

However, clarifying that this is not related to this PR, when I forced Grafana to be unreachable to trigger a warning, the Mesh page did not show this warning. Instead, it displayed a valid connection.

Does it happen the same to you?

hhovsepy · 2025-03-28T12:56:43Z

I reviewed the code and tested locally, everything looks fine for me, good job @hhovsepy 🙂

However, clarifying that this is not related to this PR, when I forced Grafana to be unreachable to trigger a warning, the Mesh page did not show this warning. Instead, it displayed a valid connection.
Does it happen the same to you?

Thanks for the review and cooperation @ferhoyos , yes this happens to me as well. Probably we need another issue logged.

hhovsepy force-pushed the issue7724 branch 2 times, most recently from 0f5e8bb to 231ddb7 Compare February 20, 2025 13:41

hhovsepy force-pushed the issue7724 branch from 63a19d9 to 32804c5 Compare February 26, 2025 14:06

hhovsepy force-pushed the issue7724 branch from 9d13ab1 to cd14c6d Compare March 17, 2025 09:16

hhovsepy changed the title ~~Issue7724~~ Multi-cluster Istio components status Mar 17, 2025

hhovsepy marked this pull request as ready for review March 17, 2025 13:01

hhovsepy requested review from ferhoyos and nrfox March 17, 2025 13:45

hhovsepy self-assigned this Mar 17, 2025

hhovsepy added this to Kiali Sprint 25-10 | Kiali v2.13 Mar 17, 2025

github-project-automation bot moved this to 📋 Backlog in Kiali Sprint 25-10 | Kiali v2.13 Mar 17, 2025

jshaughn moved this from 📋 Backlog to 👀 In review in Kiali Sprint 25-10 | Kiali v2.13 Mar 17, 2025

nrfox reviewed Mar 17, 2025

View reviewed changes

hhovsepy requested a review from nrfox March 18, 2025 12:45

nrfox reviewed Mar 18, 2025

View reviewed changes

hhovsepy and others added 11 commits March 24, 2025 16:23

Multi-cluster Istio components status

6feba8e

Added cluster check

ca4965f

fixed test

b2a456e

map to config status, tbc..

268b669

Loop over clusters

fb69d09

better approach in clusters component status, fixed tests

e0d0886

missing snapshot values

defccea

fixed snapshots

91cd805

merged home cluster with component status

b829fa2

Convert IstioStatus into a label

ad03cdd

Removed component status from Overview cards, added cluster name tool…

9b35934

…tip on remote cluster in overview card, midifying tests

hhovsepy added 7 commits March 24, 2025 16:23

Added check of remote cluster before requesting components

ab34387

Removed RemoteClusterBadge, more reverts

8cec51e

Removed RemoteClusterBadge, more reverts

1f853bf

Consider MAnagesExternal

0b5ccc8

Added sorting of clusters per worst status

72e899c

Removed clusterName param from components status, loop over clusters …

502cd1c

…in backend

fixed test

ebb7734

hhovsepy force-pushed the issue7724 branch from 0d7f3c6 to 37156ec Compare March 25, 2025 07:58

Added components test for multicluster masthead

4df6886

Added component unhealthy test

hhovsepy force-pushed the issue7724 branch from 0068d13 to 4df6886 Compare March 25, 2025 11:11

hhovsepy requested a review from nrfox March 25, 2025 14:27

nrfox reviewed Mar 26, 2025

View reviewed changes

hhovsepy added 2 commits March 26, 2025 16:30

up/down grafana instead of prometheus

6402c75

removed odd hoverout

bc1d8c8

hhovsepy requested a review from nrfox March 27, 2025 08:40

nrfox approved these changes Mar 28, 2025

View reviewed changes

ferhoyos approved these changes Mar 28, 2025

View reviewed changes

hhovsepy merged commit 0ba7415 into kiali:master Mar 28, 2025
19 of 20 checks passed

github-project-automation bot moved this from 👀 In review to ✅ Done in Kiali Sprint 25-10 | Kiali v2.13 Mar 28, 2025

jshaughn mentioned this pull request Apr 4, 2025

Mesh page shows unreachable nodes as valid #8279

Closed

		// if no control plane and no any other control plane which manages external
		if len(istiodStatus) == 0 && !managesExternal {

Multi-cluster Istio components status #8170

Multi-cluster Istio components status #8170

Uh oh!

Conversation

hhovsepy commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe the change

Steps to test the PR

Automation testing

Issue reference

Uh oh!

hhovsepy commented Mar 12, 2025

Uh oh!

hhovsepy commented Mar 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nrfox left a comment

Choose a reason for hiding this comment

Uh oh!

hhovsepy commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nrfox commented Mar 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ferhoyos left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hhovsepy commented Mar 28, 2025

Uh oh!

Uh oh!

Uh oh!

hhovsepy commented Feb 17, 2025 •

edited

Loading

hhovsepy commented Mar 18, 2025 •

edited

Loading

ferhoyos left a comment •

edited

Loading