Fix a ConPTY startup hang with 0-param DA1 responses #18681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Product-Conpty
DHowett
approved these changes
Mar 12, 2025
PankajBhojwani
approved these changes
Mar 12, 2025
DHowett
pushed a commit
that referenced
this pull request
Mar 12, 2025
Since `WaitForDA1` would wait until `_deviceAttributes` is non-zero, we must ensure it's actually non-zero at the end of this handler, even if there are no parameters. ## Validation Steps Performed * Mod the Terminal DA1 to be `\x1b[?6c`. No hang ✅ * Mod the Terminal DA1 to be `\x1b[?61c`. No hang ✅ (cherry picked from commit 32ae00f) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgYO0bA Service-Version: 1.22
DHowett
pushed a commit
that referenced
this pull request
Mar 12, 2025
Since `WaitForDA1` would wait until `_deviceAttributes` is non-zero, we must ensure it's actually non-zero at the end of this handler, even if there are no parameters. ## Validation Steps Performed * Mod the Terminal DA1 to be `\x1b[?6c`. No hang ✅ * Mod the Terminal DA1 to be `\x1b[?61c`. No hang ✅ (cherry picked from commit 32ae00f) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgYO0a4 Service-Version: 1.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
WaitForDA1would wait until_deviceAttributesis non-zero,we must ensure it's actually non-zero at the end of this handler,
even if there are no parameters.
Validation Steps Performed
\x1b[?6c. No hang ✅\x1b[?61c. No hang ✅