cleanup(testing): remove bun's workaround to make it work with cust…
#30468
+0
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 5a22f17.
☁️ Nx Cloud last updated this comment at |
tinesoft
force-pushed
the
chore/remove-bun-publih-workaround
branch
from
bf6760c to
6abab61
Compare
tinesoft
requested review from
meeroslav,
vsavkin,
mandarini and
a team
as code owners
|
@tinesoft as noted on discords this is not ready |
|
Ah yes, sorry! I was too quick into converting the draft pr into a final one ^^ Will convert it back into a draft again, until then |
tinesoft
force-pushed
the
chore/remove-bun-publih-workaround
branch
2 times, most recently
from
806a5b3 to
6943017
Compare
…om registries (i.e `verdaccio`) This is not longer necessary, thanks to nrwl#30459
tinesoft
force-pushed
the
chore/remove-bun-publih-workaround
branch
from
6943017 to
5a22f17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…om registries (i.e
verdaccio)This workaround is no longer necessary once is merged #30459.
Until then, some e2e tests should still fail due to bun publish errors (which is normal).
The PR will be converted to final, once the previous is merged to master
Current Behavior
See #30459
Expected Behavior
See #30459
Related Issue(s)
Fixes #