fix(react): react-router should work with jest out of the box #30487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
ndcunningham
force-pushed
the
fix/react-router-jest
branch
from
281a10e to
a727025
Compare
|
View your CI Pipeline Execution ↗ for commit dadb3a7.
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit a727025. ☁️ Nx Cloud last updated this comment at |
ndcunningham
force-pushed
the
fix/react-router-jest
branch
2 times, most recently
from
e99d008 to
9762522
Compare
ndcunningham
force-pushed
the
fix/react-router-jest
branch
from
9762522 to
37cc2cc
Compare
Coly010
approved these changes
Mar 25, 2025
leosvelperez
requested changes
Mar 25, 2025
packages/jest/src/generators/configuration/files/common/tsconfig.spec.json__tmpl__
Outdated
Show resolved
Hide resolved
Coly010
requested changes
Mar 25, 2025
ndcunningham
force-pushed
the
fix/react-router-jest
branch
from
37cc2cc to
7f13ad4
Compare
ndcunningham
force-pushed
the
fix/react-router-jest
branch
from
7f13ad4 to
7e2bd81
Compare
leosvelperez
approved these changes
Mar 26, 2025
jaysoo
approved these changes
Mar 26, 2025
ndcunningham
force-pushed
the
fix/react-router-jest
branch
from
7e2bd81 to
59907f3
Compare
ndcunningham
force-pushed
the
fix/react-router-jest
branch
from
59907f3 to
dadb3a7
Compare
Coly010
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jest should be compatible with react-router out of the box.
Current Behavior
Currently, there are two issues when using
jestwith react-router out of the boxtsconfigjsdomis missing Node'sTextEncoderandTextDecoderso compilation fails.Expected Behavior
Running a test should work without issues when you create a react-router app with Jest.
Related Issue(s)
Fixes #30387