Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_plugin.sh: make script faster and fix syntax #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PhillipSz
Copy link

fix syntax: you can not use [ == ]; it's = or [[ == ]] or [[ = ]](both bash/zsh only). It does only work because bash corrects your mistake.

using & should make the script faster.

Everything works now and it's 2 sec's faster, except the tpm update. I don't know what the problem so please help me here.

If no one can help we must drop this PR.

Thanks.

@bruno-
Copy link
Member

bruno- commented Oct 24, 2015

Hi, thank you for your work on this.
Unfortunately I still didn't look into this. Hopefully I'll find some time soon.
Thanks for the patience.

@NHDaly
Copy link

NHDaly commented Sep 28, 2016

(It might be easier if you break this into two separate PRs. It seems pretty easy to approve the small change to the [[ == ]] syntax. That way the parallelization PR can be reviewed on its own. Cool idea though!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants