Skip to content

Commit 432cdb6

Browse files
chadlittlechadlittle
committedSep 29, 2013
Misc CSS tweaks, timeline, mobile
Summary: - Fixes line height when many long tasks are attached to a task. - Tightens up mobile layout of timeline and object box - Clean up aphront context bar Test Plan: Tested all the changes, made tasks, stared at pixels. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Maniphest Tasks: T3891 Differential Revision: https://secure.phabricator.com/D7169
1 parent fde23fe commit 432cdb6

5 files changed

+72
-64
lines changed
 

‎src/__celerity_resource_map__.php

+49-49
Original file line numberDiff line numberDiff line change
@@ -818,7 +818,7 @@
818818
),
819819
'aphront-contextbar-view-css' =>
820820
array(
821-
'uri' => '/res/1ddb40ec/rsrc/css/aphront/context-bar.css',
821+
'uri' => '/res/46c6248f/rsrc/css/aphront/context-bar.css',
822822
'type' => 'css',
823823
'requires' =>
824824
array(
@@ -3018,7 +3018,7 @@
30183018
),
30193019
'phabricator-action-list-view-css' =>
30203020
array(
3021-
'uri' => '/res/ade71822/rsrc/css/layout/phabricator-action-list-view.css',
3021+
'uri' => '/res/89534fee/rsrc/css/layout/phabricator-action-list-view.css',
30223022
'type' => 'css',
30233023
'requires' =>
30243024
array(
@@ -3474,7 +3474,7 @@
34743474
),
34753475
'phabricator-timeline-view-css' =>
34763476
array(
3477-
'uri' => '/res/09567421/rsrc/css/layout/phabricator-timeline-view.css',
3477+
'uri' => '/res/c3898a8b/rsrc/css/layout/phabricator-timeline-view.css',
34783478
'type' => 'css',
34793479
'requires' =>
34803480
array(
@@ -3805,7 +3805,7 @@
38053805
),
38063806
'phui-object-box-css' =>
38073807
array(
3808-
'uri' => '/res/3c1129d2/rsrc/css/phui/phui-object-box.css',
3808+
'uri' => '/res/9e56634a/rsrc/css/phui/phui-object-box.css',
38093809
'type' => 'css',
38103810
'requires' =>
38113811
array(
@@ -4184,7 +4184,7 @@
41844184
), array(
41854185
'packages' =>
41864186
array(
4187-
'9d16ff0b' =>
4187+
'a20e63b0' =>
41884188
array(
41894189
'name' => 'core.pkg.css',
41904190
'symbols' =>
@@ -4233,7 +4233,7 @@
42334233
41 => 'phabricator-tag-view-css',
42344234
42 => 'phui-list-view-css',
42354235
),
4236-
'uri' => '/res/pkg/9d16ff0b/core.pkg.css',
4236+
'uri' => '/res/pkg/a20e63b0/core.pkg.css',
42374237
'type' => 'css',
42384238
),
42394239
'64eeda79' =>
@@ -4425,15 +4425,15 @@
44254425
),
44264426
'reverse' =>
44274427
array(
4428-
'aphront-dialog-view-css' => '9d16ff0b',
4429-
'aphront-error-view-css' => '9d16ff0b',
4430-
'aphront-list-filter-view-css' => '9d16ff0b',
4431-
'aphront-pager-view-css' => '9d16ff0b',
4432-
'aphront-panel-view-css' => '9d16ff0b',
4433-
'aphront-table-view-css' => '9d16ff0b',
4434-
'aphront-tokenizer-control-css' => '9d16ff0b',
4435-
'aphront-tooltip-css' => '9d16ff0b',
4436-
'aphront-typeahead-control-css' => '9d16ff0b',
4428+
'aphront-dialog-view-css' => 'a20e63b0',
4429+
'aphront-error-view-css' => 'a20e63b0',
4430+
'aphront-list-filter-view-css' => 'a20e63b0',
4431+
'aphront-pager-view-css' => 'a20e63b0',
4432+
'aphront-panel-view-css' => 'a20e63b0',
4433+
'aphront-table-view-css' => 'a20e63b0',
4434+
'aphront-tokenizer-control-css' => 'a20e63b0',
4435+
'aphront-tooltip-css' => 'a20e63b0',
4436+
'aphront-typeahead-control-css' => 'a20e63b0',
44374437
'differential-changeset-view-css' => 'b55e602f',
44384438
'differential-core-view-css' => 'b55e602f',
44394439
'differential-inline-comment-editor' => '5e9e5c4e',
@@ -4447,7 +4447,7 @@
44474447
'differential-table-of-contents-css' => 'b55e602f',
44484448
'diffusion-commit-view-css' => 'c8ce2d88',
44494449
'diffusion-icons-css' => 'c8ce2d88',
4450-
'global-drag-and-drop-css' => '9d16ff0b',
4450+
'global-drag-and-drop-css' => 'a20e63b0',
44514451
'inline-comment-summary-css' => 'b55e602f',
44524452
'javelin-aphlict' => '64eeda79',
44534453
'javelin-behavior' => '9564fa17',
@@ -4522,56 +4522,56 @@
45224522
'javelin-util' => '9564fa17',
45234523
'javelin-vector' => '9564fa17',
45244524
'javelin-workflow' => '9564fa17',
4525-
'lightbox-attachment-css' => '9d16ff0b',
4525+
'lightbox-attachment-css' => 'a20e63b0',
45264526
'maniphest-task-summary-css' => '49898640',
4527-
'phabricator-action-list-view-css' => '9d16ff0b',
4528-
'phabricator-application-launch-view-css' => '9d16ff0b',
4527+
'phabricator-action-list-view-css' => 'a20e63b0',
4528+
'phabricator-application-launch-view-css' => 'a20e63b0',
45294529
'phabricator-busy' => '64eeda79',
45304530
'phabricator-content-source-view-css' => 'b55e602f',
4531-
'phabricator-core-css' => '9d16ff0b',
4532-
'phabricator-crumbs-view-css' => '9d16ff0b',
4531+
'phabricator-core-css' => 'a20e63b0',
4532+
'phabricator-crumbs-view-css' => 'a20e63b0',
45334533
'phabricator-drag-and-drop-file-upload' => '5e9e5c4e',
45344534
'phabricator-dropdown-menu' => '64eeda79',
45354535
'phabricator-file-upload' => '64eeda79',
4536-
'phabricator-filetree-view-css' => '9d16ff0b',
4537-
'phabricator-flag-css' => '9d16ff0b',
4536+
'phabricator-filetree-view-css' => 'a20e63b0',
4537+
'phabricator-flag-css' => 'a20e63b0',
45384538
'phabricator-hovercard' => '64eeda79',
4539-
'phabricator-jump-nav' => '9d16ff0b',
4539+
'phabricator-jump-nav' => 'a20e63b0',
45404540
'phabricator-keyboard-shortcut' => '64eeda79',
45414541
'phabricator-keyboard-shortcut-manager' => '64eeda79',
4542-
'phabricator-main-menu-view' => '9d16ff0b',
4542+
'phabricator-main-menu-view' => 'a20e63b0',
45434543
'phabricator-menu-item' => '64eeda79',
4544-
'phabricator-nav-view-css' => '9d16ff0b',
4544+
'phabricator-nav-view-css' => 'a20e63b0',
45454545
'phabricator-notification' => '64eeda79',
4546-
'phabricator-notification-css' => '9d16ff0b',
4547-
'phabricator-notification-menu-css' => '9d16ff0b',
4546+
'phabricator-notification-css' => 'a20e63b0',
4547+
'phabricator-notification-menu-css' => 'a20e63b0',
45484548
'phabricator-object-selector-css' => 'b55e602f',
45494549
'phabricator-phtize' => '64eeda79',
45504550
'phabricator-prefab' => '64eeda79',
45514551
'phabricator-project-tag-css' => '49898640',
4552-
'phabricator-property-list-view-css' => '9d16ff0b',
4553-
'phabricator-remarkup-css' => '9d16ff0b',
4552+
'phabricator-property-list-view-css' => 'a20e63b0',
4553+
'phabricator-remarkup-css' => 'a20e63b0',
45544554
'phabricator-shaped-request' => '5e9e5c4e',
4555-
'phabricator-side-menu-view-css' => '9d16ff0b',
4556-
'phabricator-standard-page-view' => '9d16ff0b',
4557-
'phabricator-tag-view-css' => '9d16ff0b',
4555+
'phabricator-side-menu-view-css' => 'a20e63b0',
4556+
'phabricator-standard-page-view' => 'a20e63b0',
4557+
'phabricator-tag-view-css' => 'a20e63b0',
45584558
'phabricator-textareautils' => '64eeda79',
45594559
'phabricator-tooltip' => '64eeda79',
4560-
'phabricator-transaction-view-css' => '9d16ff0b',
4561-
'phabricator-zindex-css' => '9d16ff0b',
4562-
'phui-button-css' => '9d16ff0b',
4563-
'phui-form-css' => '9d16ff0b',
4564-
'phui-form-view-css' => '9d16ff0b',
4565-
'phui-header-view-css' => '9d16ff0b',
4566-
'phui-icon-view-css' => '9d16ff0b',
4567-
'phui-list-view-css' => '9d16ff0b',
4568-
'phui-object-item-list-view-css' => '9d16ff0b',
4569-
'phui-spacing-css' => '9d16ff0b',
4570-
'sprite-apps-large-css' => '9d16ff0b',
4571-
'sprite-gradient-css' => '9d16ff0b',
4572-
'sprite-icons-css' => '9d16ff0b',
4573-
'sprite-menu-css' => '9d16ff0b',
4574-
'sprite-status-css' => '9d16ff0b',
4575-
'syntax-highlighting-css' => '9d16ff0b',
4560+
'phabricator-transaction-view-css' => 'a20e63b0',
4561+
'phabricator-zindex-css' => 'a20e63b0',
4562+
'phui-button-css' => 'a20e63b0',
4563+
'phui-form-css' => 'a20e63b0',
4564+
'phui-form-view-css' => 'a20e63b0',
4565+
'phui-header-view-css' => 'a20e63b0',
4566+
'phui-icon-view-css' => 'a20e63b0',
4567+
'phui-list-view-css' => 'a20e63b0',
4568+
'phui-object-item-list-view-css' => 'a20e63b0',
4569+
'phui-spacing-css' => 'a20e63b0',
4570+
'sprite-apps-large-css' => 'a20e63b0',
4571+
'sprite-gradient-css' => 'a20e63b0',
4572+
'sprite-icons-css' => 'a20e63b0',
4573+
'sprite-menu-css' => 'a20e63b0',
4574+
'sprite-status-css' => 'a20e63b0',
4575+
'syntax-highlighting-css' => 'a20e63b0',
45764576
),
45774577
));

‎webroot/rsrc/css/aphront/context-bar.css

+5-8
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,15 @@
33
*/
44

55
.aphront-contextbar-view {
6-
background: #efefef;
7-
padding: 6px 2em;
8-
border-bottom: 1px solid #dfdfdf;
9-
}
10-
11-
.aphront-contextbar-core {
6+
background: #fff;
7+
padding: 8px 16px;
8+
border-bottom: 1px solid {$lightblueborder};
129
}
1310

1411
.aphront-contextbar-content {
1512
padding-top: 5px;
1613
font-size: 13px;
17-
color: {$greytext};
14+
color: {$bluetext};
1815
}
1916

2017
.aphront-contextbar-buttons {
@@ -23,7 +20,7 @@
2320

2421
.aphront-contextbar-buttons label {
2522
font-weight: bold;
26-
color: {$greytext};
23+
color: {$bluetext};
2724
}
2825

2926
.aphront-contextbar-buttons a {

‎webroot/rsrc/css/layout/phabricator-action-list-view.css

+3-3
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878

7979
.phabricator-action-view button.phabricator-action-view-item,
8080
.phabricator-action-view-item {
81-
padding: 1px 0 1px 34px;
81+
padding: 1px 0 1px 28px;
8282
line-height: 20px;
8383
display: block;
8484
font-size: 12px;
@@ -91,12 +91,12 @@
9191
height: 14px;
9292
position: absolute;
9393
top: 5px;
94-
left: 13px;
94+
left: 8px;
9595
}
9696

9797
.device-desktop .phabricator-action-view:hover .phabricator-action-view-item {
9898
text-decoration: none;
99-
background-color: #3875d7;
99+
background-color: {$blue};
100100
color: #ffffff;
101101
}
102102

‎webroot/rsrc/css/layout/phabricator-timeline-view.css

+7-4
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66
padding: 0 16px;
77
}
88

9+
.device-phone .phabricator-timeline-view {
10+
padding: 0;
11+
}
12+
913
.phabricator-timeline-group {
1014
border-width: 0 3px;
1115
border-style: solid;
@@ -43,8 +47,8 @@
4347
}
4448

4549
.phabricator-timeline-title {
46-
line-height: 28px;
47-
min-height: 28px;
50+
line-height: 18px;
51+
min-height: 18px;
4852
position: relative;
4953
}
5054

@@ -89,7 +93,7 @@
8993
}
9094

9195
.phabricator-timeline-title {
92-
padding: 0 5px;
96+
padding: 5px;
9397
overflow-x: auto;
9498
overflow-y: hidden;
9599
}
@@ -107,7 +111,6 @@
107111
overflow-x: auto;
108112
}
109113

110-
111114
.device .phabricator-timeline-event-view {
112115
min-height: 23px;
113116
position: relative;

‎webroot/rsrc/css/phui/phui-object-box.css

+8
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,11 @@
3232
margin-bottom: -12px;
3333
border-width: 0 0 0 1px;
3434
}
35+
36+
.device-phone .phui-object-box {
37+
margin-top: 0;
38+
}
39+
40+
.device-phone .phui-object-box + .phui-object-box {
41+
border-top: none;
42+
}

0 commit comments

Comments
 (0)
Failed to load comments.