Skip to content

Commit ca85c45

Browse files
author
epriestley
committedOct 1, 2013
Fix an issue where email is overquoted when attaching objects
Summary: Currently, if you attach a revision to a task and the revision has a title with quotes or angle brackets in it, they are over-escaped in the email. Instead, don't do that. Test Plan: Attached `"QUOTES" MATH: 1 < 2` to a task, got a reasonable looking email. Reviewers: btrahan, chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D7186
1 parent 98bf001 commit ca85c45

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed
 

‎src/applications/transactions/storage/PhabricatorApplicationTransaction.php

+6-2
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ public function renderHandleLink($phid) {
190190
if ($this->renderingTarget == self::TARGET_HTML) {
191191
return $this->getHandle($phid)->renderLink();
192192
} else {
193-
return hsprintf('%s', $this->getHandle($phid)->getLinkName());
193+
return $this->getHandle($phid)->getLinkName();
194194
}
195195
}
196196

@@ -199,7 +199,11 @@ public function renderHandleList(array $phids) {
199199
foreach ($phids as $phid) {
200200
$links[] = $this->renderHandleLink($phid);
201201
}
202-
return phutil_implode_html(', ', $links);
202+
if ($this->renderingTarget == self::TARGET_HTML) {
203+
return phutil_implode_html(', ', $links);
204+
} else {
205+
return implode(', ', $links);
206+
}
203207
}
204208

205209
public function renderPolicyName($phid) {

0 commit comments

Comments
 (0)
Failed to load comments.