Skip to content

Commit e875ba1

Browse files
committed
Try again to get tests passing again on Windows.
Things pass locally, but some tests on some bots are still unhappy. I'm not sure why. See if using forward slashes as before helps.
1 parent 0559844 commit e875ba1

File tree

5 files changed

+27
-27
lines changed

5 files changed

+27
-27
lines changed

clang/test/Unit/lit.site.cfg.py.in

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@
22

33
import sys
44

5-
config.llvm_src_root = path(r"@LLVM_SOURCE_DIR@")
6-
config.llvm_obj_root = path(r"@LLVM_BINARY_DIR@")
7-
config.llvm_tools_dir = path(r"@LLVM_TOOLS_DIR@")
8-
config.llvm_libs_dir = path(r"@LLVM_LIBS_DIR@")
5+
config.llvm_src_root = path("@LLVM_SOURCE_DIR@")
6+
config.llvm_obj_root = path("@LLVM_BINARY_DIR@")
7+
config.llvm_tools_dir = path("@LLVM_TOOLS_DIR@")
8+
config.llvm_libs_dir = path("@LLVM_LIBS_DIR@")
99
config.llvm_build_mode = "@LLVM_BUILD_MODE@"
10-
config.clang_obj_root = path(r"@CLANG_BINARY_DIR@")
10+
config.clang_obj_root = path("@CLANG_BINARY_DIR@")
1111
config.enable_shared = @ENABLE_SHARED@
12-
config.shlibdir = path(r"@SHLIBDIR@")
12+
config.shlibdir = path("@SHLIBDIR@")
1313
config.target_triple = "@TARGET_TRIPLE@"
1414

1515
# Support substitution of the tools_dir, libs_dirs, and build_mode with user
@@ -26,4 +26,4 @@ except KeyError:
2626

2727
# Let the main config do the real work.
2828
lit_config.load_config(
29-
config, os.path.join(path(r"@CLANG_SOURCE_DIR@"), "test/Unit/lit.cfg.py"))
29+
config, os.path.join(path("@CLANG_SOURCE_DIR@"), "test/Unit/lit.cfg.py"))

clang/test/lit.site.cfg.py.in

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@
22

33
import sys
44

5-
config.llvm_src_root = path(r"@LLVM_SOURCE_DIR@")
6-
config.llvm_obj_root = path(r"@LLVM_BINARY_DIR@")
7-
config.llvm_tools_dir = path(r"@LLVM_TOOLS_DIR@")
8-
config.llvm_libs_dir = path(r"@LLVM_LIBS_DIR@")
9-
config.llvm_shlib_dir = path(r"@SHLIBDIR@")
5+
config.llvm_src_root = path("@LLVM_SOURCE_DIR@")
6+
config.llvm_obj_root = path("@LLVM_BINARY_DIR@")
7+
config.llvm_tools_dir = path("@LLVM_TOOLS_DIR@")
8+
config.llvm_libs_dir = path("@LLVM_LIBS_DIR@")
9+
config.llvm_shlib_dir = path("@SHLIBDIR@")
1010
config.llvm_plugin_ext = "@LLVM_PLUGIN_EXT@"
11-
config.lit_tools_dir = path(r"@LLVM_LIT_TOOLS_DIR@")
12-
config.clang_obj_root = path(r"@CLANG_BINARY_DIR@")
13-
config.clang_src_dir = path(r"@CLANG_SOURCE_DIR@")
14-
config.clang_tools_dir = path(r"@CLANG_TOOLS_DIR@")
11+
config.lit_tools_dir = path("@LLVM_LIT_TOOLS_DIR@")
12+
config.clang_obj_root = path("@CLANG_BINARY_DIR@")
13+
config.clang_src_dir = path("@CLANG_SOURCE_DIR@")
14+
config.clang_tools_dir = path("@CLANG_TOOLS_DIR@")
1515
config.host_triple = "@LLVM_HOST_TRIPLE@"
1616
config.target_triple = "@TARGET_TRIPLE@"
1717
config.host_cxx = "@CMAKE_CXX_COMPILER@"

llvm/cmake/modules/AddLLVM.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1486,7 +1486,7 @@ function(configure_lit_site_cfg site_in site_out)
14861486
string(REPLACE ";" "\\;" ARG_PATH_VALUES_ESCAPED "${ARG_PATH_VALUES}")
14871487
get_filename_component(OUTPUT_DIR ${site_out} DIRECTORY)
14881488
execute_process(COMMAND "${PYTHON_EXECUTABLE}" "-c"
1489-
"import os, sys; sys.stdout.write(';'.join(os.path.relpath(p, sys.argv[1]) if p else '' for p in sys.argv[2].split(';')))"
1489+
"import os, sys; sys.stdout.write(';'.join(os.path.relpath(p, sys.argv[1]).replace('\\\\', '/') if p else '' for p in sys.argv[2].split(';')))"
14901490
${OUTPUT_DIR}
14911491
${ARG_PATH_VALUES_ESCAPED}
14921492
OUTPUT_VARIABLE ARG_PATH_VALUES_RELATIVE)

llvm/test/Unit/lit.site.cfg.py.in

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22

33
import sys
44

5-
config.llvm_src_root = path(r"@LLVM_SOURCE_DIR@")
6-
config.llvm_obj_root = path(r"@LLVM_BINARY_DIR@")
7-
config.llvm_tools_dir = path(r"@LLVM_TOOLS_DIR@")
5+
config.llvm_src_root = path("@LLVM_SOURCE_DIR@")
6+
config.llvm_obj_root = path("@LLVM_BINARY_DIR@")
7+
config.llvm_tools_dir = path("@LLVM_TOOLS_DIR@")
88
config.llvm_build_mode = "@LLVM_BUILD_MODE@"
99
config.enable_shared = @ENABLE_SHARED@
10-
config.shlibdir = path(r"@SHLIBDIR@")
10+
config.shlibdir = path("@SHLIBDIR@")
1111

1212
# Support substitution of the tools_dir and build_mode with user parameters.
1313
# This is used when we can't determine the tool dir at configuration time.

llvm/test/lit.site.cfg.py.in

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@ import sys
44

55
config.host_triple = "@LLVM_HOST_TRIPLE@"
66
config.target_triple = "@TARGET_TRIPLE@"
7-
config.llvm_src_root = path(r"@LLVM_SOURCE_DIR@")
8-
config.llvm_obj_root = path(r"@LLVM_BINARY_DIR@")
9-
config.llvm_tools_dir = path(r"@LLVM_TOOLS_DIR@")
10-
config.llvm_lib_dir = path(r"@LLVM_LIBRARY_DIR@")
11-
config.llvm_shlib_dir = path(r"@SHLIBDIR@")
7+
config.llvm_src_root = path("@LLVM_SOURCE_DIR@")
8+
config.llvm_obj_root = path("@LLVM_BINARY_DIR@")
9+
config.llvm_tools_dir = path("@LLVM_TOOLS_DIR@")
10+
config.llvm_lib_dir = path("@LLVM_LIBRARY_DIR@")
11+
config.llvm_shlib_dir = path("@SHLIBDIR@")
1212
config.llvm_shlib_ext = "@SHLIBEXT@"
1313
config.llvm_exe_ext = "@EXEEXT@"
14-
config.lit_tools_dir = path(r"@LLVM_LIT_TOOLS_DIR@")
14+
config.lit_tools_dir = path("@LLVM_LIT_TOOLS_DIR@")
1515
config.python_executable = "@PYTHON_EXECUTABLE@"
1616
config.gold_executable = "@GOLD_EXECUTABLE@"
1717
config.ld64_executable = "@LD64_EXECUTABLE@"

0 commit comments

Comments
 (0)