Respected canUninstall() :P

Summary: Disabled uninstalling of applications which can't be uninstalled. Also, applications which cannot be uninstalled always show that they are installed even if users somehow manually edit the configuration.

Test Plan: Manually edited the URI to uninstall applications which can't be unisntalled.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4741

Author: Afaque Hussain

src/applications/base/PhabricatorApplication.php

@@ -66,7 +66,9 @@ public function isInstalled() {
     $uninstalled =
       PhabricatorEnv::getEnvConfig('phabricator.uninstalled-applications');
 
-      if (isset($uninstalled[get_class($this)])) {
+      if (!$this->canUninstall()) {
+        return true;
+      } else if (isset($uninstalled[get_class($this)])) {
         return false;
       } else {
         return true;

src/applications/meta/controller/PhabricatorApplicationUninstallController.php

@@ -17,7 +17,7 @@ public function processRequest() {
 
     $selected = PhabricatorApplication::getByClass($this->application);
 
-    if (!$selected) {
+    if (!$selected || !$selected->canUninstall()) {
       return new Aphront404Response();
     }