Installation & Uninstallion of Applications

Summary: Created Applications application which allows uninstallation & installation of application.

Test Plan: In "Applications" application, clicked on uninstalled the application by cliking Uninstall and chekcing whether they are really uninstalled(Disabling URI & in appearance in the side pane). Then Clicked on the install button of the uninstalled application to check whether they are installed.

Reviewers: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4715

Author: Afaque Hussain

conf/default.conf.php

@@ -839,6 +839,9 @@
   // Should Phabricator show beta applications on the homepage
   'phabricator.show-beta-applications' => false,
 
+  // Contains a list of uninstalled applications
+   'phabricator.uninstalled-applications' => array(),
+
 // -- Files ----------------------------------------------------------------- //
 
   // Lists which uploaded file types may be viewed in the browser. If a file

src/__phutil_library_map__.php

@@ -673,6 +673,7 @@
     'PhabricatorApplicationTransactionView' => 'applications/transactions/view/PhabricatorApplicationTransactionView.php',
     'PhabricatorApplicationTransactions' => 'applications/transactions/application/PhabricatorApplicationTransactions.php',
     'PhabricatorApplicationUIExamples' => 'applications/uiexample/application/PhabricatorApplicationUIExamples.php',
+    'PhabricatorApplicationUninstallController' => 'applications/meta/controller/PhabricatorApplicationUninstallController.php',
     'PhabricatorApplicationsController' => 'applications/meta/controller/PhabricatorApplicationsController.php',
     'PhabricatorApplicationsListController' => 'applications/meta/controller/PhabricatorApplicationsListController.php',
     'PhabricatorAuditActionConstants' => 'applications/audit/constants/PhabricatorAuditActionConstants.php',
@@ -2103,6 +2104,7 @@
     'PhabricatorApplicationTransactionView' => 'AphrontView',
     'PhabricatorApplicationTransactions' => 'PhabricatorApplication',
     'PhabricatorApplicationUIExamples' => 'PhabricatorApplication',
+    'PhabricatorApplicationUninstallController' => 'PhabricatorApplicationsController',
     'PhabricatorApplicationsController' => 'PhabricatorController',
     'PhabricatorApplicationsListController' => 'PhabricatorApplicationsController',
     'PhabricatorAuditAddCommentController' => 'PhabricatorAuditController',

src/applications/auth/application/PhabricatorApplicationAuth.php

@@ -6,6 +6,10 @@ public function shouldAppearInLaunchView() {
     return false;
   }
 
+  public function canUninstall() {
+    return false;
+  }
+
   public function buildMainMenuItems(
     PhabricatorUser $user,
     PhabricatorController $controller = null) {

src/applications/base/PhabricatorApplication.php

@@ -62,10 +62,25 @@ public function isEnabled() {
     return true;
   }
 
+  public function isInstalled() {
+    $uninstalled =
+      PhabricatorEnv::getEnvConfig('phabricator.uninstalled-applications');
+
+      if (isset($uninstalled[get_class($this)])) {
+        return false;
+      } else {
+        return true;
+      }
+  }
+
   public function isBeta() {
     return false;
   }
 
+  public function canUninstall() {
+    return true;
+  }
+
   public function getPHID() {
     return 'PHID-APPS-'.get_class($this);
   }
@@ -212,13 +227,34 @@ public function getQuickCreateURI() {
 
 /* -(  Application Management  )--------------------------------------------- */
 
+  public static function getAllApplications() {
+
+    $classes = id(new PhutilSymbolLoader())
+            ->setAncestorClass(__CLASS__)
+            ->setConcreteOnly(true)
+            ->selectAndLoadSymbols();
+
+    $apps = array();
+
+    foreach ($classes as $class) {
+      $app = newv($class['name'], array());
+      $apps[] = $app;
+    }
+
+    return $apps;
+  }
 
   public static function getAllInstalledApplications() {
     static $applications;
 
     $show_beta =
       PhabricatorEnv::getEnvConfig('phabricator.show-beta-applications');
 
+    $uninstalled =
+      PhabricatorEnv::getEnvConfig('phabricator.uninstalled-applications');
+
+
+
     if (empty($applications)) {
       $classes = id(new PhutilSymbolLoader())
         ->setAncestorClass(__CLASS__)
@@ -227,22 +263,29 @@ public static function getAllInstalledApplications() {
 
       $apps = array();
       foreach ($classes as $class) {
-        $app = newv($class['name'], array());
-        if (!$app->isEnabled()) {
+
+      if (isset($uninstalled[$class['name']])) {
+        continue;
+      }
+
+      $app = newv($class['name'], array());
+
+      if (!$app->isEnabled()) {
           continue;
-        }
+      }
 
-        if (!$show_beta && $app->isBeta()) {
+      if (!$show_beta && $app->isBeta()) {
           continue;
-        }
+      }
 
-        $apps[] = $app;
+      $apps[] = $app;
       }
+
       $applications = $apps;
     }
 
     return $applications;
   }
 
-
 }
+

src/applications/config/application/PhabricatorApplicationConfig.php

@@ -18,6 +18,10 @@ public function getApplicationGroup() {
     return self::GROUP_ADMIN;
   }
 
+  public function canUninstall() {
+    return false;
+  }
+
   public function getRoutes() {
     return array(
       '/config/' => array(

src/applications/config/option/PhabricatorCoreConfigOptions.php

@@ -128,6 +128,11 @@ public function getOptions() {
       $this->newOption('test.value', 'wild', null)
         ->setLocked(true)
         ->setDescription(pht('Unit test value.')),
+      $this->newOption('phabricator.uninstalled-applications', 'set', array())
+        ->setLocked(true)
+        ->setDescription(
+          pht('Array containing list of Uninstalled applications.')
+          ),
     );
   }
 

src/applications/daemon/application/PhabricatorApplicationDaemons.php

@@ -26,6 +26,10 @@ public function getApplicationGroup() {
     return self::GROUP_ADMIN;
   }
 
+  public function canUninstall() {
+    return false;
+  }
+
   public function getRoutes() {
     return array(
       '/daemon/' => array(

src/applications/feed/application/PhabricatorApplicationFeed.php

@@ -14,6 +14,10 @@ public function getIconName() {
     return 'feed';
   }
 
+  public function canUninstall() {
+    return false;
+  }
+
   public function getRoutes() {
     return array(
       '/feed/' => array(

src/applications/files/application/PhabricatorApplicationFiles.php

@@ -30,6 +30,10 @@ public function getQuickCreateURI() {
     return $this->getBaseURI().'upload/';
   }
 
+  public function canUninstall() {
+    return false;
+  }
+
   public function getRoutes() {
     return array(
       '/F(?P<id>[1-9]\d*)' => 'PhabricatorFileShortcutController',

src/applications/meta/application/PhabricatorApplicationApplications.php

@@ -2,6 +2,10 @@
 
 final class PhabricatorApplicationApplications extends PhabricatorApplication {
 
+  public function canUninstall() {
+    return false;
+  }
+
   public function getBaseURI() {
     return '/applications/';
   }
@@ -28,7 +32,8 @@ public function getRoutes() {
         ''                          => 'PhabricatorApplicationsListController',
         'view/(?P<application>\w+)/' =>
           'PhabricatorApplicationDetailViewController',
-
+        '(?P<application>\w+)/(?P<action>install|uninstall)/' =>
+          'PhabricatorApplicationUninstallController',
         ),
 
     );

src/applications/meta/controller/PhabricatorApplicationDetailViewController.php

@@ -14,12 +14,12 @@ public function processRequest() {
     $user = $request->getUser();
 
     $selected = null;
-    $applications = PhabricatorApplication::getAllInstalledApplications();
+    $applications = PhabricatorApplication::getAllApplications();
 
     foreach ($applications as $application) {
       if (get_class($application) == $this->application) {
-        $selected = $application;
-        break;
+      $selected = $application;
+      break;
       }
     }
 
@@ -35,43 +35,67 @@ public function processRequest() {
         ->setName(pht('Applications'))
         ->setHref($this->getApplicationURI()));
 
-    $properties = $this->buildPropertyView($selected);
-    $actions = $this->buildActionView($user);
-
-    return $this->buildApplicationPage(
-      array(
-        $crumbs,
-        id(new PhabricatorHeaderView())->setHeader($title),
-        $actions,
-        $properties,
-      ),
-      array(
-        'title' => $title,
-        'device' => true,
-      ));
+   $properties = $this->buildPropertyView($selected);
+   $actions = $this->buildActionView($user, $selected);
+
+   return $this->buildApplicationPage(
+    array(
+      $crumbs,
+      id(new PhabricatorHeaderView())->setHeader($title),
+      $actions,
+      $properties,
+    ),
+    array(
+      'title' => $title,
+      'device' => true,
+    ));
   }
 
   private function buildPropertyView(PhabricatorApplication $selected) {
     $properties = new PhabricatorPropertyListView();
 
-    $properties->addProperty(
-      pht('Status'), pht('Installed'));
+    if ($selected->isInstalled()) {
+      $properties->addProperty(
+        pht('Status'), pht('Installed'));
+
+    } else {
+      $properties->addProperty(
+        pht('Status'), pht('Uninstalled'));
+    }
 
     $properties->addProperty(
       pht('Description'), $selected->getShortDescription());
 
     return $properties;
   }
 
-  private function buildActionView(PhabricatorUser $user) {
-
-    return id(new PhabricatorActionListView())
-      ->setUser($user)
-      ->addAction(
-        id(new PhabricatorActionView())
-          ->setName(pht('Uninstall'))
-          ->setIcon('delete')
-     );
+  private function buildActionView(
+    PhabricatorUser $user, PhabricatorApplication $selected) {
+
+    if ($selected->canUninstall()) {
+      if ($selected->isInstalled()) {
+
+        return id(new PhabricatorActionListView())
+          ->setUser($user)
+          ->addAction(
+            id(new PhabricatorActionView())
+              ->setName(pht('Uninstall'))
+              ->setIcon('delete')
+              ->setHref(
+                $this->getApplicationURI(get_class($selected).'/uninstall/'))
+              );
+      } else {
+          return id(new PhabricatorActionListView())
+            ->setUser($user)
+            ->addAction(
+              id(new PhabricatorActionView())
+              ->setName(pht('Install'))
+              ->setIcon('new')
+              ->setHref(
+                $this->getApplicationURI(get_class($selected).'/install/'))
+              );
+      }
+    }
   }
 
 }