Policy, Status in PHUIHeaderView

Summary: The adds the ability to set 'properties' such as state, privacy, due date to the header of objects.

Test Plan: Implemented in Paste, Pholio. Tested various states.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: Korvin, aran

Differential Revision: https://secure.phabricator.com/D7016

Author: chadlittle

resources/sprite/manifest/status.json

@@ -151,6 +151,16 @@
       "rule" : ".status-minus-white",
       "hash" : "c5a3771452dda603fbaee87371044f5a"
     },
+    "status-oh-closed"      : {
+      "name" : "status-oh-closed",
+      "rule" : ".status-oh-closed",
+      "hash" : "cbc6a0959ebad3e88cc3ac67743a7f3a"
+    },
+    "status-oh-open"        : {
+      "name" : "status-oh-open",
+      "rule" : ".status-oh-open",
+      "hash" : "e86f83bc40e77664c91c834b27816576"
+    },
     "status-open-blue"      : {
       "name" : "status-open-blue",
       "rule" : ".status-open-blue",
@@ -176,6 +186,41 @@
       "rule" : ".status-open-white",
       "hash" : "169dc0e8f36444ea30163181f9c88dc2"
     },
+    "status-policy-admin"   : {
+      "name" : "status-policy-admin",
+      "rule" : ".status-policy-admin",
+      "hash" : "1df35b15bd20880a5d20c0a2da446472"
+    },
+    "status-policy-all"     : {
+      "name" : "status-policy-all",
+      "rule" : ".status-policy-all",
+      "hash" : "ef0c0594968b04ed90ca8dc629a39e54"
+    },
+    "status-policy-custom"  : {
+      "name" : "status-policy-custom",
+      "rule" : ".status-policy-custom",
+      "hash" : "a432adf61806705c54ad7e110e063829"
+    },
+    "status-policy-noone"   : {
+      "name" : "status-policy-noone",
+      "rule" : ".status-policy-noone",
+      "hash" : "23b4a85b15930c46fa409e95d26be2c4"
+    },
+    "status-policy-project" : {
+      "name" : "status-policy-project",
+      "rule" : ".status-policy-project",
+      "hash" : "bbc9e90f3353a357c5a39e703825504e"
+    },
+    "status-policy-public"  : {
+      "name" : "status-policy-public",
+      "rule" : ".status-policy-public",
+      "hash" : "4e6e9763dbb87dca73847e64ef0b87e6"
+    },
+    "status-policy-unknown" : {
+      "name" : "status-policy-unknown",
+      "rule" : ".status-policy-unknown",
+      "hash" : "f32c8a68221f735e443cb8b18b41ee0e"
+    },
     "status-question-blue"  : {
       "name" : "status-question-blue",
       "rule" : ".status-question-blue",

resources/sprite/status_1x/oh-closed.png

@@ -96,7 +96,7 @@
     'phabricator-notification-css',
     'phabricator-notification-menu-css',
     'lightbox-attachment-css',
-    'phabricator-header-view-css',
+    'phui-header-view-css',
     'phabricator-filetree-view-css',
     'phabricator-nav-view-css',
     'phabricator-side-menu-view-css',

resources/sprite/status_1x/oh-open.png

@@ -702,15 +702,15 @@
   ),
   '/rsrc/image/sprite-status-X2.png' =>
   array(
-    'hash' => '3c57299b04fc21bee8a20d2d019bf6b6',
-    'uri' => '/res/3c57299b/rsrc/image/sprite-status-X2.png',
+    'hash' => 'b26f204c1b5ff01e3facbf78ccdc358b',
+    'uri' => '/res/b26f204c/rsrc/image/sprite-status-X2.png',
     'disk' => '/rsrc/image/sprite-status-X2.png',
     'type' => 'png',
   ),
   '/rsrc/image/sprite-status.png' =>
   array(
-    'hash' => 'b76029c6bac69fd5bd9ab82d254f2ef1',
-    'uri' => '/res/b76029c6/rsrc/image/sprite-status.png',
+    'hash' => 'c1f9c28f3ab24a0f2d758331bb0f8a09',
+    'uri' => '/res/c1f9c28f/rsrc/image/sprite-status.png',
     'disk' => '/rsrc/image/sprite-status.png',
     'type' => 'png',
   ),
@@ -1149,7 +1149,7 @@
   ),
   'diviner-shared-css' =>
   array(
-    'uri' => '/res/ef49b30b/rsrc/css/diviner/diviner-shared.css',
+    'uri' => '/res/cba9c99e/rsrc/css/diviner/diviner-shared.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -3014,7 +3014,7 @@
   ),
   'phabricator-action-list-view-css' =>
   array(
-    'uri' => '/res/5478ce6c/rsrc/css/layout/phabricator-action-list-view.css',
+    'uri' => '/res/c6219563/rsrc/css/layout/phabricator-action-list-view.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -3080,7 +3080,7 @@
   ),
   'phabricator-crumbs-view-css' =>
   array(
-    'uri' => '/res/ff818db7/rsrc/css/layout/phabricator-crumbs-view.css',
+    'uri' => '/res/4d722e16/rsrc/css/layout/phabricator-crumbs-view.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -3180,15 +3180,6 @@
     ),
     'disk' => '/rsrc/css/application/flag/flag.css',
   ),
-  'phabricator-header-view-css' =>
-  array(
-    'uri' => '/res/8b2bcc29/rsrc/css/layout/phabricator-header-view.css',
-    'type' => 'css',
-    'requires' =>
-    array(
-    ),
-    'disk' => '/rsrc/css/layout/phabricator-header-view.css',
-  ),
   'phabricator-hovercard' =>
   array(
     'uri' => '/res/7fb94260/rsrc/js/core/Hovercard.js',
@@ -3376,7 +3367,7 @@
   ),
   'phabricator-property-list-view-css' =>
   array(
-    'uri' => '/res/fdcbf4ab/rsrc/css/layout/phabricator-property-list-view.css',
+    'uri' => '/res/3a0ffc53/rsrc/css/layout/phabricator-property-list-view.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -3747,7 +3738,7 @@
   ),
   'phui-document-view-css' =>
   array(
-    'uri' => '/res/c95d4bdf/rsrc/css/phui/phui-document.css',
+    'uri' => '/res/7928af2d/rsrc/css/phui/phui-document.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -3781,9 +3772,18 @@
     ),
     'disk' => '/rsrc/css/phui/phui-form-view.css',
   ),
+  'phui-header-view-css' =>
+  array(
+    'uri' => '/res/7ce53631/rsrc/css/phui/phui-header-view.css',
+    'type' => 'css',
+    'requires' =>
+    array(
+    ),
+    'disk' => '/rsrc/css/phui/phui-header-view.css',
+  ),
   'phui-icon-view-css' =>
   array(
-    'uri' => '/res/f78f4c64/rsrc/css/phui/phui-icon.css',
+    'uri' => '/res/28fb5ae5/rsrc/css/phui/phui-icon.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -4134,7 +4134,7 @@
   ),
   'sprite-status-css' =>
   array(
-    'uri' => '/res/72b39c66/rsrc/css/sprite-status.css',
+    'uri' => '/res/d61bb845/rsrc/css/sprite-status.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -4171,7 +4171,7 @@
 ), array(
   'packages' =>
   array(
-    '606d1ed1' =>
+    '2c60f04c' =>
     array(
       'name' => 'core.pkg.css',
       'symbols' =>
@@ -4203,7 +4203,7 @@
         24 => 'phabricator-notification-css',
         25 => 'phabricator-notification-menu-css',
         26 => 'lightbox-attachment-css',
-        27 => 'phabricator-header-view-css',
+        27 => 'phui-header-view-css',
         28 => 'phabricator-filetree-view-css',
         29 => 'phabricator-nav-view-css',
         30 => 'phabricator-side-menu-view-css',
@@ -4218,7 +4218,7 @@
         39 => 'phabricator-property-list-view-css',
         40 => 'phabricator-tag-view-css',
       ),
-      'uri' => '/res/pkg/606d1ed1/core.pkg.css',
+      'uri' => '/res/pkg/2c60f04c/core.pkg.css',
       'type' => 'css',
     ),
     '8977e356' =>
@@ -4409,15 +4409,15 @@
   ),
   'reverse' =>
   array(
-    'aphront-dialog-view-css' => '606d1ed1',
-    'aphront-error-view-css' => '606d1ed1',
-    'aphront-list-filter-view-css' => '606d1ed1',
-    'aphront-pager-view-css' => '606d1ed1',
-    'aphront-panel-view-css' => '606d1ed1',
-    'aphront-table-view-css' => '606d1ed1',
-    'aphront-tokenizer-control-css' => '606d1ed1',
-    'aphront-tooltip-css' => '606d1ed1',
-    'aphront-typeahead-control-css' => '606d1ed1',
+    'aphront-dialog-view-css' => '2c60f04c',
+    'aphront-error-view-css' => '2c60f04c',
+    'aphront-list-filter-view-css' => '2c60f04c',
+    'aphront-pager-view-css' => '2c60f04c',
+    'aphront-panel-view-css' => '2c60f04c',
+    'aphront-table-view-css' => '2c60f04c',
+    'aphront-tokenizer-control-css' => '2c60f04c',
+    'aphront-tooltip-css' => '2c60f04c',
+    'aphront-typeahead-control-css' => '2c60f04c',
     'differential-changeset-view-css' => '44bfe40c',
     'differential-core-view-css' => '44bfe40c',
     'differential-inline-comment-editor' => '5e9e5c4e',
@@ -4431,7 +4431,7 @@
     'differential-table-of-contents-css' => '44bfe40c',
     'diffusion-commit-view-css' => 'c8ce2d88',
     'diffusion-icons-css' => 'c8ce2d88',
-    'global-drag-and-drop-css' => '606d1ed1',
+    'global-drag-and-drop-css' => '2c60f04c',
     'inline-comment-summary-css' => '44bfe40c',
     'javelin-aphlict' => '8977e356',
     'javelin-behavior' => 'f32597c9',
@@ -4504,55 +4504,55 @@
     'javelin-util' => 'f32597c9',
     'javelin-vector' => 'f32597c9',
     'javelin-workflow' => 'f32597c9',
-    'lightbox-attachment-css' => '606d1ed1',
+    'lightbox-attachment-css' => '2c60f04c',
     'maniphest-task-summary-css' => '36d5d071',
     'maniphest-transaction-detail-css' => '36d5d071',
-    'phabricator-action-list-view-css' => '606d1ed1',
-    'phabricator-application-launch-view-css' => '606d1ed1',
+    'phabricator-action-list-view-css' => '2c60f04c',
+    'phabricator-application-launch-view-css' => '2c60f04c',
     'phabricator-busy' => '8977e356',
     'phabricator-content-source-view-css' => '44bfe40c',
-    'phabricator-core-css' => '606d1ed1',
-    'phabricator-crumbs-view-css' => '606d1ed1',
+    'phabricator-core-css' => '2c60f04c',
+    'phabricator-crumbs-view-css' => '2c60f04c',
     'phabricator-drag-and-drop-file-upload' => '5e9e5c4e',
     'phabricator-dropdown-menu' => '8977e356',
     'phabricator-file-upload' => '8977e356',
-    'phabricator-filetree-view-css' => '606d1ed1',
-    'phabricator-flag-css' => '606d1ed1',
-    'phabricator-header-view-css' => '606d1ed1',
+    'phabricator-filetree-view-css' => '2c60f04c',
+    'phabricator-flag-css' => '2c60f04c',
     'phabricator-hovercard' => '8977e356',
-    'phabricator-jump-nav' => '606d1ed1',
+    'phabricator-jump-nav' => '2c60f04c',
     'phabricator-keyboard-shortcut' => '8977e356',
     'phabricator-keyboard-shortcut-manager' => '8977e356',
-    'phabricator-main-menu-view' => '606d1ed1',
+    'phabricator-main-menu-view' => '2c60f04c',
     'phabricator-menu-item' => '8977e356',
-    'phabricator-nav-view-css' => '606d1ed1',
+    'phabricator-nav-view-css' => '2c60f04c',
     'phabricator-notification' => '8977e356',
-    'phabricator-notification-css' => '606d1ed1',
-    'phabricator-notification-menu-css' => '606d1ed1',
+    'phabricator-notification-css' => '2c60f04c',
+    'phabricator-notification-menu-css' => '2c60f04c',
     'phabricator-object-selector-css' => '44bfe40c',
     'phabricator-phtize' => '8977e356',
     'phabricator-prefab' => '8977e356',
     'phabricator-project-tag-css' => '36d5d071',
-    'phabricator-property-list-view-css' => '606d1ed1',
-    'phabricator-remarkup-css' => '606d1ed1',
+    'phabricator-property-list-view-css' => '2c60f04c',
+    'phabricator-remarkup-css' => '2c60f04c',
     'phabricator-shaped-request' => '5e9e5c4e',
-    'phabricator-side-menu-view-css' => '606d1ed1',
-    'phabricator-standard-page-view' => '606d1ed1',
-    'phabricator-tag-view-css' => '606d1ed1',
+    'phabricator-side-menu-view-css' => '2c60f04c',
+    'phabricator-standard-page-view' => '2c60f04c',
+    'phabricator-tag-view-css' => '2c60f04c',
     'phabricator-textareautils' => '8977e356',
     'phabricator-tooltip' => '8977e356',
-    'phabricator-transaction-view-css' => '606d1ed1',
-    'phabricator-zindex-css' => '606d1ed1',
-    'phui-button-css' => '606d1ed1',
-    'phui-form-css' => '606d1ed1',
-    'phui-form-view-css' => '606d1ed1',
-    'phui-icon-view-css' => '606d1ed1',
-    'phui-object-item-list-view-css' => '606d1ed1',
-    'phui-spacing-css' => '606d1ed1',
-    'sprite-apps-large-css' => '606d1ed1',
-    'sprite-gradient-css' => '606d1ed1',
-    'sprite-icons-css' => '606d1ed1',
-    'sprite-menu-css' => '606d1ed1',
-    'syntax-highlighting-css' => '606d1ed1',
+    'phabricator-transaction-view-css' => '2c60f04c',
+    'phabricator-zindex-css' => '2c60f04c',
+    'phui-button-css' => '2c60f04c',
+    'phui-form-css' => '2c60f04c',
+    'phui-form-view-css' => '2c60f04c',
+    'phui-header-view-css' => '2c60f04c',
+    'phui-icon-view-css' => '2c60f04c',
+    'phui-object-item-list-view-css' => '2c60f04c',
+    'phui-spacing-css' => '2c60f04c',
+    'sprite-apps-large-css' => '2c60f04c',
+    'sprite-gradient-css' => '2c60f04c',
+    'sprite-icons-css' => '2c60f04c',
+    'sprite-menu-css' => '2c60f04c',
+    'syntax-highlighting-css' => '2c60f04c',
   ),
 ));

resources/sprite/status_1x/policy-admin.png

@@ -754,6 +754,7 @@
     'PHUIFormLayoutView' => 'view/form/PHUIFormLayoutView.php',
     'PHUIFormMultiSubmitControl' => 'view/form/control/PHUIFormMultiSubmitControl.php',
     'PHUIFormPageView' => 'view/form/PHUIFormPageView.php',
+    'PHUIHeaderView' => 'view/phui/PHUIHeaderView.php',
     'PHUIIconExample' => 'applications/uiexample/examples/PHUIIconExample.php',
     'PHUIIconView' => 'view/phui/PHUIIconView.php',
     'PHUIListExample' => 'applications/uiexample/examples/PHUIListExample.php',
@@ -1229,7 +1230,6 @@
     'PhabricatorHandleQuery' => 'applications/phid/query/PhabricatorHandleQuery.php',
     'PhabricatorHash' => 'infrastructure/util/PhabricatorHash.php',
     'PhabricatorHashTestCase' => 'infrastructure/util/__tests__/PhabricatorHashTestCase.php',
-    'PhabricatorHeaderView' => 'view/layout/PhabricatorHeaderView.php',
     'PhabricatorHelpController' => 'applications/help/controller/PhabricatorHelpController.php',
     'PhabricatorHelpKeyboardShortcutController' => 'applications/help/controller/PhabricatorHelpKeyboardShortcutController.php',
     'PhabricatorHovercardExample' => 'applications/uiexample/examples/PhabricatorHovercardExample.php',
@@ -2839,6 +2839,7 @@
     'PHUIFormLayoutView' => 'AphrontView',
     'PHUIFormMultiSubmitControl' => 'AphrontFormControl',
     'PHUIFormPageView' => 'AphrontView',
+    'PHUIHeaderView' => 'AphrontView',
     'PHUIIconExample' => 'PhabricatorUIExample',
     'PHUIIconView' => 'AphrontTagView',
     'PHUIListExample' => 'PhabricatorUIExample',
@@ -3363,7 +3364,6 @@
     'PhabricatorGlobalUploadTargetView' => 'AphrontView',
     'PhabricatorHandleQuery' => 'PhabricatorCursorPagedPolicyAwareQuery',
     'PhabricatorHashTestCase' => 'PhabricatorTestCase',
-    'PhabricatorHeaderView' => 'AphrontView',
     'PhabricatorHelpController' => 'PhabricatorController',
     'PhabricatorHelpKeyboardShortcutController' => 'PhabricatorHelpController',
     'PhabricatorHovercardExample' => 'PhabricatorUIExample',

resources/sprite/status_1x/policy-all.png

@@ -30,7 +30,7 @@ public function processRequest() {
 
     $nav->appendChild(
       array(
-        id(new PhabricatorHeaderView())->setHeader($page_title),
+        id(new PHUIHeaderView())->setHeader($page_title),
         $status_list,
       ));
 

resources/sprite/status_1x/policy-custom.png

@@ -385,10 +385,10 @@ private function buildHumanReadableResponse(
     $result_panel->setHeader('Method Result');
     $result_panel->appendChild($result_table);
 
-    $param_head = id(new PhabricatorHeaderView())
+    $param_head = id(new PHUIHeaderView())
       ->setHeader(pht('Method Parameters'));
 
-    $result_head = id(new PhabricatorHeaderView())
+    $result_head = id(new PHUIHeaderView())
       ->setHeader(pht('Method Result'));
 
     $method_uri = $this->getApplicationURI('method/'.$method.'/');

resources/sprite/status_1x/policy-noone.png

@@ -21,7 +21,7 @@ public function processRequest() {
 
     $title = pht('%s Configuration', $options->getName());
 
-    $header = id(new PhabricatorHeaderView())
+    $header = id(new PHUIHeaderView())
       ->setHeader($title);
 
     $list = $this->buildOptionList($options->getOptions());

resources/sprite/status_1x/policy-project.png

@@ -17,7 +17,7 @@ public function processRequest() {
     $list = $this->buildIssueList($issues);
     $list->setNoDataString(pht("There are no open setup issues."));
 
-    $header = id(new PhabricatorHeaderView())
+    $header = id(new PHUIHeaderView())
       ->setHeader(pht('Open Phabricator Setup Issues'));
 
     $nav->appendChild(