Fix some Phabricator lint warnings

Summary: Lint.

Test Plan: Lint.

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D6127

Author: epriestley

scripts/user/account_admin.php

@@ -113,8 +113,7 @@
   if (!$verify_email->getIsVerified()) {
     $set_verified = phutil_console_confirm(
       'Should the primary email address be verified?',
-      $default_no = true
-    );
+      $default_no = true);
   } else {
     // already verified so let's not make a fuss
     $verify_email = null;

src/applications/differential/parser/DifferentialHunkParser.php

@@ -585,8 +585,8 @@ public function makeContextDiff(
         $end = $end + $add_context;
         $hunk_content = array();
         $hunk_pos = array( "-" => 0, "+" => 0 );
-        $hunk_offset = array( "-" => NULL, "+" => NULL );
-        $hunk_last = array( "-" => NULL, "+" => NULL );
+        $hunk_offset = array( "-" => null, "+" => null );
+        $hunk_last = array( "-" => null, "+" => null );
         foreach (explode("\n", $hunk->getChanges()) as $line) {
           $in_common = strncmp($line, " ", 1) === 0;
           $in_old = strncmp($line, "-", 1) === 0 || $in_common;
@@ -598,13 +598,13 @@ public function makeContextDiff(
               if (!$skip || ($hunk_pos[$prefix] != $start &&
                 $hunk_pos[$prefix] != $end)) {
                   if ($in_old) {
-                    if ($hunk_offset["-"] === NULL) {
+                    if ($hunk_offset["-"] === null) {
                       $hunk_offset["-"] = $hunk_pos["-"];
                     }
                     $hunk_last["-"] = $hunk_pos["-"];
                   }
                   if ($in_new) {
-                    if ($hunk_offset["+"] === NULL) {
+                    if ($hunk_offset["+"] === null) {
                       $hunk_offset["+"] = $hunk_pos["+"];
                     }
                     $hunk_last["+"] = $hunk_pos["+"];
@@ -617,13 +617,13 @@ public function makeContextDiff(
             if ($in_new) { ++$hunk_pos["+"]; }
           }
         }
-        if ($hunk_offset["-"] !== NULL || $hunk_offset["+"] !== NULL) {
+        if ($hunk_offset["-"] !== null || $hunk_offset["+"] !== null) {
           $header = "@@";
-          if ($hunk_offset["-"] !== NULL) {
+          if ($hunk_offset["-"] !== null) {
             $header .= " -" . ($hunk->getOldOffset() + $hunk_offset["-"]) .
               "," . ($hunk_last["-"] - $hunk_offset["-"] + 1);
           }
-          if ($hunk_offset["+"] !== NULL) {
+          if ($hunk_offset["+"] !== null) {
             $header .= " +" . ($hunk->getNewOffset() + $hunk_offset["+"]) .
               "," . ($hunk_last["+"] - $hunk_offset["+"] + 1);
           }

src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php

@@ -9,7 +9,7 @@ private function createComment() {
   // $length: 0 based (0 meaning 1 line)
   private function createNewComment($line, $length) {
     $comment = $this->createComment();
-    $comment->setIsNewFile(True);
+    $comment->setIsNewFile(true);
     $comment->setLineNumber($line);
     $comment->setLineLength($length);
     return $comment;
@@ -18,7 +18,7 @@ private function createNewComment($line, $length) {
   // $length: 0 based (0 meaning 1 line)
   private function createOldComment($line, $length) {
     $comment = $this->createComment();
-    $comment->setIsNewFile(False);
+    $comment->setIsNewFile(false);
     $comment->setLineNumber($line);
     $comment->setLineLength($length);
     return $comment;

src/applications/phid/PhabricatorObjectHandle.php

@@ -61,12 +61,12 @@ public function getFullName() {
     }
     return $this->getName();
   }
-  
+
   public function setTitle($title) {
     $this->title = $title;
     return $this;
   }
-  
+
   public function getTitle() {
     return $this->title;
   }

src/applications/pholio/editor/PholioMockEditor.php

@@ -144,7 +144,7 @@ protected function sortTransactions(array $xactions) {
     $head = array();
     $tail = array();
 
-    // Move inline comments to the end, so the comments preceed them.
+    // Move inline comments to the end, so the comments precede them.
     foreach ($xactions as $xaction) {
       $type = $xaction->getTransactionType();
       if ($type == PholioTransactionType::TYPE_INLINE) {

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

@@ -841,7 +841,7 @@ protected function sortTransactions(array $xactions) {
     $head = array();
     $tail = array();
 
-    // Move bare comments to the end, so the actions preceed them.
+    // Move bare comments to the end, so the actions precede them.
     foreach ($xactions as $xaction) {
       $type = $xaction->getTransactionType();
       if ($type == PhabricatorTransactions::TYPE_COMMENT) {

src/infrastructure/daemon/bot/adapter/PhabricatorBotBaseStreamingProtocolAdapter.php

@@ -131,7 +131,7 @@ private function processReadBuffer() {
     return false;
   }
 
-  protected function performPost($endpoint, $data = Null) {
+  protected function performPost($endpoint, $data = null) {
     $uri = new PhutilURI($this->server);
     $uri->setPath($endpoint);
 

src/infrastructure/edges/editor/PhabricatorEdgeEditor.php

@@ -355,7 +355,7 @@ private function killTransactions() {
    * response to edits, and is primarily useful when performing migrations. You
    * should not normally need to use it.
    *
-   * @param bool True to supress events related to edits.
+   * @param bool True to suppress events related to edits.
    * @return this
    * @task internal
    */

src/view/layout/PhabricatorCrumbsView.php

@@ -47,8 +47,7 @@ public function render() {
             array(
               'class' => 'phabricator-crumbs-action-name'
             ),
-          $action->getName()
-        );
+          $action->getName());
 
         $action_sigils = $action->getSigils();
         if ($action->getWorkflow()) {

src/view/phui/PHUIFeedStoryView.php

@@ -208,7 +208,7 @@ public function render() {
   }
 
   public function setAppIconFromPHID($phid) {
-    switch(phid_get_type($phid)) {
+    switch (phid_get_type($phid)) {
       case PhabricatorPHIDConstants::PHID_TYPE_MOCK:
         $this->setAppIcon("pholio-dark");
         break;