Conpherence - get back-end prepped for loading less transactions all the time

Summary: this just does the back-end migration. I realized that we don't need to keep track of cacheTitle and cachePhoto since those are based off recent participation handles and dynamic relative to who is viewing it. Also kept the "last seen phid" as I think that will be useful to have auto-scroll to where you last read.  Ref T2867.

Test Plan: did the migration. observed sensical values in the database. created a new conpherence - again sensical values. updated a conpherence - more sensical values.

Reviewers: epriestley, chad

Reviewed By: epriestley

CC: aran, Korvin, AnhNhan

Maniphest Tasks: T2867

Differential Revision: https://secure.phabricator.com/D5567

Author: bobtrahan

resources/sql/patches/20130403.conpherencecache.sql

@@ -0,0 +1,6 @@
+ALTER TABLE {$NAMESPACE}_conpherence.conpherence_thread
+  ADD recentParticipantPHIDs LONGTEXT NOT NULL COLLATE utf8_bin AFTER title,
+  ADD messageCount BIGINT UNSIGNED NOT NULL AFTER title;
+
+ALTER TABLE {$NAMESPACE}_conpherence.conpherence_participant
+  ADD seenMessageCount BIGINT UNSIGNED NOT NULL AFTER behindTransactionPHID;

resources/sql/patches/20130403.conpherencecachemig.php

@@ -0,0 +1,64 @@
+<?php
+
+echo "Migrating data from conpherence transactions to conpherence 'cache'...\n";
+
+$table = new ConpherenceThread();
+$table->openTransaction();
+$conn_w = $table->establishConnection('w');
+
+$participant_table = new ConpherenceParticipant();
+
+$conpherences = new LiskMigrationIterator($table);
+foreach ($conpherences as $conpherence) {
+  echo 'Migrating conpherence #'.$conpherence->getID()."\n";
+
+  $participants = id(new ConpherenceParticipant())
+    ->loadAllWhere('conpherencePHID = %s', $conpherence->getPHID());
+
+  $transactions = id(new ConpherenceTransaction())
+    ->loadAllWhere('objectPHID = %s', $conpherence->getPHID());
+
+  $participation_hash = mgroup($participants, 'getBehindTransactionPHID');
+
+  $message_count = 0;
+  $participants_to_cache = array();
+  foreach ($transactions as $transaction) {
+    $participants_to_cache[] = $transaction->getAuthorPHID();
+    if ($transaction->getTransactionType() ==
+      PhabricatorTransactions::TYPE_COMMENT) {
+      $message_count++;
+    }
+    $participants_to_update = idx(
+      $participation_hash,
+      $transaction->getPHID(),
+      array());
+    if ($participants_to_update) {
+      queryfx(
+        $conn_w,
+        'UPDATE %T SET seenMessageCount = %d '.
+        'WHERE conpherencePHID = %s AND participantPHID IN (%Ls)',
+        $participant_table->getTableName(),
+        $message_count,
+        $conpherence->getPHID(),
+        mpull($participants_to_update, 'getParticipantPHID'));
+    }
+  }
+
+  $participants_to_cache = array_slice(
+    array_unique(array_reverse($participants_to_cache)),
+    0,
+    10);
+  queryfx(
+    $conn_w,
+    'UPDATE %T '.
+    'SET recentParticipantPHIDs = %s, '.
+    'messageCount = %d '.
+    'WHERE phid = %s',
+    $table->getTableName(),
+    json_encode($participants_to_cache),
+    $message_count,
+    $conpherence->getPHID());
+}
+
+$table->saveTransaction();
+echo "\nDone.\n";

src/applications/conpherence/controller/ConpherenceNewController.php

@@ -11,7 +11,8 @@ public function processRequest() {
 
     $conpherence = id(new ConpherenceThread())
       ->attachParticipants(array())
-      ->attachFilePHIDs(array());
+      ->attachFilePHIDs(array())
+      ->setMessageCount(0);
     $title = pht('New Conversation');
     $participants = array();
     $message = '';
@@ -34,6 +35,8 @@ public function processRequest() {
       } else {
         $participants[] = $user->getPHID();
         $participants = array_unique($participants);
+        $conpherence->setRecentParticipantPHIDs(
+          array_slice($participants, 0, 10));
       }
 
       $message = $request->getStr('message');

src/applications/conpherence/controller/ConpherenceViewController.php

@@ -49,7 +49,7 @@ public function processRequest() {
     $transactions = $conpherence->getTransactions();
     $latest_transaction = end($transactions);
     $write_guard = AphrontWriteGuard::beginScopedUnguardedWrites();
-    $participant->markUpToDate($latest_transaction);
+    $participant->markUpToDate($conpherence, $latest_transaction);
     unset($write_guard);
 
     $header = $this->renderHeaderPaneContent();

src/applications/conpherence/editor/ConpherenceEditor.php

@@ -86,11 +86,32 @@ protected function getCustomTransactionNewValue(
     }
   }
 
-  protected function applyCustomInternalTransaction(
+  /**
+   * We really only need a read lock if we have a comment. In that case, we
+   * must update the messagesCount field on the conpherence and
+   * seenMessagesCount(s) for the participant(s).
+   */
+  protected function shouldReadLock(
     PhabricatorLiskDAO $object,
     PhabricatorApplicationTransaction $xaction) {
 
+    $lock = false;
     switch ($xaction->getTransactionType()) {
+      case PhabricatorTransactions::TYPE_COMMENT:
+        $lock =  true;
+        break;
+    }
+
+    return $lock;
+  }
+
+  protected function applyCustomInternalTransaction(
+    PhabricatorLiskDAO $object,
+    PhabricatorApplicationTransaction $xaction) {
+    switch ($xaction->getTransactionType()) {
+      case PhabricatorTransactions::TYPE_COMMENT:
+        $object->setMessageCount((int)$object->getMessageCount() + 1);
+        break;
       case ConpherenceTransactionType::TYPE_TITLE:
         $object->setTitle($xaction->getNewValue());
         break;
@@ -105,6 +126,18 @@ protected function applyCustomInternalTransaction(
           ConpherenceImageData::SIZE_HEAD);
         break;
     }
+    $this->updateRecentParticipantPHIDs($object, $xaction);
+  }
+
+  private function updateRecentParticipantPHIDs(
+    PhabricatorLiskDAO $object,
+    PhabricatorApplicationTransaction $xaction) {
+
+    $participants = $object->getRecentParticipantPHIDs();
+    array_unshift($participants, $xaction->getAuthorPHID());
+    $participants = array_slice(array_unique($participants), 0, 10);
+
+    $object->setRecentParticipantPHIDs($participants);
   }
 
   /**
@@ -148,10 +181,13 @@ protected function applyCustomExternalTransaction(
           if ($phid != $user->getPHID()) {
             if ($participant->getParticipationStatus() != $behind) {
               $participant->setBehindTransactionPHID($xaction_phid);
+              // decrement one as this is the message putting them behind!
+              $participant->setSeenMessageCount($object->getMessageCount() - 1);
             }
             $participant->setParticipationStatus($behind);
             $participant->setDateTouched($time);
           } else {
+            $participant->setSeenMessageCount($object->getMessageCount());
             $participant->setParticipationStatus($up_to_date);
             $participant->setDateTouched($time);
           }
@@ -176,8 +212,10 @@ protected function applyCustomExternalTransaction(
         foreach ($add as $phid) {
           if ($phid == $this->getActor()->getPHID()) {
             $status = ConpherenceParticipationStatus::UP_TO_DATE;
+            $message_count = $object->getMessageCount();
           } else {
             $status = ConpherenceParticipationStatus::BEHIND;
+            $message_count = 0;
           }
           $participants[$phid] =
             id(new ConpherenceParticipant())
@@ -186,6 +224,7 @@ protected function applyCustomExternalTransaction(
             ->setParticipationStatus($status)
             ->setDateTouched(time())
             ->setBehindTransactionPHID($xaction->getPHID())
+            ->setSeenMessageCount($message_count)
             ->save();
         }
         $object->attachParticipants($participants);

src/applications/conpherence/storage/ConpherenceParticipant.php

@@ -9,6 +9,7 @@ final class ConpherenceParticipant extends ConpherenceDAO {
   protected $conpherencePHID;
   protected $participationStatus;
   protected $behindTransactionPHID;
+  protected $seenMessageCount;
   protected $dateTouched;
   protected $settings = array();
 
@@ -24,10 +25,13 @@ public function getSettings() {
     return nonempty($this->settings, array());
   }
 
-  public function markUpToDate(ConpherenceTransaction $xaction) {
+  public function markUpToDate(
+    ConpherenceThread $conpherence,
+    ConpherenceTransaction $xaction) {
     if (!$this->isUpToDate()) {
       $this->setParticipationStatus(ConpherenceParticipationStatus::UP_TO_DATE);
       $this->setBehindTransactionPHID($xaction->getPHID());
+      $this->setSeenMessageCount($conpherence->getMessageCount());
       $this->save();
     }
     return $this;

src/applications/conpherence/storage/ConpherenceThread.php

@@ -9,6 +9,8 @@ final class ConpherenceThread extends ConpherenceDAO
   protected $id;
   protected $phid;
   protected $title;
+  protected $messageCount;
+  protected $recentParticipantPHIDs = array();
   protected $imagePHIDs = array();
   protected $mailKey;
 
@@ -23,7 +25,8 @@ public function getConfiguration() {
     return array(
       self::CONFIG_AUX_PHID => true,
       self::CONFIG_SERIALIZATION => array(
-        'imagePHIDs'  => self::SERIALIZATION_JSON,
+        'recentParticipantPHIDs' => self::SERIALIZATION_JSON,
+        'imagePHIDs' => self::SERIALIZATION_JSON,
       ),
     ) + parent::getConfiguration();
   }

src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php

@@ -1226,7 +1226,14 @@ public function getPatches() {
         'type'    => 'sql',
         'name'    => $this->getPatchPath('20130330.phrequent.sql'),
       ),
+      '20130403.conpherencecache.sql' => array(
+        'type' => 'sql',
+        'name' => $this->getPatchPath('20130403.conpherencecache.sql'),
+      ),
+      '20130403.conpherencecachemig.php' => array(
+        'type' => 'php',
+        'name' => $this->getPatchPath('20130403.conpherencecachemig.php'),
+      )
     );
   }
-
 }