Don't show empty attributes.

Summary: Some places we pass in empty strings and get hanging middots. Would prefer not have the middot, and let the developer decide if they should set a 'nothing here' state.

Test Plan: Checked Repositories with no lint messages.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5920

Author: chadlittle

src/view/layout/PhabricatorObjectItemView.php

@@ -122,7 +122,9 @@ public function getBarColor() {
   }
 
   public function addAttribute($attribute) {
-    $this->attributes[] = $attribute;
+    if (!empty($attribute)) {
+      $this->attributes[] = $attribute;
+    }
     return $this;
   }