Add conduit methods to search legalpad documents and signatures #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umentSearchEngine; add conduit methods
mwaldt
reviewed
Aug 3, 2021
...pplications/legalpad/engineextension/PhabricatorLegalpadSignaturesSearchEngineAttachment.php
Show resolved
Hide resolved
… and dateCreated to signatures
|
Screenshot of my dev instance with both attachment types selected:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this diff, you can search for documents or signatures in conduit. Additionally, you can request all the signatures as an attachment on a document.
Some details:
phidto LegalpadDocumentSignature so that it can be exposed through the standard Conduit search interfaceThis is a bit too large to be an extension, and really should be upstreamed.