support GFM-style code blocks #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thwarted
reviewed
Mar 16, 2022
| if (preg_match('/^\s*```/', $text)) { | ||
| // Look for GFM-style ```langname blocks and handle them | ||
| if (preg_match('/\A\s*``` *([a-z]+)\n/', $text, $matches)) { |
There was a problem hiding this comment.
this code uses ^ elsewhere rather than \A.
There was a problem hiding this comment.
I don't think it makes a difference unless PCRE_MULTILINE is set; I can change it if you prefer
thwarted
approved these changes
Mar 16, 2022
|
This is sent upstream at https://we.phorge.it/D25034 fwiw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to use GitHub-flavored markdown's way of specifying the programming language for highlighting a code block, and thus improves compatibility when rendering READMEs from non-Phabricator projects. I doubt there are any real cases where someone did ```python and expected anything else?