Generic attributes parsing #1301
Draft
+208
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenFordTytherington
force-pushed
the
generic-attributes
branch
2 times, most recently
from
9abdf6a to
40325df
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1301 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 76 +1
Lines 12772 12826 +54
=========================================
+ Hits 12772 12826 +54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add get_one method to ignore duplicates and just get the first
BenFordTytherington
force-pushed
the
generic-attributes
branch
from
40325df to
b5e2b50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalise parsing of attributes, and make it more robust in terms of duplicate attributes, passthrough and reusability.
Fix #1132