Correct a prose diff behavior when prose pieces include newlines

Summary:
See <https://discourse.phabricator-community.org/t/bad-regex-in-prose-diff-logic/3969>.

The prose splitting rules normally guarantee that newlines appear only at the beginning or end of blocks. However, if a prose sentence ends with text like "...x\n.", we can end up with a newline inside a "sentence".

If we do, the regular expression that breaks it into pieces will fail.

Arguably, this is an error in how sentences are split apart (we might prefer to split this into two sentences, "x\n" and ".", rather than a single "x\n." sentence) but in the general case it's not unreasonable for blocks to contain newlines, so a simple fix is to make the pattern more robust.

Test Plan: Added a failing test which includes this behavior, made it pass.

Differential Revision: https://secure.phabricator.com/D21295

Author: epriestley

src/infrastructure/diff/prose/PhutilProseDifferenceEngine.php

@@ -148,7 +148,7 @@ private function stitchPieces(array $pieces, $level) {
         // whitespace at the end.
 
         $matches = null;
-        preg_match('/^(\s*)(.*?)(\s*)\z/', $result, $matches);
+        preg_match('/^(\s*)(.*?)(\s*)\z/s', $result, $matches);
 
         if (strlen($matches[1])) {
           $results[] = $matches[1];

src/infrastructure/diff/prose/__tests__/PhutilProseDiffTestCase.php

@@ -30,6 +30,14 @@ public function testProseDiffsDistance() {
       ),
       pht('Remove Paragraph'));
 
+    $this->assertProseParts(
+       'xxx',
+       "xxxyyy\n.zzz",
+       array(
+         '= xxx',
+         "+ yyy\n.zzz",
+       ),
+       pht('Amend paragraph, and add paragraph starting with punctuation'));
 
     // Without smoothing, the alogorithm identifies that "shark" and "cat"
     // both contain the letter "a" and tries to express this as a very