Make the "attach_inlines" parameter to "differential.createcomment" a no-op

Summary: Ref T13513. See that task for some discussion. This prepares to lift "loadUnsubmittedInlineComments(...)" into shared code.

Test Plan: Grepped for callers, found none in the upstream. This is a backward compatibilty break. See T13513.

Maniphest Tasks: T13513

Differential Revision: https://secure.phabricator.com/D21225

Author: epriestley

src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php

@@ -94,17 +94,8 @@ protected function execute(ConduitAPIRequest $request) {
             ->setContent($content));
     }
 
-    if ($request->getValue('attach_inlines')) {
-      $type_inline = DifferentialTransaction::TYPE_INLINE;
-      $inlines = DifferentialTransactionQuery::loadUnsubmittedInlineComments(
-        $viewer,
-        $revision);
-      foreach ($inlines as $inline) {
-        $xactions[] = id(new DifferentialTransaction())
-          ->setTransactionType($type_inline)
-          ->attachComment($inline);
-      }
-    }
+    // NOTE: The legacy "attach_inlines" flag is now ignored and has no
+    // effect. See T13513.
 
     // NOTE: The legacy "silent" flag is now ignored and has no effect. See
     // T13042.