Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 6dc20d1

Browse files
author
epriestley
committed
Fix an issue where storage inlines are fed to InlineAdjustmentEngine
Summary: Ref T13513. If an intradiff has at least one unchanged file ("hasSameEffectAs()") or more than 100 files ("Large Change"), we hit this block and don't upcast storage inlines to runtime inlines. I missed this in testing. Add the conversion step. Test Plan: Viewed an intradiff with at least one unchanged file and at least one inline comment, saw correct rendering instead of fatal. Maniphest Tasks: T13513 Differential Revision: https://secure.phabricator.com/D21239
1 parent e7ebd5d commit 6dc20d1

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/applications/differential/controller/DifferentialRevisionViewController.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,8 @@ public function handleRequest(AphrontRequest $request) {
234234
->withPublishedComments(true)
235235
->execute();
236236

237+
$inlines = mpull($inlines, 'newInlineCommentObject');
238+
237239
$inlines = id(new PhabricatorInlineCommentAdjustmentEngine())
238240
->setViewer($viewer)
239241
->setRevision($revision)

0 commit comments

Comments
 (0)