Add isNormalMouseEvent() to Javelin

Summary:
Added isNormalMouseEvent() that returns true if left mouse button triggered event click, mousedown or mouseup.
Modified isNormalMouseClick() to use new function.

Test Plan: Verified that new function works for click, mousedown and mouseup events.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2475

Differential Revision: https://secure.phabricator.com/D4778

Author: ljalonen

externals/javelinjs/src/core/Event.js

@@ -133,17 +133,18 @@ JX.install('Event', {
       var r = this.getRawEvent();
       return r.which == 3 || r.button == 2;
     },
-
-
+    
     /**
-     * Determine if a click event is a normal click (left mouse button, no
+     * Determine if a mouse event is a normal event (left mouse button, no
      * modifier keys).
      *
      * @return bool
      * @task info
      */
-    isNormalClick : function() {
-      if (this.getType() != 'click') {
+    isNormalMouseEvent : function() {
+      var supportedEvents = ['click','mouseup','mousedown'];
+
+      if (supportedEvents.indexOf(this.getType()) == -1) {
         return false;
       }
 
@@ -164,6 +165,22 @@ JX.install('Event', {
     },
 
 
+    /**
+     * Determine if a click event is a normal click (left mouse button, no
+     * modifier keys).
+     *
+     * @return bool
+     * @task info
+     */
+    isNormalClick : function() {
+      if (this.getType() != 'click') {
+        return false;
+      }
+
+      return this.isNormalMouseEvent();
+    },
+
+
     /**
      * Get the node corresponding to the specified key in this event's node map.
      * This is a simple helper method that makes the API for accessing nodes

src/__celerity_resource_map__.php

@@ -1850,7 +1850,7 @@
   ),
   'javelin-behavior-pholio-mock-view' =>
   array(
-    'uri' => '/res/10fbdca1/rsrc/js/application/pholio/behavior-pholio-mock-view.js',
+    'uri' => '/res/e7946465/rsrc/js/application/pholio/behavior-pholio-mock-view.js',
     'type' => 'js',
     'requires' =>
     array(
@@ -2038,7 +2038,7 @@
   ),
   'javelin-event' =>
   array(
-    'uri' => '/res/3815b473/rsrc/js/javelin/core/Event.js',
+    'uri' => '/res/fdb41aa9/rsrc/js/javelin/core/Event.js',
     'type' => 'js',
     'requires' =>
     array(
@@ -2694,7 +2694,7 @@
   ),
   'phabricator-header-view-css' =>
   array(
-    'uri' => '/res/0ac01450/rsrc/css/layout/phabricator-header-view.css',
+    'uri' => '/res/585b771c/rsrc/css/layout/phabricator-header-view.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -3380,7 +3380,7 @@
 ), array(
   'packages' =>
   array(
-    '409233b7' =>
+    '6ea96b26' =>
     array(
       'name' => 'core.pkg.css',
       'symbols' =>
@@ -3424,7 +3424,7 @@
         36 => 'phabricator-object-item-list-view-css',
         37 => 'global-drag-and-drop-css',
       ),
-      'uri' => '/res/pkg/409233b7/core.pkg.css',
+      'uri' => '/res/pkg/6ea96b26/core.pkg.css',
       'type' => 'css',
     ),
     '8a3f0fbd' =>
@@ -3555,7 +3555,7 @@
       'uri' => '/res/pkg/f96657b8/diffusion.pkg.js',
       'type' => 'js',
     ),
-    'fbeded59' =>
+    '5f5e63ce' =>
     array(
       'name' => 'javelin.pkg.js',
       'symbols' =>
@@ -3580,7 +3580,7 @@
         17 => 'javelin-typeahead-ondemand-source',
         18 => 'javelin-tokenizer',
       ),
-      'uri' => '/res/pkg/fbeded59/javelin.pkg.js',
+      'uri' => '/res/pkg/5f5e63ce/javelin.pkg.js',
       'type' => 'js',
     ),
     'e30a3fa8' =>
@@ -3614,19 +3614,19 @@
   'reverse' =>
   array(
     'aphront-attached-file-view-css' => 'e30a3fa8',
-    'aphront-crumbs-view-css' => '409233b7',
-    'aphront-dialog-view-css' => '409233b7',
-    'aphront-error-view-css' => '409233b7',
-    'aphront-form-view-css' => '409233b7',
+    'aphront-crumbs-view-css' => '6ea96b26',
+    'aphront-dialog-view-css' => '6ea96b26',
+    'aphront-error-view-css' => '6ea96b26',
+    'aphront-form-view-css' => '6ea96b26',
     'aphront-headsup-action-list-view-css' => 'ec01d039',
-    'aphront-headsup-view-css' => '409233b7',
-    'aphront-list-filter-view-css' => '409233b7',
-    'aphront-pager-view-css' => '409233b7',
-    'aphront-panel-view-css' => '409233b7',
-    'aphront-table-view-css' => '409233b7',
-    'aphront-tokenizer-control-css' => '409233b7',
-    'aphront-tooltip-css' => '409233b7',
-    'aphront-typeahead-control-css' => '409233b7',
+    'aphront-headsup-view-css' => '6ea96b26',
+    'aphront-list-filter-view-css' => '6ea96b26',
+    'aphront-pager-view-css' => '6ea96b26',
+    'aphront-panel-view-css' => '6ea96b26',
+    'aphront-table-view-css' => '6ea96b26',
+    'aphront-tokenizer-control-css' => '6ea96b26',
+    'aphront-tooltip-css' => '6ea96b26',
+    'aphront-typeahead-control-css' => '6ea96b26',
     'differential-changeset-view-css' => 'ec01d039',
     'differential-core-view-css' => 'ec01d039',
     'differential-inline-comment-editor' => '9dae5f20',
@@ -3640,10 +3640,10 @@
     'differential-table-of-contents-css' => 'ec01d039',
     'diffusion-commit-view-css' => 'c8ce2d88',
     'diffusion-icons-css' => 'c8ce2d88',
-    'global-drag-and-drop-css' => '409233b7',
+    'global-drag-and-drop-css' => '6ea96b26',
     'inline-comment-summary-css' => 'ec01d039',
     'javelin-aphlict' => '8a3f0fbd',
-    'javelin-behavior' => 'fbeded59',
+    'javelin-behavior' => '5f5e63ce',
     'javelin-behavior-aphlict-dropdown' => '8a3f0fbd',
     'javelin-behavior-aphlict-listen' => '8a3f0fbd',
     'javelin-behavior-aphront-basic-tokenizer' => '8a3f0fbd',
@@ -3692,66 +3692,66 @@
     'javelin-behavior-repository-crossreference' => '9dae5f20',
     'javelin-behavior-toggle-class' => '8a3f0fbd',
     'javelin-behavior-workflow' => '8a3f0fbd',
-    'javelin-dom' => 'fbeded59',
-    'javelin-event' => 'fbeded59',
-    'javelin-install' => 'fbeded59',
-    'javelin-json' => 'fbeded59',
-    'javelin-mask' => 'fbeded59',
-    'javelin-request' => 'fbeded59',
-    'javelin-resource' => 'fbeded59',
-    'javelin-stratcom' => 'fbeded59',
-    'javelin-tokenizer' => 'fbeded59',
-    'javelin-typeahead' => 'fbeded59',
-    'javelin-typeahead-normalizer' => 'fbeded59',
-    'javelin-typeahead-ondemand-source' => 'fbeded59',
-    'javelin-typeahead-preloaded-source' => 'fbeded59',
-    'javelin-typeahead-source' => 'fbeded59',
-    'javelin-uri' => 'fbeded59',
-    'javelin-util' => 'fbeded59',
-    'javelin-vector' => 'fbeded59',
-    'javelin-workflow' => 'fbeded59',
-    'lightbox-attachment-css' => '409233b7',
+    'javelin-dom' => '5f5e63ce',
+    'javelin-event' => '5f5e63ce',
+    'javelin-install' => '5f5e63ce',
+    'javelin-json' => '5f5e63ce',
+    'javelin-mask' => '5f5e63ce',
+    'javelin-request' => '5f5e63ce',
+    'javelin-resource' => '5f5e63ce',
+    'javelin-stratcom' => '5f5e63ce',
+    'javelin-tokenizer' => '5f5e63ce',
+    'javelin-typeahead' => '5f5e63ce',
+    'javelin-typeahead-normalizer' => '5f5e63ce',
+    'javelin-typeahead-ondemand-source' => '5f5e63ce',
+    'javelin-typeahead-preloaded-source' => '5f5e63ce',
+    'javelin-typeahead-source' => '5f5e63ce',
+    'javelin-uri' => '5f5e63ce',
+    'javelin-util' => '5f5e63ce',
+    'javelin-vector' => '5f5e63ce',
+    'javelin-workflow' => '5f5e63ce',
+    'lightbox-attachment-css' => '6ea96b26',
     'maniphest-task-summary-css' => 'e30a3fa8',
     'maniphest-transaction-detail-css' => 'e30a3fa8',
     'phabricator-busy' => '8a3f0fbd',
     'phabricator-content-source-view-css' => 'ec01d039',
-    'phabricator-core-buttons-css' => '409233b7',
-    'phabricator-core-css' => '409233b7',
-    'phabricator-crumbs-view-css' => '409233b7',
-    'phabricator-directory-css' => '409233b7',
+    'phabricator-core-buttons-css' => '6ea96b26',
+    'phabricator-core-css' => '6ea96b26',
+    'phabricator-crumbs-view-css' => '6ea96b26',
+    'phabricator-directory-css' => '6ea96b26',
     'phabricator-drag-and-drop-file-upload' => '9dae5f20',
     'phabricator-dropdown-menu' => '8a3f0fbd',
     'phabricator-file-upload' => '8a3f0fbd',
-    'phabricator-filetree-view-css' => '409233b7',
-    'phabricator-flag-css' => '409233b7',
-    'phabricator-form-view-css' => '409233b7',
-    'phabricator-header-view-css' => '409233b7',
-    'phabricator-jump-nav' => '409233b7',
+    'phabricator-filetree-view-css' => '6ea96b26',
+    'phabricator-flag-css' => '6ea96b26',
+    'phabricator-form-view-css' => '6ea96b26',
+    'phabricator-header-view-css' => '6ea96b26',
+    'phabricator-jump-nav' => '6ea96b26',
     'phabricator-keyboard-shortcut' => '8a3f0fbd',
     'phabricator-keyboard-shortcut-manager' => '8a3f0fbd',
-    'phabricator-main-menu-view' => '409233b7',
+    'phabricator-main-menu-view' => '6ea96b26',
     'phabricator-menu-item' => '8a3f0fbd',
-    'phabricator-nav-view-css' => '409233b7',
+    'phabricator-nav-view-css' => '6ea96b26',
     'phabricator-notification' => '8a3f0fbd',
-    'phabricator-notification-css' => '409233b7',
-    'phabricator-notification-menu-css' => '409233b7',
-    'phabricator-object-item-list-view-css' => '409233b7',
+    'phabricator-notification-css' => '6ea96b26',
+    'phabricator-notification-menu-css' => '6ea96b26',
+    'phabricator-object-item-list-view-css' => '6ea96b26',
     'phabricator-object-selector-css' => 'ec01d039',
     'phabricator-paste-file-upload' => '8a3f0fbd',
     'phabricator-prefab' => '8a3f0fbd',
     'phabricator-project-tag-css' => 'e30a3fa8',
-    'phabricator-remarkup-css' => '409233b7',
+    'phabricator-remarkup-css' => '6ea96b26',
     'phabricator-shaped-request' => '9dae5f20',
-    'phabricator-side-menu-view-css' => '409233b7',
-    'phabricator-standard-page-view' => '409233b7',
+    'phabricator-side-menu-view-css' => '6ea96b26',
+    'phabricator-standard-page-view' => '6ea96b26',
     'phabricator-textareautils' => '8a3f0fbd',
     'phabricator-tooltip' => '8a3f0fbd',
-    'phabricator-transaction-view-css' => '409233b7',
-    'phabricator-zindex-css' => '409233b7',
-    'sprite-apps-large-css' => '409233b7',
-    'sprite-gradient-css' => '409233b7',
-    'sprite-icon-css' => '409233b7',
-    'sprite-menu-css' => '409233b7',
-    'syntax-highlighting-css' => '409233b7',
+    'phabricator-transaction-view-css' => '6ea96b26',
+    'phabricator-zindex-css' => '6ea96b26',
+    'sprite-apps-large-css' => '6ea96b26',
+    'sprite-gradient-css' => '6ea96b26',
+    'sprite-icon-css' => '6ea96b26',
+    'sprite-menu-css' => '6ea96b26',
+    'syntax-highlighting-css' => '6ea96b26',
   ),
 ));