Skip to content

Commit 8fb227d

Browse files
committedMar 22, 2014
Update Remarkup Note Styles
Summary: Update notes, important, and warnings to look different than codeblocks. Test Plan: test in diviner and legalpad Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin, chad, avivey Differential Revision: https://secure.phabricator.com/D8592
1 parent ae03cb7 commit 8fb227d

File tree

5 files changed

+12
-31
lines changed

5 files changed

+12
-31
lines changed
 

‎resources/celerity/map.php

+3-5
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
return array(
88
'names' =>
99
array(
10-
'core.pkg.css' => '4d72eb6e',
10+
'core.pkg.css' => '5b87dcb0',
1111
'core.pkg.js' => '264721e1',
1212
'darkconsole.pkg.js' => 'ca8671ce',
1313
'differential.pkg.css' => 'cb97e095',
@@ -72,7 +72,6 @@
7272
'rsrc/css/application/flag/flag.css' => '5337623f',
7373
'rsrc/css/application/herald/herald-test.css' => '2b7d0f54',
7474
'rsrc/css/application/herald/herald.css' => '59d48f01',
75-
'rsrc/css/application/legalpad/legalpad-document.css' => 'cd275275',
7675
'rsrc/css/application/maniphest/batch-editor.css' => '8f380ebc',
7776
'rsrc/css/application/maniphest/report.css' => '6fc16517',
7877
'rsrc/css/application/maniphest/task-edit.css' => '8e23031b',
@@ -112,7 +111,7 @@
112111
'rsrc/css/application/tokens/tokens.css' => 'fb286311',
113112
'rsrc/css/application/uiexample/example.css' => '4741b891',
114113
'rsrc/css/core/core.css' => 'da26ddb2',
115-
'rsrc/css/core/remarkup.css' => 'c2bfa678',
114+
'rsrc/css/core/remarkup.css' => 'b4407c57',
116115
'rsrc/css/core/syntax.css' => '3c18c1cb',
117116
'rsrc/css/core/z-index.css' => '0fd29d49',
118117
'rsrc/css/diviner/diviner-shared.css' => '38813222',
@@ -664,7 +663,6 @@
664663
'javelin-view-renderer' => '6c2b09a2',
665664
'javelin-view-visitor' => 'efe49472',
666665
'javelin-workflow' => 'f28bf201',
667-
'legalpad-document-css' => 'cd275275',
668666
'lightbox-attachment-css' => '7acac05d',
669667
'maniphest-batch-editor' => '8f380ebc',
670668
'maniphest-report-css' => '6fc16517',
@@ -709,7 +707,7 @@
709707
'phabricator-prefab' => '0326e5d0',
710708
'phabricator-profile-css' => '9bdb9804',
711709
'phabricator-project-tag-css' => '095c9404',
712-
'phabricator-remarkup-css' => 'c2bfa678',
710+
'phabricator-remarkup-css' => 'b4407c57',
713711
'phabricator-search-results-css' => 'f240504c',
714712
'phabricator-settings-css' => 'ea8f5915',
715713
'phabricator-shaped-request' => 'dfa181a4',

‎src/applications/legalpad/controller/LegalpadDocumentSignController.php

-1
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,6 @@ private function buildDocument(
204204
PhabricatorMarkupEngine $engine,
205205
LegalpadDocumentBody $body) {
206206

207-
$this->requireResource('legalpad-document-css');
208207
return id(new PHUIDocumentView())
209208
->addClass('legalpad')
210209
->setHeader($header)

‎src/applications/legalpad/controller/LegalpadDocumentViewController.php

-1
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ private function buildDocument(
110110
PhabricatorMarkupEngine
111111
$engine, LegalpadDocumentBody $body) {
112112

113-
$this->requireResource('legalpad-document-css');
114113
$view = new PHUIPropertyListView();
115114
$view->addClass('legalpad');
116115
$view->addSectionHeader(pht('Document'));

‎webroot/rsrc/css/application/legalpad/legalpad-document.css

-15
This file was deleted.

‎webroot/rsrc/css/core/remarkup.css

+9-9
Original file line numberDiff line numberDiff line change
@@ -178,23 +178,23 @@
178178
}
179179

180180
.phabricator-remarkup .remarkup-note {
181-
margin: 12px 24px;
182-
padding: 8px;
183-
border: 1px solid {$blue};
181+
margin: 16px 0;
182+
padding: 12px;
183+
border-left: 3px solid {$blue};
184184
background: {$lightblue};
185185
}
186186

187187
.phabricator-remarkup .remarkup-warning {
188-
margin: 12px 24px;
189-
padding: 8px;
190-
border: 1px solid {$yellow};
188+
margin: 16px 0;
189+
padding: 12px;
190+
border-left: 3px solid {$yellow};
191191
background: {$lightyellow};
192192
}
193193

194194
.phabricator-remarkup .remarkup-important {
195-
margin: 12px 24px;
196-
padding: 8px;
197-
border: 1px solid {$red};
195+
margin: 16px 0;
196+
padding: 12px;
197+
border-left: 3px solid {$red};
198198
background: {$lightred};
199199
}
200200

0 commit comments

Comments
 (0)
Failed to load comments.