Enforce consistent code style with flake8

Author: 1st1

.ci/requirements.txt

@@ -4,3 +4,4 @@ tinys3
 twine
 psutil
 pyOpenSSL==18.0.0
+flake8>=3.7.5

.flake8

@@ -0,0 +1,6 @@
+[flake8]
+filename = *.py,*.pyx,*.pxd,*.pxi
+ignore = E402,E731,D100,D101,D102,D103,D104,D105,W503,W504,E252
+exclude = .git,__pycache__,build,dist,.eggs,postgres,vendor
+
+per-file-ignores = *.pyx,*.pxd,*.pxi: E211, E222, E225, E226, E227, E999

docs/conf.py

@@ -8,7 +8,8 @@
 sys.path.insert(0, os.path.abspath('..'))
 
 with open(os.path.abspath('../setup.py'), 'rt') as f:
-    _m = re.search(r'''VERSION\s*=\s*(?P<q>'|")(?P<ver>[\d\.]+)(?P=q)''', f.read())
+    _m = re.search(r'''VERSION\s*=\s*(?P<q>'|")(?P<ver>[\d\.]+)(?P=q)''',
+                   f.read())
     if not _m:
         raise RuntimeError('unable to read the version from setup.py')
     version = _m.group('ver')

examples/bench/echoclient.py

@@ -47,7 +47,7 @@
     MSGSIZE = args.msize
     REQSIZE = MSGSIZE * args.mpr
 
-    msg = b'x'*(MSGSIZE - 1) + b'\n'
+    msg = b'x' * (MSGSIZE - 1) + b'\n'
     if args.mpr:
         msg *= args.mpr
 
@@ -90,6 +90,6 @@ def run_test(n):
             for _ in range(N):
                 e.submit(run_test, NMESSAGES)
     end = time.time()
-    duration = end-start
+    duration = end - start
     print(NMESSAGES * N * TIMES, 'in', duration)
     print(NMESSAGES * N * TIMES / duration, 'requests/sec')

examples/bench/rlserver.py

@@ -2,9 +2,7 @@
 import asyncio
 import gc
 import os.path
-import socket as socket_module
-
-from socket import *
+import socket as stdsock
 
 
 PRINT = 0
@@ -13,7 +11,8 @@
 async def echo_client_streams(reader, writer):
     sock = writer.get_extra_info('socket')
     try:
-        sock.setsockopt(IPPROTO_TCP, TCP_NODELAY, 1)
+        sock.setsockopt(
+            stdsock.IPPROTO_TCP, stdsock.TCP_NODELAY, 1)
     except (OSError, NameError):
         pass
     if PRINT:

requirements.dev.txt

@@ -2,3 +2,4 @@ Cython==0.29.0
 Sphinx>=1.4.1
 psutil
 pyOpenSSL==18.0.0
+flake8>=3.7.5

tests/test_aiohttp.py

@@ -101,7 +101,6 @@ async def stop():
         self.loop.run_until_complete(stop())
 
 
-
 @unittest.skipIf(skip_tests, "no aiohttp module")
 class Test_UV_AioHTTP(_TestAioHTTP, tb.UVTestCase):
     pass

tests/test_pipes.py

@@ -224,12 +224,12 @@ def reader(data):
             return len(data)
 
         tb.run_until(self.loop, lambda: reader(data) >= 1,
-                             timeout=10)
+                     timeout=10)
         self.assertEqual(b'1', data)
 
         transport.write(b'2345')
         tb.run_until(self.loop, lambda: reader(data) >= 5,
-                             timeout=10)
+                     timeout=10)
         self.assertEqual(b'12345', data)
         self.assertEqual('CONNECTED', proto.state)
 

tests/test_signals.py

@@ -270,7 +270,8 @@ def test_signals_invalid_signal(self):
             self.loop.add_signal_handler(signal.SIGKILL, lambda *a: None)
 
     def test_signals_coro_callback(self):
-        async def coro(): pass
+        async def coro():
+            pass
         with self.assertRaisesRegex(TypeError, 'coroutines cannot be used'):
             self.loop.add_signal_handler(signal.SIGHUP, coro)
 

tests/test_sourcecode.py

@@ -0,0 +1,37 @@
+import os
+import subprocess
+import sys
+import unittest
+
+
+def find_uvloop_root():
+    return os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
+
+
+class TestFlake8(unittest.TestCase):
+
+    @unittest.skipIf(sys.version_info < (3, 6, 0),
+                     "flake8 under 3.5 does not recognize f-strings in *.pyx")
+    def test_flake8(self):
+        edgepath = find_uvloop_root()
+        config_path = os.path.join(edgepath, '.flake8')
+        if not os.path.exists(config_path):
+            raise RuntimeError('could not locate .flake8 file')
+
+        try:
+            import flake8  # NoQA
+        except ImportError:
+            raise unittest.SkipTest('flake8 moudule is missing')
+
+        for subdir in ['examples', 'uvloop', 'tests']:
+            try:
+                subprocess.run(
+                    [sys.executable, '-m', 'flake8', '--config', config_path],
+                    check=True,
+                    stdout=subprocess.PIPE,
+                    stderr=subprocess.PIPE,
+                    cwd=os.path.join(edgepath, subdir))
+            except subprocess.CalledProcessError as ex:
+                output = ex.output.decode()
+                raise AssertionError(
+                    'flake8 validation failed:\n{}'.format(output)) from None