-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix files with few MyPy typing errors #4263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix files with few MyPy typing errors #4263
Conversation
…m_scene in the class FadeOut
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I left some change requests:
Co-authored-by: Francisco Manríquez Novoa <49853152+chopan050@users.noreply.github.com>
Co-authored-by: Francisco Manríquez Novoa <49853152+chopan050@users.noreply.github.com>
Co-authored-by: Francisco Manríquez Novoa <49853152+chopan050@users.noreply.github.com>
Co-authored-by: Francisco Manríquez Novoa <49853152+chopan050@users.noreply.github.com>
Co-authored-by: Francisco Manríquez Novoa <49853152+chopan050@users.noreply.github.com>
Co-authored-by: Francisco Manríquez Novoa <49853152+chopan050@users.noreply.github.com>
Cleaner way to indicate the float type Co-authored-by: Francisco Manríquez Novoa <49853152+chopan050@users.noreply.github.com>
Co-authored-by: Francisco Manríquez Novoa <49853152+chopan050@users.noreply.github.com>
Thanks for your detailed comments. I have addressed all of the raised issues, in most cases by accepting your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I missed some last small things in mypy.ini
. Could you please check them as well? After that, we should be ready to approve and merge this!
I also noticed that you modified a lot of files, but only some of them are indicated in mypy.ini
for MyPy to stop ignoring their errors. Maybe you would like to add some more files in there? In particular, manim.animation.numbers
, manim.scene.moving_camera_scene
and manim.scene.section
seem fine to me and MyPy didn't return any errors after adding them to mypy.ini
, although manim.mobject.logo
and the other animations you didn't add did throw some errors.
Co-authored-by: Francisco Manríquez Novoa <49853152+chopan050@users.noreply.github.com>
Co-authored-by: Francisco Manríquez Novoa <49853152+chopan050@users.noreply.github.com>
Co-authored-by: Francisco Manríquez Novoa <49853152+chopan050@users.noreply.github.com>
Co-authored-by: Francisco Manríquez Novoa <49853152+chopan050@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Overview: What does this pull request change?
In this pull request I have addressed some of the files with only a few reported mypy errors.
Further Information and Comments
To identify files with few mypy errors, I cleared the mypy.ini file so no detected errors would be ignored and then used the follwing command
I hope that this approach will make it easier to deal with the large files that needs a lot of type annotations added.
Reviewer Checklist