Skip to content

Commit c80d697

Browse files
committed
Drop '@brief' from doxygen comments
LLVM's coding guideline suggests to not use @brief for one-sentence doxygen comments to improve readability. Switch this once and for all to ensure people do not copy @brief comments from other parts of Polly, when writing new code. llvm-svn: 280468
1 parent ad79bf4 commit c80d697

39 files changed

+900
-897
lines changed

polly/include/polly/Canonicalization.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
namespace polly {
1616

17-
/// @brief Schedule a set of canonicalization passes to prepare for Polly
17+
/// Schedule a set of canonicalization passes to prepare for Polly.
1818
///
1919
/// The set of optimization passes was partially taken/copied from the
2020
/// set of default optimization passes in LLVM. It is used to bring the code

polly/include/polly/CodeGen/BlockGenerators.h

Lines changed: 63 additions & 63 deletions
Large diffs are not rendered by default.

polly/include/polly/CodeGen/IRBuilder.h

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class ScalarEvolution;
2626
namespace polly {
2727
class Scop;
2828

29-
/// @brief Helper class to annotate newly generated SCoPs with metadata.
29+
/// Helper class to annotate newly generated SCoPs with metadata.
3030
///
3131
/// The annotations are twofold:
3232
/// 1) Loops are stored in a stack-like structure in the order they are
@@ -44,23 +44,23 @@ class ScopAnnotator {
4444
public:
4545
ScopAnnotator();
4646

47-
/// @brief Build all alias scopes for the given SCoP.
47+
/// Build all alias scopes for the given SCoP.
4848
void buildAliasScopes(Scop &S);
4949

50-
/// @brief Add a new loop @p L which is parallel if @p IsParallel is true.
50+
/// Add a new loop @p L which is parallel if @p IsParallel is true.
5151
void pushLoop(llvm::Loop *L, bool IsParallel);
5252

53-
/// @brief Remove the last added loop.
53+
/// Remove the last added loop.
5454
void popLoop(bool isParallel);
5555

56-
/// @brief Annotate the new instruction @p I for all parallel loops.
56+
/// Annotate the new instruction @p I for all parallel loops.
5757
void annotate(llvm::Instruction *I);
5858

59-
/// @brief Annotate the loop latch @p B wrt. @p L.
59+
/// Annotate the loop latch @p B wrt. @p L.
6060
void annotateLoopLatch(llvm::BranchInst *B, llvm::Loop *L,
6161
bool IsParallel) const;
6262

63-
/// @brief Add alternative alias based pointers
63+
/// Add alternative alias based pointers
6464
///
6565
/// When annotating instructions with alias scope metadata, the right metadata
6666
/// is identified through the base pointer of the memory access. In some cases
@@ -77,34 +77,34 @@ class ScopAnnotator {
7777
AlternativeAliasBases.insert(NewMap.begin(), NewMap.end());
7878
}
7979

80-
/// @brief Delete the set of alternative alias bases
80+
/// Delete the set of alternative alias bases
8181
void resetAlternativeAliasBases() { AlternativeAliasBases.clear(); }
8282

8383
private:
84-
/// @brief The ScalarEvolution analysis we use to find base pointers.
84+
/// The ScalarEvolution analysis we use to find base pointers.
8585
llvm::ScalarEvolution *SE;
8686

87-
/// @brief All loops currently under construction.
87+
/// All loops currently under construction.
8888
llvm::SmallVector<llvm::Loop *, 8> ActiveLoops;
8989

90-
/// @brief Metadata pointing to parallel loops currently under construction.
90+
/// Metadata pointing to parallel loops currently under construction.
9191
llvm::SmallVector<llvm::MDNode *, 8> ParallelLoops;
9292

93-
/// @brief The alias scope domain for the current SCoP.
93+
/// The alias scope domain for the current SCoP.
9494
llvm::MDNode *AliasScopeDomain;
9595

96-
/// @brief A map from base pointers to its alias scope.
96+
/// A map from base pointers to its alias scope.
9797
llvm::DenseMap<llvm::AssertingVH<llvm::Value>, llvm::MDNode *> AliasScopeMap;
9898

99-
/// @brief A map from base pointers to an alias scope list of other pointers.
99+
/// A map from base pointers to an alias scope list of other pointers.
100100
llvm::DenseMap<llvm::AssertingVH<llvm::Value>, llvm::MDNode *>
101101
OtherAliasScopeListMap;
102102

103103
llvm::DenseMap<llvm::AssertingVH<llvm::Value>, llvm::AssertingVH<llvm::Value>>
104104
AlternativeAliasBases;
105105
};
106106

107-
/// @brief Add Polly specifics when running IRBuilder.
107+
/// Add Polly specifics when running IRBuilder.
108108
///
109109
/// This is used to add additional items such as e.g. the llvm.loop.parallel
110110
/// metadata.
@@ -132,7 +132,7 @@ class IRInserter : protected llvm::IRBuilderDefaultInserter {
132132
// matches for certain names.
133133
typedef llvm::IRBuilder<llvm::ConstantFolder, IRInserter> PollyIRBuilder;
134134

135-
/// @brief Return an IR builder pointed before the @p BB terminator.
135+
/// Return an IR builder pointed before the @p BB terminator.
136136
static inline PollyIRBuilder createPollyIRBuilder(llvm::BasicBlock *BB,
137137
ScopAnnotator &LA) {
138138
PollyIRBuilder Builder(BB->getContext(), llvm::ConstantFolder(),

polly/include/polly/CodeGen/IslAst.h

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,10 @@ class IslAst {
5353

5454
__isl_give isl_ast_node *getAst();
5555

56-
/// @brief Get the run-time conditions for the Scop.
56+
/// Get the run-time conditions for the Scop.
5757
__isl_give isl_ast_expr *getRunCondition();
5858

59-
/// @brief Build run-time condition for scop.
59+
/// Build run-time condition for scop.
6060
///
6161
/// @param S The scop to build the condition for.
6262
/// @param Build The isl_build object to use to build the condition.
@@ -79,36 +79,36 @@ class IslAstInfo : public ScopPass {
7979
public:
8080
using MemoryAccessSet = SmallPtrSet<MemoryAccess *, 4>;
8181

82-
/// @brief Payload information used to annotate an AST node.
82+
/// Payload information used to annotate an AST node.
8383
struct IslAstUserPayload {
84-
/// @brief Construct and initialize the payload.
84+
/// Construct and initialize the payload.
8585
IslAstUserPayload()
8686
: IsInnermost(false), IsInnermostParallel(false),
8787
IsOutermostParallel(false), IsReductionParallel(false),
8888
MinimalDependenceDistance(nullptr), Build(nullptr) {}
8989

90-
/// @brief Cleanup all isl structs on destruction.
90+
/// Cleanup all isl structs on destruction.
9191
~IslAstUserPayload();
9292

93-
/// @brief Flag to mark innermost loops.
93+
/// Flag to mark innermost loops.
9494
bool IsInnermost;
9595

96-
/// @brief Flag to mark innermost parallel loops.
96+
/// Flag to mark innermost parallel loops.
9797
bool IsInnermostParallel;
9898

99-
/// @brief Flag to mark outermost parallel loops.
99+
/// Flag to mark outermost parallel loops.
100100
bool IsOutermostParallel;
101101

102-
/// @brief Flag to mark parallel loops which break reductions.
102+
/// Flag to mark parallel loops which break reductions.
103103
bool IsReductionParallel;
104104

105-
/// @brief The minimal dependence distance for non parallel loops.
105+
/// The minimal dependence distance for non parallel loops.
106106
isl_pw_aff *MinimalDependenceDistance;
107107

108-
/// @brief The build environment at the time this node was constructed.
108+
/// The build environment at the time this node was constructed.
109109
isl_ast_build *Build;
110110

111-
/// @brief Set of accesses which break reduction dependences.
111+
/// Set of accesses which break reduction dependences.
112112
MemoryAccessSet BrokenReductions;
113113
};
114114

@@ -120,22 +120,22 @@ class IslAstInfo : public ScopPass {
120120
static char ID;
121121
IslAstInfo() : ScopPass(ID), S(nullptr), Ast(nullptr) {}
122122

123-
/// @brief Build the AST for the given SCoP @p S.
123+
/// Build the AST for the given SCoP @p S.
124124
bool runOnScop(Scop &S) override;
125125

126-
/// @brief Register all analyses and transformation required.
126+
/// Register all analyses and transformation required.
127127
void getAnalysisUsage(AnalysisUsage &AU) const override;
128128

129-
/// @brief Release the internal memory.
129+
/// Release the internal memory.
130130
void releaseMemory() override;
131131

132-
/// @brief Print a source code representation of the program.
132+
/// Print a source code representation of the program.
133133
void printScop(llvm::raw_ostream &OS, Scop &S) const override;
134134

135-
/// @brief Return a copy of the AST root node.
135+
/// Return a copy of the AST root node.
136136
__isl_give isl_ast_node *getAst() const;
137137

138-
/// @brief Get the run condition.
138+
/// Get the run condition.
139139
///
140140
/// Only if the run condition evaluates at run-time to a non-zero value, the
141141
/// assumptions that have been taken hold. If the run condition evaluates to
@@ -147,38 +147,38 @@ class IslAstInfo : public ScopPass {
147147
///
148148
///{
149149

150-
/// @brief Get the complete payload attached to @p Node.
150+
/// Get the complete payload attached to @p Node.
151151
static IslAstUserPayload *getNodePayload(__isl_keep isl_ast_node *Node);
152152

153-
/// @brief Is this loop an innermost loop?
153+
/// Is this loop an innermost loop?
154154
static bool isInnermost(__isl_keep isl_ast_node *Node);
155155

156-
/// @brief Is this loop a parallel loop?
156+
/// Is this loop a parallel loop?
157157
static bool isParallel(__isl_keep isl_ast_node *Node);
158158

159-
/// @brief Is this loop an outermost parallel loop?
159+
/// Is this loop an outermost parallel loop?
160160
static bool isOutermostParallel(__isl_keep isl_ast_node *Node);
161161

162-
/// @brief Is this loop an innermost parallel loop?
162+
/// Is this loop an innermost parallel loop?
163163
static bool isInnermostParallel(__isl_keep isl_ast_node *Node);
164164

165-
/// @brief Is this loop a reduction parallel loop?
165+
/// Is this loop a reduction parallel loop?
166166
static bool isReductionParallel(__isl_keep isl_ast_node *Node);
167167

168-
/// @brief Will the loop be run as thread parallel?
168+
/// Will the loop be run as thread parallel?
169169
static bool isExecutedInParallel(__isl_keep isl_ast_node *Node);
170170

171-
/// @brief Get the nodes schedule or a nullptr if not available.
171+
/// Get the nodes schedule or a nullptr if not available.
172172
static __isl_give isl_union_map *getSchedule(__isl_keep isl_ast_node *Node);
173173

174-
/// @brief Get minimal dependence distance or nullptr if not available.
174+
/// Get minimal dependence distance or nullptr if not available.
175175
static __isl_give isl_pw_aff *
176176
getMinimalDependenceDistance(__isl_keep isl_ast_node *Node);
177177

178-
/// @brief Get the nodes broken reductions or a nullptr if not available.
178+
/// Get the nodes broken reductions or a nullptr if not available.
179179
static MemoryAccessSet *getBrokenReductions(__isl_keep isl_ast_node *Node);
180180

181-
/// @brief Get the nodes build context or a nullptr if not available.
181+
/// Get the nodes build context or a nullptr if not available.
182182
static __isl_give isl_ast_build *getBuild(__isl_keep isl_ast_node *Node);
183183

184184
///}

polly/include/polly/CodeGen/IslExprBuilder.h

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ template <> class PointerLikeTypeTraits<isl_id *> {
4141
namespace polly {
4242
class ScopArrayInfo;
4343

44-
/// @brief LLVM-IR generator for isl_ast_expr[essions]
44+
/// LLVM-IR generator for isl_ast_expr[essions]
4545
///
4646
/// This generator generates LLVM-IR that performs the computation described by
4747
/// an isl_ast_expr[ession].
@@ -90,12 +90,12 @@ class ScopArrayInfo;
9090
///
9191
class IslExprBuilder {
9292
public:
93-
/// @brief A map from isl_ids to llvm::Values.
93+
/// A map from isl_ids to llvm::Values.
9494
typedef llvm::MapVector<isl_id *, llvm::AssertingVH<llvm::Value>> IDToValueTy;
9595

9696
typedef llvm::MapVector<isl_id *, const ScopArrayInfo *> IDToScopArrayInfoTy;
9797

98-
/// @brief A map from isl_ids to ScopArrayInfo objects.
98+
/// A map from isl_ids to ScopArrayInfo objects.
9999
///
100100
/// This map is used to obtain ScopArrayInfo objects for isl_ids which do not
101101
/// carry a ScopArrayInfo object in their user pointer. This is useful if the
@@ -107,12 +107,12 @@ class IslExprBuilder {
107107
/// code generation.
108108
IDToScopArrayInfoTy *IDToSAI = nullptr;
109109

110-
/// @brief Set the isl_id to ScopArrayInfo map.
110+
/// Set the isl_id to ScopArrayInfo map.
111111
///
112112
/// @param NewIDToSAI The new isl_id to ScopArrayInfo map to use.
113113
void setIDToSAI(IDToScopArrayInfoTy *NewIDToSAI) { IDToSAI = NewIDToSAI; }
114114

115-
/// @brief Construct an IslExprBuilder.
115+
/// Construct an IslExprBuilder.
116116
///
117117
/// @param Builder The IRBuilder used to construct the isl_ast_expr[ession].
118118
/// The insert location of this IRBuilder defines WHERE the
@@ -127,22 +127,22 @@ class IslExprBuilder {
127127
llvm::ScalarEvolution &SE, llvm::DominatorTree &DT,
128128
llvm::LoopInfo &LI);
129129

130-
/// @brief Create LLVM-IR for an isl_ast_expr[ession].
130+
/// Create LLVM-IR for an isl_ast_expr[ession].
131131
///
132132
/// @param Expr The ast expression for which we generate LLVM-IR.
133133
///
134134
/// @return The llvm::Value* containing the result of the computation.
135135
llvm::Value *create(__isl_take isl_ast_expr *Expr);
136136

137-
/// @brief Return the largest of two types.
137+
/// Return the largest of two types.
138138
///
139139
/// @param T1 The first type.
140140
/// @param T2 The second type.
141141
///
142142
/// @return The largest of the two types.
143143
llvm::Type *getWidestType(llvm::Type *T1, llvm::Type *T2);
144144

145-
/// @brief Return the type with which this expression should be computed.
145+
/// Return the type with which this expression should be computed.
146146
///
147147
/// The type needs to be large enough to hold all possible input and all
148148
/// possible output values.
@@ -151,15 +151,15 @@ class IslExprBuilder {
151151
/// @return The type with which the expression should be computed.
152152
llvm::IntegerType *getType(__isl_keep isl_ast_expr *Expr);
153153

154-
/// @brief Change if runtime overflows are tracked or not.
154+
/// Change if runtime overflows are tracked or not.
155155
///
156156
/// @param Enable Flag to enable/disable the tracking.
157157
///
158158
/// Note that this will reset the tracking state and that tracking is only
159159
/// allowed if the last tracked expression dominates the current insert point.
160160
void setTrackOverflow(bool Enable);
161161

162-
/// @brief Return the current overflow status or nullptr if it is not tracked.
162+
/// Return the current overflow status or nullptr if it is not tracked.
163163
///
164164
/// @return A nullptr if tracking is disabled or otherwise an i1 that has the
165165
/// value of "0" if and only if no overflow happened since tracking
@@ -169,7 +169,7 @@ class IslExprBuilder {
169169
private:
170170
Scop &S;
171171

172-
/// @brief Flag that will be set if an overflow occurred at runtime.
172+
/// Flag that will be set if an overflow occurred at runtime.
173173
///
174174
/// Note that this flag is by default a nullptr and if it is a nullptr
175175
/// we will not record overflows but simply perform the computations.
@@ -205,7 +205,7 @@ class IslExprBuilder {
205205
llvm::Value *createOpAddressOf(__isl_take isl_ast_expr *Expr);
206206
llvm::Value *createAccessAddress(__isl_take isl_ast_expr *Expr);
207207

208-
/// @brief Create a binary operation @p Opc and track overflows if requested.
208+
/// Create a binary operation @p Opc and track overflows if requested.
209209
///
210210
/// @param OpC The binary operation that should be performed [Add/Sub/Mul].
211211
/// @param LHS The left operand.
@@ -217,7 +217,7 @@ class IslExprBuilder {
217217
llvm::Value *LHS, llvm::Value *RHS,
218218
const llvm::Twine &Name);
219219

220-
/// @brief Create an addition and track overflows if requested.
220+
/// Create an addition and track overflows if requested.
221221
///
222222
/// @param LHS The left operand.
223223
/// @param RHS The right operand.
@@ -227,7 +227,7 @@ class IslExprBuilder {
227227
llvm::Value *createAdd(llvm::Value *LHS, llvm::Value *RHS,
228228
const llvm::Twine &Name = "");
229229

230-
/// @brief Create a subtraction and track overflows if requested.
230+
/// Create a subtraction and track overflows if requested.
231231
///
232232
/// @param LHS The left operand.
233233
/// @param RHS The right operand.
@@ -237,7 +237,7 @@ class IslExprBuilder {
237237
llvm::Value *createSub(llvm::Value *LHS, llvm::Value *RHS,
238238
const llvm::Twine &Name = "");
239239

240-
/// @brief Create a multiplication and track overflows if requested.
240+
/// Create a multiplication and track overflows if requested.
241241
///
242242
/// @param LHS The left operand.
243243
/// @param RHS The right operand.

0 commit comments

Comments
 (0)