add the new vstring API to Devel::PPPort #23160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it also needs to be added to I've never been 100% sure of how that part works, but I suspect it needs to be set to |
tonycoz
added a commit
to tonycoz/perl5
that referenced
this pull request
Mar 31, 2025
Based on @Leont's comment on Perl#23160. This seems to produce reasonable results: tony@venus:.../git/perl6$ cat foo.c SvVSTRING tony@venus:.../git/perl6$ ./perl -Ilib dist/Devel-PPPort/ppport.h --nofilter foo.c Scanning foo.c ... === Analyzing foo.c === Uses SvVSTRING, which depends on sv_vstring_get, SvVSTRING_mg, mg_find, PERL_MAGIC_vstring, SvMAGICAL File needs sv_vstring_get, adding static request Needs to include 'ppport.h' Analysis completed Suggested changes: --- foo.c 2025-04-01 10:51:39.040415623 +1100 +++ foo.c.patched 2025-04-01 10:55:11.347014468 +1100 @@ -1 +1,3 @@ +#define NEED_sv_vstring_get +#include "ppport.h" SvVSTRING
Leont
approved these changes
Apr 1, 2025
A change I made caused this to fail, tracking it down was rough.
This is especially handy when tracking down problems with Devel::PPPort, since so much is generated.
vstrings were originally added in perl-5.8.0-82-g92f0c26562, SvVSTRING_mg() was originally added in perl-5.8.0-8018-gb0a11fe104 so technically in the same release. I expect there were some uses of intermediate versions 19 years ago, but I don't think we need to worry about it now.
Based on @Leont's comment on Perl#23160. This seems to produce reasonable results: tony@venus:.../git/perl6$ cat foo.c SvVSTRING tony@venus:.../git/perl6$ ./perl -Ilib dist/Devel-PPPort/ppport.h --nofilter foo.c Scanning foo.c ... === Analyzing foo.c === Uses SvVSTRING, which depends on sv_vstring_get, SvVSTRING_mg, mg_find, PERL_MAGIC_vstring, SvMAGICAL File needs sv_vstring_get, adding static request Needs to include 'ppport.h' Analysis completed Suggested changes: --- foo.c 2025-04-01 10:51:39.040415623 +1100 +++ foo.c.patched 2025-04-01 10:55:11.347014468 +1100 @@ -1 +1,3 @@ +#define NEED_sv_vstring_get +#include "ppport.h" SvVSTRING
tonycoz
force-pushed
the
23075-vstring-api
branch
from
996e27b to
0a223ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the new vstring APIs to ppport.h
Also improves a Devel::PPPort test and extends
Porting/test-dist-modules.plto aid in development.