Nuke the MGf_PERSIST flag, freeing a bit in ->mg_flags #23161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MGf_PERSIST flag is only used by PERL_MAGIC_lvref, and there it simply contains a shadow copy of the OPpLVREF_ITER flag in op_private. Since the mg_priv field is set as a copy of op_private anyway, the code that checks this bit might as well look there instead. As a result of this change, the 0x80 bit of the mg_flags field is now free for other purposes.
tonycoz
approved these changes
Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MGf_PERSIST flag is only used by PERL_MAGIC_lvref, and there it simply contains a shadow copy of the OPpLVREF_ITER flag in op_private. Since the mg_priv field is set as a copy of op_private anyway, the code that checks this bit might as well look there instead.
As a result of this change, the 0x80 bit of the mg_flags field is now free for other purposes.