Skip to content

RMG - Make last_version handle smoothly provided RC version numbers #23168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

thibaultduponchelle
Copy link
Member

@thibaultduponchelle thibaultduponchelle commented Apr 2, 2025

Description

Current release manager guide generator (make-rmg-checklist) complains about RC versions:

$ perl make-rmg-checklist --version 5.42.0-RC1 --html | head
Argument "0-RC1" isn't numeric in numeric eq (==) at make-rmg-checklist line 156.
...

@karenetheridge


  • This set of changes does not require a perldelta entry.

Copy link
Contributor

@book book left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The $maybe_rc variable is not used.

@thibaultduponchelle thibaultduponchelle force-pushed the last_version_compatible_with_rc branch from a843ff8 to 8a85c35 Compare April 3, 2025 06:50
@thibaultduponchelle
Copy link
Member Author

The $maybe_rc variable is not used.

Removed the unused variable

Copy link
Member

@karenetheridge karenetheridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thibaultduponchelle thibaultduponchelle merged commit aed235e into Perl:blead Apr 4, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants