[dotnet] [bidi] Support WebExtension module

[nvborisenko]

User description

https://w3c.github.io/webdriver-bidi/#module-webExtension

🔗 Related Issues

💥 What does this PR do?

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

• Cleanup (formatting, renaming)
• Bug fix (backwards compatible)
• New feature (non-breaking change which adds functionality and tests!)
• Breaking change (fix or feature that would cause existing functionality to change)

---

PR Type

Enhancement

---

Description

• Add WebExtension BiDi module support for .NET

• Implement install/uninstall extension commands with multiple data formats

• Add JSON serialization and converter infrastructure

• Include comprehensive test suite with Bazel integration

---

Diagram Walkthrough

Loading

flowchart LR
  BiDi["BiDi Class"] --> WebExtModule["WebExtensionModule"]
  WebExtModule --> InstallCmd["Install Command"]
  WebExtModule --> UninstallCmd["Uninstall Command"]
  InstallCmd --> ExtData["Extension Data Types"]
  ExtData --> PathExt["Path Extension"]
  ExtData --> ArchiveExt["Archive Extension"]
  ExtData --> Base64Ext["Base64 Extension"]
  Broker["Communication Broker"] --> Converter["WebExtension Converter"]
  Tests["Test Suite"] --> TestData["Bazel Test Data"]

File Walkthrough

	Relevant files
Enhancement	6 files BiDi.cs Add WebExtension module property                                                  +14/-0    WebExtensionConverter.cs Create Extension JSON converter                                                    +47/-0    Extension.cs Define Extension entity class                                                        +40/-0    InstallCommand.cs Implement install command with data types                                +44/-0    UninstallCommand.cs Implement uninstall command                                                            +29/-0    WebExtensionModule.cs Create WebExtension module class                                                  +40/-0
Configuration changes	5 files Broker.cs Register WebExtension JSON converter                                          +1/-0      BiDiJsonSerializerContext.cs Add WebExtension command serialization support                      +4/-0      BUILD.bazel Add dotnet test visibility                                                              +1/-0      BUILD.bazel Include extensions test data                                                          +1/-0      Selenium.WebDriver.Common.Tests.csproj Copy extension files to output                                                      +4/-0
Tests	1 files WebExtensionTest.cs Add comprehensive WebExtension tests                                          +96/-0

---

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ❌ 1234 - Not compliant Non-compliant requirements: • Fix issue where Selenium 2.48 doesn't trigger JavaScript in link's href on click() in Firefox 42.0 • Ensure JavaScript alerts are triggered properly when clicking links with JavaScript in href attribute 5678 - Not compliant Non-compliant requirements: • Fix "ConnectFailure (Connection refused)" error when instantiating ChromeDriver multiple times • Ensure subsequent ChromeDriver instances can be created without connection errors

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Method Visibility The UninstallAsync method is marked as internal while it's being called from the public Extension class. Consider making this method public for consistency and to allow direct uninstallation without going through the Extension object. internal async Task UninstallAsync(Extension extension, UninstallOptions? options = null) { var @params = new UninstallCommandParameters(extension); await Broker.ExecuteCommandAsync(new UninstallCommand(@params), options).ConfigureAwait(false); }

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Fix inheritance contradiction The InstallResult class inherits from EmptyResult but also contains an Extension property, which is contradictory. Either make it a standalone result class or ensure it properly extends the base class without conflicting behavior. dotnet/src/webdriver/BiDi/WebExtension/InstallCommand.cs [44] -public record InstallResult(Extension Extension) : EmptyResult; +public record InstallResult(Extension Extension); Apply / Chat Suggestion importance[1-10]: 2 __ Why: The suggestion assumes EmptyResult means no properties are allowed, but this may not be accurate. Removing the inheritance could break expected functionality without understanding the base class purpose.	Low
Update

[nvborisenko]

Test fails on CI, because I don't know how to prepare test data in bazel test environment. It passes locally in IDE and dotnet test.

[cgoldberg]

[IgnoreBrowser(Selenium.Browser.Chrome, "Web extensions are not supported yet?")]
[IgnoreBrowser(Selenium.Browser.Edge, "Web extensions are not supported yet?")]

They should work for Chrome/Edge if you start the browser using the flags:

--remote-debugging-pipe
--enable-unsafe-extension-debugging

The Python bindings added a property on Chromium's Options class named enable_webextensions that a user can enable to set these flags.

see #15794

[nvborisenko]

Test fails on CI, because I don't know how to prepare test data in bazel test environment. It passes locally in IDE and dotnet test.

I managed it and now we are able to execute tests in different environments (dotnet test, bazel test, IDE).

[nvborisenko]

--remote-debugging-pipe argument breaks CDP.

#15749 (comment)

[nvborisenko]

Parking it until better weather.

[nvborisenko]

Here we should refactor tests projects. Any test Fixture should be capable to override the initialization of WebDriver. That's it. Probably relates to #15536