fix(#192): self links not serialized without a related link
#225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix a regression introduced by 3d776ef and covered in issue #192
The original commit was meant to ignore relationshipLinks that return
nullbut the commit did not take into account the fact that relationshipLinks can include aselfand/orrelatedlink. As a result, if there was aselflink but norelatedlink the original commit would not display the relationshipLinks.This PR fixes this by modifying the
getLinksmethod to not return keys which evaluate to null (switch from map to reduce). Null relationship links will not be returned as intended by the original commit but if a non-null relationship link exists it will still be displayed (i.e., you can haveselflinks again). The PR also adds additional test coverage to cover all permutations ofselfandrelatedlinks being null.Please consider merging this PR into master to fix a fairly large regression introduced in 3.6.1.
Thank you!