Skip to content

Fixed recursion issue by resetting game without restarting the function #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Navaneeth832
Copy link

Previously, the game had two issues:

Unnecessary recursion: When a player chose to play again (y option), play_game() was called recursively instead of properly resetting the game, leading to function call stacking and potential memory issues.
Game continuing after pressing 'n' twice: If a player pressed 'n' once, the game sometimes did not exit immediately and continued running.
Attempts not resetting: The number of attempts was not resetting properly when the game restarted.
Changes made:

Replaced play_game() call with start(), ensuring a fresh reset without unnecessary recursion.
Fixed the issue where pressing 'n' twice caused the game to continue unexpectedly.
Ensured that the number of attempts resets correctly when starting a new round.
Impact:

The game now properly resets when a player chooses to play again.
The game exits immediately when 'n' is pressed.
The number of attempts resets correctly for each new game session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant