Skip to content

Commit 37efe4d

Browse files
committed
Bug 1428535 - Add missing override specifiers to overridden virtual functions. r=froydnj
MozReview-Commit-ID: DCPTnyBooIe --HG-- extra : rebase_source : cfec2d96faeb11656d86d760a34e0a04cacddb13 extra : intermediate-source : 6176724d63788b0fe8caa3f91607c2d93dbaa7ec extra : source : eebbb0600447f9b64aae3bcd47b4be66c02a51ea
1 parent 757cf79 commit 37efe4d

File tree

433 files changed

+3820
-3697
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

433 files changed

+3820
-3697
lines changed

accessible/base/nsAccessibilityService.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,7 @@ class PluginTimerCallBack final : public nsITimerCallback
482482

483483
NS_DECL_ISUPPORTS
484484

485-
NS_IMETHOD Notify(nsITimer* aTimer) final
485+
NS_IMETHOD Notify(nsITimer* aTimer) final override
486486
{
487487
if (!mContent->IsInUncomposedDoc())
488488
return NS_OK;
@@ -506,7 +506,7 @@ class PluginTimerCallBack final : public nsITimerCallback
506506
return NS_OK;
507507
}
508508

509-
NS_IMETHOD GetName(nsACString& aName) final
509+
NS_IMETHOD GetName(nsACString& aName) final override
510510
{
511511
aName.AssignLiteral("PluginTimerCallBack");
512512
return NS_OK;

build/clang-plugin/tests/TestNeedsNoVTableType.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ struct E {
3636
virtual void e();
3737
};
3838
struct F : E {
39-
virtual void e() final;
39+
virtual void e() final override;
4040
};
4141
struct G {
4242
virtual void e() = 0;

caps/BasePrincipal.h

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -60,15 +60,15 @@ class BasePrincipal : public nsJSPrincipals
6060
enum DocumentDomainConsideration { DontConsiderDocumentDomain, ConsiderDocumentDomain};
6161
bool Subsumes(nsIPrincipal* aOther, DocumentDomainConsideration aConsideration);
6262

63-
NS_IMETHOD GetOrigin(nsACString& aOrigin) final;
64-
NS_IMETHOD GetOriginNoSuffix(nsACString& aOrigin) final;
65-
NS_IMETHOD Equals(nsIPrincipal* other, bool* _retval) final;
66-
NS_IMETHOD EqualsConsideringDomain(nsIPrincipal* other, bool* _retval) final;
67-
NS_IMETHOD Subsumes(nsIPrincipal* other, bool* _retval) final;
68-
NS_IMETHOD SubsumesConsideringDomain(nsIPrincipal* other, bool* _retval) final;
69-
NS_IMETHOD SubsumesConsideringDomainIgnoringFPD(nsIPrincipal* other, bool* _retval) final;
70-
NS_IMETHOD CheckMayLoad(nsIURI* uri, bool report, bool allowIfInheritsPrincipal) final;
71-
NS_IMETHOD GetAddonPolicy(nsISupports** aResult) final;
63+
NS_IMETHOD GetOrigin(nsACString& aOrigin) final override;
64+
NS_IMETHOD GetOriginNoSuffix(nsACString& aOrigin) final override;
65+
NS_IMETHOD Equals(nsIPrincipal* other, bool* _retval) final override;
66+
NS_IMETHOD EqualsConsideringDomain(nsIPrincipal* other, bool* _retval) final override;
67+
NS_IMETHOD Subsumes(nsIPrincipal* other, bool* _retval) final override;
68+
NS_IMETHOD SubsumesConsideringDomain(nsIPrincipal* other, bool* _retval) final override;
69+
NS_IMETHOD SubsumesConsideringDomainIgnoringFPD(nsIPrincipal* other, bool* _retval) final override;
70+
NS_IMETHOD CheckMayLoad(nsIURI* uri, bool report, bool allowIfInheritsPrincipal) final override;
71+
NS_IMETHOD GetAddonPolicy(nsISupports** aResult) final override;
7272
NS_IMETHOD GetCsp(nsIContentSecurityPolicy** aCsp) override;
7373
NS_IMETHOD SetCsp(nsIContentSecurityPolicy* aCsp) override;
7474
NS_IMETHOD EnsureCSP(nsIDOMDocument* aDocument, nsIContentSecurityPolicy** aCSP) override;
@@ -79,12 +79,12 @@ class BasePrincipal : public nsJSPrincipals
7979
NS_IMETHOD GetIsCodebasePrincipal(bool* aResult) override;
8080
NS_IMETHOD GetIsExpandedPrincipal(bool* aResult) override;
8181
NS_IMETHOD GetIsSystemPrincipal(bool* aResult) override;
82-
NS_IMETHOD GetOriginAttributes(JSContext* aCx, JS::MutableHandle<JS::Value> aVal) final;
83-
NS_IMETHOD GetOriginSuffix(nsACString& aOriginSuffix) final;
84-
NS_IMETHOD GetAppId(uint32_t* aAppId) final;
85-
NS_IMETHOD GetIsInIsolatedMozBrowserElement(bool* aIsInIsolatedMozBrowserElement) final;
86-
NS_IMETHOD GetUserContextId(uint32_t* aUserContextId) final;
87-
NS_IMETHOD GetPrivateBrowsingId(uint32_t* aPrivateBrowsingId) final;
82+
NS_IMETHOD GetOriginAttributes(JSContext* aCx, JS::MutableHandle<JS::Value> aVal) final override;
83+
NS_IMETHOD GetOriginSuffix(nsACString& aOriginSuffix) final override;
84+
NS_IMETHOD GetAppId(uint32_t* aAppId) final override;
85+
NS_IMETHOD GetIsInIsolatedMozBrowserElement(bool* aIsInIsolatedMozBrowserElement) final override;
86+
NS_IMETHOD GetUserContextId(uint32_t* aUserContextId) final override;
87+
NS_IMETHOD GetPrivateBrowsingId(uint32_t* aPrivateBrowsingId) final override;
8888

8989
virtual bool AddonHasPermission(const nsAtom* aPerm);
9090

@@ -102,7 +102,7 @@ class BasePrincipal : public nsJSPrincipals
102102
static already_AddRefed<BasePrincipal>
103103
CreateCodebasePrincipal(nsIURI* aURI, const OriginAttributes& aAttrs);
104104

105-
const OriginAttributes& OriginAttributesRef() final { return mOriginAttributes; }
105+
const OriginAttributes& OriginAttributesRef() final override { return mOriginAttributes; }
106106
uint32_t AppId() const { return mOriginAttributes.mAppId; }
107107
extensions::WebExtensionPolicy* AddonPolicy();
108108
uint32_t UserContextId() const { return mOriginAttributes.mUserContextId; }

caps/nsJSPrincipals.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class nsJSPrincipals : public nsIPrincipal, public JSPrincipals
2525
uint32_t aTag,
2626
JSPrincipals** aOutPrincipals);
2727

28-
bool write(JSContext* aCx, JSStructuredCloneWriter* aWriter) final;
28+
bool write(JSContext* aCx, JSStructuredCloneWriter* aWriter) final override;
2929

3030
/*
3131
* Get a weak reference to nsIPrincipal associated with the given JS

devtools/shared/heapsnapshot/DeserializedNode.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,13 +252,13 @@ class Concrete<DeserializedNode> : public Base
252252
new (storage) Concrete(ptr);
253253
}
254254

255-
CoarseType coarseType() const final { return get().coarseType; }
255+
CoarseType coarseType() const final override { return get().coarseType; }
256256
Id identifier() const override { return get().id; }
257257
bool isLive() const override { return false; }
258258
const char16_t* typeName() const override;
259259
Node::Size size(mozilla::MallocSizeOf mallocSizeof) const override;
260260
const char* jsObjectClassName() const override { return get().jsObjectClassName; }
261-
const char* scriptFilename() const final { return get().scriptFilename; }
261+
const char* scriptFilename() const final override { return get().scriptFilename; }
262262

263263
bool hasAllocationStack() const override { return get().allocationStack.isSome(); }
264264
StackFrame allocationStack() const override;

devtools/shared/heapsnapshot/HeapSnapshot.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1255,7 +1255,7 @@ class MOZ_STACK_CLASS StreamWriter : public CoreDumpWriter
12551255

12561256
~StreamWriter() override { }
12571257

1258-
virtual bool writeMetadata(uint64_t timestamp) final {
1258+
virtual bool writeMetadata(uint64_t timestamp) final override {
12591259
protobuf::Metadata metadata;
12601260
metadata.set_timestamp(timestamp);
12611261
return writeMessage(metadata);

docshell/base/nsDocShellEnumerator.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ class nsDocShellForwardsEnumerator : public nsDocShellEnumerator
8888

8989
protected:
9090
virtual nsresult BuildArrayRecursive(nsIDocShellTreeItem* aItem,
91-
nsTArray<nsWeakPtr>& aItemArray);
91+
nsTArray<nsWeakPtr>& aItemArray) override;
9292
};
9393

9494
class nsDocShellBackwardsEnumerator : public nsDocShellEnumerator
@@ -101,7 +101,7 @@ class nsDocShellBackwardsEnumerator : public nsDocShellEnumerator
101101

102102
protected:
103103
virtual nsresult BuildArrayRecursive(nsIDocShellTreeItem* aItem,
104-
nsTArray<nsWeakPtr>& aItemArray);
104+
nsTArray<nsWeakPtr>& aItemArray) override;
105105
};
106106

107107
#endif // nsDocShellEnumerator_h___

docshell/shistory/nsSHistory.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class nsSHistory final : public mozilla::LinkedListElement<nsSHistory>,
4848
}
4949

5050
protected:
51-
virtual void NotifyExpired(nsSHEntryShared* aObj)
51+
virtual void NotifyExpired(nsSHEntryShared* aObj) override
5252
{
5353
RemoveObject(aObj);
5454
mSHistory->EvictExpiredContentViewerForEntry(aObj);

dom/base/FragmentOrElement.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -243,8 +243,8 @@ class FragmentOrElement : public nsIContent
243243
nsExtendedDOMSlots();
244244
~nsExtendedDOMSlots() final;
245245

246-
void Traverse(nsCycleCollectionTraversalCallback&) final;
247-
void Unlink() final;
246+
void Traverse(nsCycleCollectionTraversalCallback&) final override;
247+
void Unlink() final override;
248248

249249
/**
250250
* SMIL Overridde style rules (for SMIL animation of CSS properties)
@@ -295,8 +295,8 @@ class FragmentOrElement : public nsIContent
295295
nsDOMSlots();
296296
~nsDOMSlots() final;
297297

298-
void Traverse(nsCycleCollectionTraversalCallback&) final;
299-
void Unlink() final;
298+
void Traverse(nsCycleCollectionTraversalCallback&) final override;
299+
void Unlink() final override;
300300

301301
size_t SizeOfIncludingThis(mozilla::MallocSizeOf aMallocSizeOf) const;
302302

@@ -340,7 +340,7 @@ class FragmentOrElement : public nsIContent
340340
return new nsDOMSlots();
341341
}
342342

343-
nsIContent::nsExtendedContentSlots* CreateExtendedSlots() final
343+
nsIContent::nsExtendedContentSlots* CreateExtendedSlots() final override
344344
{
345345
return new nsExtendedDOMSlots();
346346
}

dom/base/ShadowRoot.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,4 +185,3 @@ class ShadowRoot final : public DocumentFragment,
185185
} // namespace mozilla
186186

187187
#endif // mozilla_dom_shadowroot_h__
188-

dom/base/nsContentPermissionHelper.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -143,10 +143,10 @@ class ContentPermissionRequestParent : public PContentPermissionRequestParent
143143
nsTArray<PermissionRequest> mRequests;
144144

145145
private:
146-
virtual mozilla::ipc::IPCResult Recvprompt();
147-
virtual mozilla::ipc::IPCResult RecvNotifyVisibility(const bool& aIsVisible);
148-
virtual mozilla::ipc::IPCResult RecvDestroy();
149-
virtual void ActorDestroy(ActorDestroyReason why);
146+
virtual mozilla::ipc::IPCResult Recvprompt() override;
147+
virtual mozilla::ipc::IPCResult RecvNotifyVisibility(const bool& aIsVisible) override;
148+
virtual mozilla::ipc::IPCResult RecvDestroy() override;
149+
virtual void ActorDestroy(ActorDestroyReason why) override;
150150
};
151151

152152
ContentPermissionRequestParent::ContentPermissionRequestParent(const nsTArray<PermissionRequest>& aRequests,

dom/base/nsDocument.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11980,7 +11980,7 @@ class PointerLockRequest final : public Runnable
1198011980
, mUserInputOrChromeCaller(aUserInputOrChromeCaller)
1198111981
{}
1198211982

11983-
NS_IMETHOD Run() final;
11983+
NS_IMETHOD Run() final override;
1198411984

1198511985
private:
1198611986
nsWeakPtr mElement;

dom/base/nsDocument.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ class nsDocument : public nsIDocument,
423423
already_AddRefed<nsIPresShell> CreateShell(nsPresContext* aContext,
424424
nsViewManager* aViewManager,
425425
mozilla::StyleSetHandle aStyleSet)
426-
final;
426+
final override;
427427
virtual void DeleteShell() override;
428428

429429
virtual bool GetAllowPlugins() override;

dom/base/nsDocumentEncoder.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1254,14 +1254,14 @@ class nsHTMLCopyEncoder : public nsDocumentEncoder
12541254
nsHTMLCopyEncoder();
12551255
virtual ~nsHTMLCopyEncoder();
12561256

1257-
NS_IMETHOD Init(nsIDOMDocument* aDocument, const nsAString& aMimeType, uint32_t aFlags);
1257+
NS_IMETHOD Init(nsIDOMDocument* aDocument, const nsAString& aMimeType, uint32_t aFlags) override;
12581258

12591259
// overridden methods from nsDocumentEncoder
1260-
NS_IMETHOD SetSelection(nsISelection* aSelection);
1260+
NS_IMETHOD SetSelection(nsISelection* aSelection) override;
12611261
NS_IMETHOD EncodeToStringWithContext(nsAString& aContextString,
12621262
nsAString& aInfoString,
1263-
nsAString& aEncodedString);
1264-
NS_IMETHOD EncodeToString(nsAString& aOutputString);
1263+
nsAString& aEncodedString) override;
1264+
NS_IMETHOD EncodeToString(nsAString& aOutputString) override;
12651265

12661266
protected:
12671267

@@ -1284,9 +1284,9 @@ class nsHTMLCopyEncoder : public nsDocumentEncoder
12841284
bool IsFirstNode(nsIDOMNode *aNode);
12851285
bool IsLastNode(nsIDOMNode *aNode);
12861286
bool IsEmptyTextContent(nsIDOMNode* aNode);
1287-
virtual bool IncludeInContext(nsINode *aNode);
1287+
virtual bool IncludeInContext(nsINode *aNode) override;
12881288
virtual int32_t
1289-
GetImmediateContextCount(const nsTArray<nsINode*>& aAncestorArray);
1289+
GetImmediateContextCount(const nsTArray<nsINode*>& aAncestorArray) override;
12901290

12911291
bool mIsTextWidget;
12921292
};

dom/base/nsFrameMessageManager.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ class nsFrameMessageManager final : public nsIContentFrameMessageManager,
312312
313313
class MyAsyncMessage : public nsSameProcessAsyncMessageBase, public Runnable
314314
{
315-
NS_IMETHOD Run() override {
315+
NS_IMETHOD Run() {
316316
ReceiveMessage(..., ...);
317317
return NS_OK;
318318
}

dom/base/nsGenericDOMDataNode.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ class nsGenericDOMDataNode : public nsIContent
145145
virtual nsresult AppendText(const char16_t* aBuffer, uint32_t aLength,
146146
bool aNotify) override;
147147
virtual bool TextIsOnlyWhitespace() override;
148-
virtual bool ThreadSafeTextIsOnlyWhitespace() const final;
148+
virtual bool ThreadSafeTextIsOnlyWhitespace() const final override;
149149
virtual bool HasTextForTranslation() override;
150150
virtual void AppendTextTo(nsAString& aResult) override;
151151
MOZ_MUST_USE

dom/base/nsGlobalWindowCommands.cpp

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ class nsSelectMoveScrollCommand : public nsSelectionCommandsBase
137137
{
138138
public:
139139

140-
NS_IMETHOD DoCommand(const char * aCommandName, nsISupports *aCommandContext);
140+
NS_IMETHOD DoCommand(const char * aCommandName, nsISupports *aCommandContext) override;
141141

142142
// no member variables, please, we're stateless!
143143
};
@@ -147,7 +147,7 @@ class nsPhysicalSelectMoveScrollCommand : public nsSelectionCommandsBase
147147
{
148148
public:
149149

150-
NS_IMETHOD DoCommand(const char * aCommandName, nsISupports *aCommandContext);
150+
NS_IMETHOD DoCommand(const char * aCommandName, nsISupports *aCommandContext) override;
151151

152152
// no member variables, please, we're stateless!
153153
};
@@ -157,7 +157,7 @@ class nsSelectCommand : public nsSelectionCommandsBase
157157
{
158158
public:
159159

160-
NS_IMETHOD DoCommand(const char * aCommandName, nsISupports *aCommandContext);
160+
NS_IMETHOD DoCommand(const char * aCommandName, nsISupports *aCommandContext) override;
161161

162162
// no member variables, please, we're stateless!
163163
};
@@ -167,7 +167,7 @@ class nsPhysicalSelectCommand : public nsSelectionCommandsBase
167167
{
168168
public:
169169

170-
NS_IMETHOD DoCommand(const char * aCommandName, nsISupports *aCommandContext);
170+
NS_IMETHOD DoCommand(const char * aCommandName, nsISupports *aCommandContext) override;
171171

172172
// no member variables, please, we're stateless!
173173
};
@@ -697,9 +697,11 @@ class _cmd : public nsSelectionCommand
697697
protected: \
698698
\
699699
virtual nsresult IsClipboardCommandEnabled(const char* aCommandName, \
700-
nsIContentViewerEdit* aEdit, bool *outCmdEnabled); \
700+
nsIContentViewerEdit* aEdit, \
701+
bool *outCmdEnabled) override; \
701702
virtual nsresult DoClipboardCommand(const char* aCommandName, \
702-
nsIContentViewerEdit* aEdit, nsICommandParams* aParams); \
703+
nsIContentViewerEdit* aEdit, \
704+
nsICommandParams* aParams) override; \
703705
/* no member variables, please, we're stateless! */ \
704706
};
705707

dom/base/nsWrapperCache.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,30 +67,30 @@ class DebugWrapperTraversalCallback : public nsCycleCollectionTraversalCallback
6767
}
6868

6969
NS_IMETHOD_(void) DescribeRefCountedNode(nsrefcnt aRefCount,
70-
const char* aObjName)
70+
const char* aObjName) override
7171
{
7272
}
7373
NS_IMETHOD_(void) DescribeGCedNode(bool aIsMarked,
7474
const char* aObjName,
75-
uint64_t aCompartmentAddress)
75+
uint64_t aCompartmentAddress) override
7676
{
7777
}
7878

79-
NS_IMETHOD_(void) NoteJSChild(const JS::GCCellPtr& aChild)
79+
NS_IMETHOD_(void) NoteJSChild(const JS::GCCellPtr& aChild) override
8080
{
8181
if (aChild == mWrapper) {
8282
mFound = true;
8383
}
8484
}
85-
NS_IMETHOD_(void) NoteXPCOMChild(nsISupports* aChild)
85+
NS_IMETHOD_(void) NoteXPCOMChild(nsISupports* aChild) override
8686
{
8787
}
8888
NS_IMETHOD_(void) NoteNativeChild(void* aChild,
89-
nsCycleCollectionParticipant* aHelper)
89+
nsCycleCollectionParticipant* aHelper) override
9090
{
9191
}
9292

93-
NS_IMETHOD_(void) NoteNextEdgeName(const char* aName)
93+
NS_IMETHOD_(void) NoteNextEdgeName(const char* aName) override
9494
{
9595
}
9696

dom/bindings/IterableIterator.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ class IterableIterator final : public IterableIteratorBase
177177

178178
// Since we're templated on a binding, we need to possibly CC it, but can't do
179179
// that through macros. So it happens here.
180-
virtual void UnlinkHelper() final
180+
virtual void UnlinkHelper() final override
181181
{
182182
mIterableObj = nullptr;
183183
}

dom/canvas/CanvasImageCache.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ class ImageCache final : public nsExpirationTracker<ImageCacheEntryData,4>
166166
ImageCache();
167167
~ImageCache();
168168

169-
virtual void NotifyExpired(ImageCacheEntryData* aObject)
169+
virtual void NotifyExpired(ImageCacheEntryData* aObject) override
170170
{
171171
mTotal -= aObject->SizeInBytes();
172172
RemoveObject(aObject);

dom/canvas/CanvasRenderingContext2D.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4277,7 +4277,7 @@ struct MOZ_STACK_CLASS CanvasBidiProcessor : public nsBidiPresUtils::BidiProcess
42774277

42784278
typedef CanvasRenderingContext2D::ContextState ContextState;
42794279

4280-
virtual void SetText(const char16_t* aText, int32_t aLength, nsBidiDirection aDirection)
4280+
virtual void SetText(const char16_t* aText, int32_t aLength, nsBidiDirection aDirection) override
42814281
{
42824282
mFontgrp->UpdateUserFonts(); // ensure user font generation is current
42834283
// adjust flags for current direction run
@@ -4296,7 +4296,7 @@ struct MOZ_STACK_CLASS CanvasBidiProcessor : public nsBidiPresUtils::BidiProcess
42964296
mMissingFonts);
42974297
}
42984298

4299-
virtual nscoord GetWidth()
4299+
virtual nscoord GetWidth() override
43004300
{
43014301
gfxTextRun::Metrics textRunMetrics = mTextRun->MeasureText(
43024302
mDoMeasureBoundingBox ? gfxFont::TIGHT_INK_EXTENTS
@@ -4369,7 +4369,7 @@ struct MOZ_STACK_CLASS CanvasBidiProcessor : public nsBidiPresUtils::BidiProcess
43694369
return pattern.forget();
43704370
}
43714371

4372-
virtual void DrawText(nscoord aXOffset, nscoord aWidth)
4372+
virtual void DrawText(nscoord aXOffset, nscoord aWidth) override
43734373
{
43744374
gfx::Point point = mPt;
43754375
bool rtl = mTextRun->IsRightToLeft();

dom/canvas/CanvasRenderingContextHelper.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ CanvasRenderingContextHelper::ToBlob(JSContext* aCx,
3737
, mBlobCallback(aCallback) {}
3838

3939
// This is called on main thread.
40-
nsresult ReceiveBlob(already_AddRefed<Blob> aBlob)
40+
nsresult ReceiveBlob(already_AddRefed<Blob> aBlob) override
4141
{
4242
RefPtr<Blob> blob = aBlob;
4343

0 commit comments

Comments
 (0)