Bug 1457411 - Update netwerk module to make use of newer methods introduced with c++11 and c++14. r=valentin

MozReview-Commit-ID: 666LNaHyiuQ

--HG--
extra : rebase_source : f3a24e0342d8dcdf9020dd473bc6b1045cbc533b

Author: abpostelnicu

netwerk/base/ARefBase.h

@@ -19,8 +19,8 @@ namespace mozilla { namespace net {
 class ARefBase
 {
 public:
-  ARefBase() {}
-  virtual ~ARefBase() {}
+  ARefBase() = default;
+  virtual ~ARefBase() = default;
 
   NS_INLINE_DECL_PURE_VIRTUAL_REFCOUNTING
 };

netwerk/base/ArrayBufferInputStream.h

@@ -30,7 +30,7 @@ class ArrayBufferInputStream : public nsIArrayBufferInputStream {
   NS_DECL_NSIINPUTSTREAM
 
 private:
-  virtual ~ArrayBufferInputStream() {}
+  virtual ~ArrayBufferInputStream() = default;
   mozilla::UniquePtr<char[]> mArrayBuffer;
   uint32_t mBufferLength;
   uint32_t mPos;

netwerk/base/BackgroundFileSaver.cpp

@@ -918,10 +918,6 @@ BackgroundFileSaverOutputStream::BackgroundFileSaverOutputStream()
 {
 }
 
-BackgroundFileSaverOutputStream::~BackgroundFileSaverOutputStream()
-{
-}
-
 bool
 BackgroundFileSaverOutputStream::HasInfiniteBuffer()
 {
@@ -1023,10 +1019,6 @@ BackgroundFileSaverStreamListener::BackgroundFileSaverStreamListener()
 {
 }
 
-BackgroundFileSaverStreamListener::~BackgroundFileSaverStreamListener()
-{
-}
-
 bool
 BackgroundFileSaverStreamListener::HasInfiniteBuffer()
 {

netwerk/base/BackgroundFileSaver.h

@@ -312,7 +312,7 @@ class BackgroundFileSaverOutputStream : public BackgroundFileSaver
   virtual nsAsyncCopyProgressFun GetProgressCallback() override;
 
 private:
-  ~BackgroundFileSaverOutputStream();
+  ~BackgroundFileSaverOutputStream() = default;
 
   /**
    * Original callback provided to our AsyncWait wrapper.
@@ -339,7 +339,7 @@ class BackgroundFileSaverStreamListener final : public BackgroundFileSaver
   virtual nsAsyncCopyProgressFun GetProgressCallback() override;
 
 private:
-  ~BackgroundFileSaverStreamListener();
+  ~BackgroundFileSaverStreamListener() = default;
 
   /**
    * Protects the state related to whether the request should be suspended.
@@ -385,15 +385,15 @@ class DigestOutputStream : public nsIOutputStream
   DigestOutputStream(nsIOutputStream* outputStream, PK11Context* aContext);
 
 private:
-  virtual ~DigestOutputStream() {}
+  virtual ~DigestOutputStream() = default;
 
   // Calls to write are passed to this stream.
   nsCOMPtr<nsIOutputStream> mOutputStream;
   // Digest context used to compute the hash, owned by the caller.
   PK11Context* mDigestContext;
 
   // Don't accidentally copy construct.
-  DigestOutputStream(const DigestOutputStream& d);
+  DigestOutputStream(const DigestOutputStream& d) = delete;
 };
 
 } // namespace net

netwerk/base/ChannelDiverterChild.cpp

@@ -15,13 +15,5 @@
 namespace mozilla {
 namespace net {
 
-ChannelDiverterChild::ChannelDiverterChild()
-{
-}
-
-ChannelDiverterChild::~ChannelDiverterChild()
-{
-}
-
 } // namespace net
 } // namespace mozilla

netwerk/base/ChannelDiverterChild.h

@@ -16,8 +16,8 @@ class ChannelDiverterChild :
   public PChannelDiverterChild
 {
 public:
-  ChannelDiverterChild();
-  virtual ~ChannelDiverterChild();
+  ChannelDiverterChild() = default;
+  virtual ~ChannelDiverterChild() = default;
 };
 
 } // namespace net

netwerk/base/ChannelDiverterParent.cpp

@@ -15,14 +15,6 @@
 namespace mozilla {
 namespace net {
 
-ChannelDiverterParent::ChannelDiverterParent()
-{
-}
-
-ChannelDiverterParent::~ChannelDiverterParent()
-{
-}
-
 bool
 ChannelDiverterParent::Init(const ChannelDiverterArgs& aArgs)
 {

netwerk/base/ChannelDiverterParent.h

@@ -21,8 +21,8 @@ class ChannelDiverterParent :
   public PChannelDiverterParent
 {
 public:
-  ChannelDiverterParent();
-  virtual ~ChannelDiverterParent();
+  ChannelDiverterParent() = default;
+  virtual ~ChannelDiverterParent() = default;
 
   bool Init(const ChannelDiverterArgs& aArgs);
 

netwerk/base/Dashboard.cpp

@@ -50,9 +50,7 @@ class SocketData
     nsIEventTarget *mEventTarget;
 
 private:
-    virtual ~SocketData()
-    {
-    }
+    virtual ~SocketData() = default;
 };
 
 static void GetErrorString(nsresult rv, nsAString& errorString);
@@ -63,9 +61,7 @@ NS_IMPL_ISUPPORTS0(SocketData)
 class HttpData
     : public nsISupports
 {
-    virtual ~HttpData()
-    {
-    }
+    virtual ~HttpData() = default;
 
 public:
     NS_DECL_THREADSAFE_ISUPPORTS
@@ -86,9 +82,7 @@ NS_IMPL_ISUPPORTS0(HttpData)
 class WebSocketRequest
     : public nsISupports
 {
-    virtual ~WebSocketRequest()
-    {
-    }
+    virtual ~WebSocketRequest() = default;
 
 public:
     NS_DECL_THREADSAFE_ISUPPORTS
@@ -108,9 +102,7 @@ NS_IMPL_ISUPPORTS0(WebSocketRequest)
 class DnsData
     : public nsISupports
 {
-    virtual ~DnsData()
-    {
-    }
+    virtual ~DnsData() = default;
 
 public:
     NS_DECL_THREADSAFE_ISUPPORTS
@@ -182,9 +174,7 @@ NS_IMPL_ISUPPORTS(ConnectionData, nsITransportEventSink, nsITimerCallback, nsINa
 class RcwnData
     : public nsISupports
 {
-    virtual ~RcwnData()
-    {
-    }
+    virtual ~RcwnData() = default;
 
 public:
     NS_DECL_THREADSAFE_ISUPPORTS
@@ -265,9 +255,7 @@ class LookupHelper;
 class LookupArgument
     : public nsISupports
 {
-    virtual ~LookupArgument()
-    {
-    }
+    virtual ~LookupArgument() = default;
 
 public:
     NS_DECL_THREADSAFE_ISUPPORTS
@@ -299,8 +287,7 @@ class LookupHelper final
     NS_DECL_THREADSAFE_ISUPPORTS
     NS_DECL_NSIDNSLISTENER
 
-    LookupHelper() {
-    }
+    LookupHelper() = default;
 
     nsresult ConstructAnswer(LookupArgument *aArgument);
 public:
@@ -377,10 +364,6 @@ Dashboard::Dashboard()
     mEnableLogging = false;
 }
 
-Dashboard::~Dashboard()
-{
-}
-
 NS_IMETHODIMP
 Dashboard::RequestSockets(NetDashboardCallback *aCallback)
 {
@@ -1021,9 +1004,9 @@ ErrorEntry socketTransportStatuses[] = {
 static void
 GetErrorString(nsresult rv, nsAString& errorString)
 {
-    for (size_t i = 0; i < ArrayLength(socketTransportStatuses); ++i) {
-        if (socketTransportStatuses[i].key == rv) {
-            errorString.AssignASCII(socketTransportStatuses[i].error);
+    for (auto& socketTransportStatus : socketTransportStatuses) {
+        if (socketTransportStatus.key == rv) {
+            errorString.AssignASCII(socketTransportStatus.error);
             return;
         }
     }

netwerk/base/Dashboard.h

@@ -84,7 +84,7 @@ class Dashboard final
     WebSocketData mWs;
 
 private:
-    virtual ~Dashboard();
+    virtual ~Dashboard() = default;
 
     nsresult GetSocketsDispatch(SocketData *);
     nsresult GetHttpDispatch(HttpData *);