Backed out 6 changesets (bug 1809752, bug 1809753) for causing perma failures in browser/components/firefoxview/tests/browser/browser_feature_callout_position.js

Backed out changeset ea05784d74c4 (bug 1809753)
Backed out changeset 7c9b20eebcc8 (bug 1809753)
Backed out changeset d0267ac2256d (bug 1809753)
Backed out changeset aa9f2971bd6f (bug 1809753)
Backed out changeset f0d9fcfaa6f8 (bug 1809752)
Backed out changeset 6d58c799cffe (bug 1809752)

Author: Sandor Molnar

dom/base/CCGCScheduler.cpp

@@ -683,7 +683,7 @@ void CCGCScheduler::EnsureCCRunner(TimeDuration aDelay, TimeDuration aBudget) {
         minimumBudget, true, [this] { return mDidShutdown; });
   } else {
     mCCRunner->SetMinimumUsefulBudget(minimumBudget.ToMilliseconds());
-    nsIEventTarget* target = mozilla::GetCurrentSerialEventTarget();
+    nsIEventTarget* target = mozilla::GetCurrentEventTarget();
     if (target) {
       mCCRunner->SetTimer(aDelay, target);
     }

dom/base/ImageEncoder.cpp

@@ -52,7 +52,7 @@ class SurfaceHelper : public Runnable {
   }
 
   already_AddRefed<gfx::DataSourceSurface> GetDataSurfaceSafe() {
-    nsCOMPtr<nsIEventTarget> mainTarget = GetMainThreadSerialEventTarget();
+    nsCOMPtr<nsIEventTarget> mainTarget = GetMainThreadEventTarget();
     MOZ_ASSERT(mainTarget);
     SyncRunnable::DispatchToThread(mainTarget, this, false);
 
@@ -88,9 +88,9 @@ class EncodingCompleteEvent final : public DiscardableRunnable {
         mEncodeCompleteCallback(aEncodeCompleteCallback),
         mFailed(false) {
     if (!NS_IsMainThread() && IsCurrentThreadRunningWorker()) {
-      mCreationEventTarget = GetCurrentSerialEventTarget();
+      mCreationEventTarget = GetCurrentEventTarget();
     } else {
-      mCreationEventTarget = GetMainThreadSerialEventTarget();
+      mCreationEventTarget = GetMainThreadEventTarget();
     }
   }
 

dom/base/InProcessBrowserChildMessageManager.cpp

@@ -183,7 +183,7 @@ Nullable<WindowProxyHolder> InProcessBrowserChildMessageManager::GetContent(
 
 already_AddRefed<nsIEventTarget>
 InProcessBrowserChildMessageManager::GetTabEventTarget() {
-  nsCOMPtr<nsIEventTarget> target = GetMainThreadSerialEventTarget();
+  nsCOMPtr<nsIEventTarget> target = GetMainThreadEventTarget();
   return target.forget();
 }
 

dom/base/StructuredCloneHolder.cpp

@@ -341,7 +341,7 @@ StructuredCloneHolder::StructuredCloneHolder(
       mGlobal(nullptr)
 #ifdef DEBUG
       ,
-      mCreationEventTarget(GetCurrentSerialEventTarget())
+      mCreationEventTarget(GetCurrentEventTarget())
 #endif
 {
 }

dom/base/nsJSEnvironment.cpp

@@ -1977,7 +1977,7 @@ static bool DispatchToEventLoop(void* closure,
   // simply NS_DispatchToMainThread. Failure during shutdown is expected and
   // properly handled by the JS engine.
 
-  nsCOMPtr<nsIEventTarget> mainTarget = GetMainThreadSerialEventTarget();
+  nsCOMPtr<nsIEventTarget> mainTarget = GetMainThreadEventTarget();
   if (!mainTarget) {
     return false;
   }

dom/cache/Context.cpp

@@ -475,7 +475,7 @@ class Context::ActionRunnable final : public nsIRunnable,
         mTarget(aTarget),
         mAction(std::move(aAction)),
         mDirectoryMetadata(aDirectoryMetadata),
-        mInitiatingThread(GetCurrentSerialEventTarget()),
+        mInitiatingThread(GetCurrentEventTarget()),
         mState(STATE_INIT),
         mResult(NS_OK),
         mExecutingRunOnTarget(false) {

dom/cache/Manager.cpp

@@ -1959,7 +1959,8 @@ void Manager::Init(Maybe<Manager&> aOldManager) {
   // per Manager now, this lets us cleanly call Factory::Remove() once the
   // Context goes away.
   SafeRefPtr<Context> ref = Context::Create(
-      SafeRefPtrFromThis(), mIOThread, MakeSafeRefPtr<SetupAction>(),
+      SafeRefPtrFromThis(), mIOThread->SerialEventTarget(),
+      MakeSafeRefPtr<SetupAction>(),
       aOldManager ? SomeRef(*aOldManager->mContext) : Nothing());
   mContext = ref.unsafeGetRawPtr();
 }

dom/fetch/FetchService.cpp

@@ -161,13 +161,13 @@ RefPtr<FetchServicePromises> FetchService::FetchInstance::Fetch() {
 
   // Create a FetchDriver instance
   mFetchDriver = MakeRefPtr<FetchDriver>(
-      mRequest.clonePtr(),               // Fetch Request
-      mPrincipal,                        // Principal
-      mLoadGroup,                        // LoadGroup
-      GetMainThreadSerialEventTarget(),  // MainThreadEventTarget
-      mCookieJarSettings,                // CookieJarSettings
-      mPerformanceStorage,               // PerformanceStorage
-      false                              // IsTrackingFetch
+      mRequest.clonePtr(),         // Fetch Request
+      mPrincipal,                  // Principal
+      mLoadGroup,                  // LoadGroup
+      GetMainThreadEventTarget(),  // MainThreadEventTarget
+      mCookieJarSettings,          // CookieJarSettings
+      mPerformanceStorage,         // PerformanceStorage
+      false                        // IsTrackingFetch
   );
 
   // Call FetchDriver::Fetch to start fetching.

dom/file/MutableBlobStorage.cpp

@@ -288,7 +288,7 @@ MutableBlobStorage::MutableBlobStorage(MutableBlobStorageType aType,
   MOZ_ASSERT(NS_IsMainThread());
 
   if (!mEventTarget) {
-    mEventTarget = GetMainThreadSerialEventTarget();
+    mEventTarget = GetMainThreadEventTarget();
   }
 
   if (aMaxMemory == 0 && aType == eCouldBeInTemporaryFile) {

dom/file/MutableBlobStreamListener.cpp

@@ -23,7 +23,7 @@ MutableBlobStreamListener::MutableBlobStreamListener(
   MOZ_ASSERT(aCallback);
 
   if (!mEventTarget) {
-    mEventTarget = GetMainThreadSerialEventTarget();
+    mEventTarget = GetMainThreadEventTarget();
   }
 
   MOZ_ASSERT(mEventTarget);