Backed out changeset 6e00f8bd2acc (bug 1714307) for causing hazard bustage. CLOSED TREE

Author: ncsoregi

netwerk/base/ArrayBufferInputStream.cpp

@@ -17,6 +17,9 @@ using mozilla::dom::RootingCx;
 NS_IMPL_ISUPPORTS(ArrayBufferInputStream, nsIArrayBufferInputStream,
                   nsIInputStream);
 
+ArrayBufferInputStream::ArrayBufferInputStream()
+    : mBufferLength(0), mPos(0), mClosed(false) {}
+
 NS_IMETHODIMP
 ArrayBufferInputStream::SetData(JS::Handle<JS::Value> aBuffer,
                                 uint64_t aByteOffset, uint64_t aLength) {

netwerk/base/ArrayBufferInputStream.h

@@ -23,7 +23,7 @@
 
 class ArrayBufferInputStream : public nsIArrayBufferInputStream {
  public:
-  ArrayBufferInputStream() = default;
+  ArrayBufferInputStream();
 
   NS_DECL_THREADSAFE_ISUPPORTS
   NS_DECL_NSIARRAYBUFFERINPUTSTREAM
@@ -32,9 +32,9 @@ class ArrayBufferInputStream : public nsIArrayBufferInputStream {
  private:
   virtual ~ArrayBufferInputStream() = default;
   mozilla::UniquePtr<char[]> mArrayBuffer;
-  uint32_t mBufferLength{0};
-  uint32_t mPos{0};
-  bool mClosed{false};
+  uint32_t mBufferLength;
+  uint32_t mPos;
+  bool mClosed;
 };
 
 #endif  // ArrayBufferInputStream_h

netwerk/base/BackgroundFileSaver.cpp

@@ -82,7 +82,27 @@ class NotifyTargetChangeRunnable final : public Runnable {
 uint32_t BackgroundFileSaver::sThreadCount = 0;
 uint32_t BackgroundFileSaver::sTelemetryMaxThreadCount = 0;
 
-BackgroundFileSaver::BackgroundFileSaver() {
+BackgroundFileSaver::BackgroundFileSaver()
+    : mControlEventTarget(nullptr),
+      mBackgroundET(nullptr),
+      mPipeOutputStream(nullptr),
+      mPipeInputStream(nullptr),
+      mObserver(nullptr),
+      mLock("BackgroundFileSaver.mLock"),
+      mWorkerThreadAttentionRequested(false),
+      mFinishRequested(false),
+      mComplete(false),
+      mStatus(NS_OK),
+      mAppend(false),
+      mInitialTarget(nullptr),
+      mInitialTargetKeepPartial(false),
+      mRenamedTarget(nullptr),
+      mRenamedTargetKeepPartial(false),
+      mAsyncCopyContext(nullptr),
+      mSha256Enabled(false),
+      mSignatureInfoEnabled(false),
+      mActualTarget(nullptr),
+      mActualTargetKeepPartial(false) {
   LOG(("Created BackgroundFileSaver [this = %p]", this));
 }
 
@@ -911,6 +931,13 @@ BackgroundFileSaverOutputStream::OnOutputStreamReady(
 NS_IMPL_ISUPPORTS(BackgroundFileSaverStreamListener, nsIBackgroundFileSaver,
                   nsIRequestObserver, nsIStreamListener)
 
+BackgroundFileSaverStreamListener::BackgroundFileSaverStreamListener()
+    : BackgroundFileSaver(),
+      mSuspensionLock("BackgroundFileSaverStreamListener.mSuspensionLock"),
+      mReceivedTooMuchData(false),
+      mRequest(nullptr),
+      mRequestSuspended(false) {}
+
 bool BackgroundFileSaverStreamListener::HasInfiniteBuffer() { return true; }
 
 nsAsyncCopyProgressFun

netwerk/base/BackgroundFileSaver.h

@@ -117,36 +117,36 @@ class BackgroundFileSaver : public nsIBackgroundFileSaver {
    * Protects the shared state between control and worker threads.  This mutex
    * is always locked for a very short time, never during input/output.
    */
-  mozilla::Mutex mLock{"BackgroundFileSaver.mLock"};
+  mozilla::Mutex mLock;
 
   /**
    * True if the worker thread is already waiting to process a change in state.
    */
-  bool mWorkerThreadAttentionRequested{false};
+  bool mWorkerThreadAttentionRequested;
 
   /**
    * True if the operation should finish as soon as possibile.
    */
-  bool mFinishRequested{false};
+  bool mFinishRequested;
 
   /**
    * True if the operation completed, with either success or failure.
    */
-  bool mComplete{false};
+  bool mComplete;
 
   /**
    * Holds the current file saver status.  This is a success status while the
    * object is working correctly, and remains such if the operation completes
    * successfully.  This becomes an error status when an error occurs on the
    * worker thread, or when the operation is canceled.
    */
-  nsresult mStatus{NS_OK};
+  nsresult mStatus;
 
   /**
    * True if we should append data to the initial target file, instead of
    * overwriting it.
    */
-  bool mAppend{false};
+  bool mAppend;
 
   /**
    * This is set by the first SetTarget call on the control thread, and contains
@@ -161,7 +161,7 @@ class BackgroundFileSaver : public nsIBackgroundFileSaver {
    * indicates whether mInitialTarget should be kept as partially completed,
    * rather than deleted, if the operation fails or is canceled.
    */
-  bool mInitialTargetKeepPartial{false};
+  bool mInitialTargetKeepPartial;
 
   /**
    * This is set by subsequent SetTarget calls on the control thread, and
@@ -179,7 +179,7 @@ class BackgroundFileSaver : public nsIBackgroundFileSaver {
    * indicates whether mRenamedTarget should be kept as partially completed,
    * rather than deleted, if the operation fails or is canceled.
    */
-  bool mRenamedTargetKeepPartial{false};
+  bool mRenamedTargetKeepPartial;
 
   /**
    * While NS_AsyncCopy is in progress, allows canceling it.  Null otherwise.
@@ -197,7 +197,7 @@ class BackgroundFileSaver : public nsIBackgroundFileSaver {
    * Whether or not to compute the hash. Must be set on the main thread before
    * setTarget is called.
    */
-  bool mSha256Enabled{false};
+  bool mSha256Enabled;
 
   /**
    * Store the signature info.
@@ -208,7 +208,7 @@ class BackgroundFileSaver : public nsIBackgroundFileSaver {
    * Whether or not to extract the signature. Must be set on the main thread
    * before setTarget is called.
    */
-  bool mSignatureInfoEnabled{false};
+  bool mSignatureInfoEnabled;
 
   //////////////////////////////////////////////////////////////////////////////
   //// State handled exclusively by the worker thread
@@ -222,7 +222,7 @@ class BackgroundFileSaver : public nsIBackgroundFileSaver {
    * Indicates whether mActualTarget should be kept as partially completed,
    * rather than deleted, if the operation fails or is canceled.
    */
-  bool mActualTargetKeepPartial{false};
+  bool mActualTargetKeepPartial;
 
   /**
    * Used to calculate the file hash. This keeps state across file renames and
@@ -327,7 +327,7 @@ class BackgroundFileSaverStreamListener final : public BackgroundFileSaver,
   NS_DECL_NSIREQUESTOBSERVER
   NS_DECL_NSISTREAMLISTENER
 
-  BackgroundFileSaverStreamListener() = default;
+  BackgroundFileSaverStreamListener();
 
  protected:
   virtual bool HasInfiniteBuffer() override;
@@ -339,13 +339,12 @@ class BackgroundFileSaverStreamListener final : public BackgroundFileSaver,
   /**
    * Protects the state related to whether the request should be suspended.
    */
-  mozilla::Mutex mSuspensionLock{
-      "BackgroundFileSaverStreamListener.mSuspensionLock"};
+  mozilla::Mutex mSuspensionLock;
 
   /**
    * Whether we should suspend the request because we received too much data.
    */
-  bool mReceivedTooMuchData{false};
+  bool mReceivedTooMuchData;
 
   /**
    * Request for which we received too much data.  This is populated when
@@ -356,7 +355,7 @@ class BackgroundFileSaverStreamListener final : public BackgroundFileSaver,
   /**
    * Whether mRequest is currently suspended.
    */
-  bool mRequestSuspended{false};
+  bool mRequestSuspended;
 
   /**
    * Called while NS_AsyncCopy is copying data.

netwerk/base/Dashboard.cpp

@@ -38,13 +38,17 @@ class SocketData : public nsISupports {
  public:
   NS_DECL_THREADSAFE_ISUPPORTS
 
-  SocketData() = default;
+  SocketData() {
+    mTotalSent = 0;
+    mTotalRecv = 0;
+    mEventTarget = nullptr;
+  }
 
-  uint64_t mTotalSent{0};
-  uint64_t mTotalRecv{0};
+  uint64_t mTotalSent;
+  uint64_t mTotalRecv;
   nsTArray<SocketInfo> mData;
   nsMainThreadPtrHandle<nsINetDashboardCallback> mCallback;
-  nsIEventTarget* mEventTarget{nullptr};
+  nsIEventTarget* mEventTarget;
 
  private:
   virtual ~SocketData() = default;
@@ -60,11 +64,11 @@ class HttpData : public nsISupports {
  public:
   NS_DECL_THREADSAFE_ISUPPORTS
 
-  HttpData() = default;
+  HttpData() { mEventTarget = nullptr; }
 
   nsTArray<HttpRetParams> mData;
   nsMainThreadPtrHandle<nsINetDashboardCallback> mCallback;
-  nsIEventTarget* mEventTarget{nullptr};
+  nsIEventTarget* mEventTarget;
 };
 
 NS_IMPL_ISUPPORTS0(HttpData)
@@ -75,10 +79,10 @@ class WebSocketRequest : public nsISupports {
  public:
   NS_DECL_THREADSAFE_ISUPPORTS
 
-  WebSocketRequest() = default;
+  WebSocketRequest() { mEventTarget = nullptr; }
 
   nsMainThreadPtrHandle<nsINetDashboardCallback> mCallback;
-  nsIEventTarget* mEventTarget{nullptr};
+  nsIEventTarget* mEventTarget;
 };
 
 NS_IMPL_ISUPPORTS0(WebSocketRequest)
@@ -89,11 +93,11 @@ class DnsData : public nsISupports {
  public:
   NS_DECL_THREADSAFE_ISUPPORTS
 
-  DnsData() = default;
+  DnsData() { mEventTarget = nullptr; }
 
   nsTArray<DNSCacheEntries> mData;
   nsMainThreadPtrHandle<nsINetDashboardCallback> mCallback;
-  nsIEventTarget* mEventTarget{nullptr};
+  nsIEventTarget* mEventTarget;
 };
 
 NS_IMPL_ISUPPORTS0(DnsData)
@@ -120,19 +124,22 @@ class ConnectionData : public nsITransportEventSink,
   void StartTimer(uint32_t aTimeout);
   void StopTimer();
 
-  explicit ConnectionData(Dashboard* target) { mDashboard = target; }
+  explicit ConnectionData(Dashboard* target) : mPort(0), mTimeout(0) {
+    mEventTarget = nullptr;
+    mDashboard = target;
+  }
 
   nsCOMPtr<nsISocketTransport> mSocket;
   nsCOMPtr<nsIInputStream> mStreamIn;
   nsCOMPtr<nsITimer> mTimer;
   nsMainThreadPtrHandle<nsINetDashboardCallback> mCallback;
-  nsIEventTarget* mEventTarget{nullptr};
+  nsIEventTarget* mEventTarget;
   Dashboard* mDashboard;
 
   nsCString mHost;
-  uint32_t mPort{0};
+  uint32_t mPort;
   nsCString mProtocol;
-  uint32_t mTimeout{0};
+  uint32_t mTimeout;
 
   nsString mStatus;
 };
@@ -146,10 +153,10 @@ class RcwnData : public nsISupports {
  public:
   NS_DECL_THREADSAFE_ISUPPORTS
 
-  RcwnData() = default;
+  RcwnData() { mEventTarget = nullptr; }
 
   nsMainThreadPtrHandle<nsINetDashboardCallback> mCallback;
-  nsIEventTarget* mEventTarget{nullptr};
+  nsIEventTarget* mEventTarget;
 };
 
 NS_IMPL_ISUPPORTS0(RcwnData)
@@ -236,16 +243,16 @@ class LookupHelper final : public nsIDNSListener {
   NS_DECL_THREADSAFE_ISUPPORTS
   NS_DECL_NSIDNSLISTENER
 
-  LookupHelper() = default;
+  LookupHelper() : mEventTarget{nullptr}, mStatus{NS_ERROR_NOT_INITIALIZED} {}
 
   nsresult ConstructAnswer(LookupArgument* aArgument);
   nsresult ConstructHTTPSRRAnswer(LookupArgument* aArgument);
 
  public:
   nsCOMPtr<nsICancelable> mCancel;
   nsMainThreadPtrHandle<nsINetDashboardCallback> mCallback;
-  nsIEventTarget* mEventTarget{nullptr};
-  nsresult mStatus{NS_ERROR_NOT_INITIALIZED};
+  nsIEventTarget* mEventTarget;
+  nsresult mStatus;
 };
 
 NS_IMPL_ISUPPORTS(LookupHelper, nsIDNSListener)

netwerk/base/LoadInfo.cpp

@@ -104,7 +104,7 @@ LoadInfo::LoadInfo(
       mLoadingContext(do_GetWeakReference(aLoadingContext)),
       mSecurityFlags(aSecurityFlags),
       mSandboxFlags(aSandboxFlags),
-
+      mTriggeringSandboxFlags(0),
       mInternalContentPolicyType(aContentPolicyType) {
   MOZ_ASSERT(mLoadingPrincipal);
   MOZ_ASSERT(mTriggeringPrincipal);
@@ -320,7 +320,7 @@ LoadInfo::LoadInfo(nsPIDOMWindowOuter* aOuterWindow,
       mContextForTopLevelLoad(do_GetWeakReference(aContextForTopLevelLoad)),
       mSecurityFlags(aSecurityFlags),
       mSandboxFlags(aSandboxFlags),
-
+      mTriggeringSandboxFlags(0),
       mInternalContentPolicyType(nsIContentPolicy::TYPE_DOCUMENT) {
   // Top-level loads are never third-party
   // Grab the information we can out of the window.
@@ -379,7 +379,7 @@ LoadInfo::LoadInfo(dom::CanonicalBrowsingContext* aBrowsingContext,
     : mTriggeringPrincipal(aTriggeringPrincipal),
       mSecurityFlags(aSecurityFlags),
       mSandboxFlags(aSandboxFlags),
-
+      mTriggeringSandboxFlags(0),
       mInternalContentPolicyType(nsIContentPolicy::TYPE_DOCUMENT) {
   // Top-level loads are never third-party
   // Grab the information we can out of the window.
@@ -575,7 +575,9 @@ LoadInfo::LoadInfo(const LoadInfo& rhs)
       mForcePreflight(rhs.mForcePreflight),
       mIsPreflight(rhs.mIsPreflight),
       mLoadTriggeredFromExternal(rhs.mLoadTriggeredFromExternal),
-
+      // mServiceWorkerTaintingSynthesized must be handled specially during
+      // redirect
+      mServiceWorkerTaintingSynthesized(false),
       mDocumentHasUserInteracted(rhs.mDocumentHasUserInteracted),
       mAllowListFutureDocumentsCreatedFromThisRedirectChain(
           rhs.mAllowListFutureDocumentsCreatedFromThisRedirectChain),
@@ -700,7 +702,9 @@ LoadInfo::LoadInfo(
       mParserCreatedScript(aParserCreatedScript),
       mHasStoragePermission(aHasStoragePermission),
       mIsMetaRefresh(aIsMetaRefresh),
-
+      mIsFromProcessingFrameAttributes(false),
+      mIsMediaRequest(false),
+      mIsMediaInitialRequest(false),
       mLoadingEmbedderPolicy(aLoadingEmbedderPolicy),
       mUnstrippedURI(aUnstrippedURI) {
   // Only top level TYPE_DOCUMENT loads can have a null loadingPrincipal

netwerk/base/PollableEvent.cpp

@@ -138,8 +138,11 @@ static bool NewTCPSocketPair(PRFileDesc* fd[], bool aSetRecvBuff) {
 #endif
 
 PollableEvent::PollableEvent()
-
-{
+    : mWriteFD(nullptr),
+      mReadFD(nullptr),
+      mSignaled(false),
+      mWriteFailed(false),
+      mSignalTimestampAdjusted(false) {
   MOZ_COUNT_CTOR(PollableEvent);
   MOZ_ASSERT(OnSocketThread(), "not on socket thread");
   // create pair of prfiledesc that can be used as a poll()ble