Use correct viewer for debug.stop-on-redirect

Summary:
See <phacility#563>.

I think this secondary construction of a `$user` is very old, and predates subsequent changes which cause a proper user to construct earlier, so using the user on the `$request` should (I think) always work. I couldn't immediately find any cases where it does not.

Test Plan: With `debug.stop-on-redirect` set, hit various redirects, like jump-naving to T1. Got a proper stop dialog.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D8718

Author: epriestley

src/aphront/response/AphrontRedirectResponse.php

@@ -41,16 +41,17 @@ public function getHeaders() {
 
   public function buildResponseString() {
     if ($this->shouldStopForDebugging()) {
-      $user = new PhabricatorUser();
+      $request = $this->getRequest();
+      $viewer = $request->getUser();
 
       $view = new PhabricatorStandardPageView();
       $view->setRequest($this->getRequest());
-      $view->setApplicationName('Debug');
-      $view->setTitle('Stopped on Redirect');
+      $view->setApplicationName(pht('Debug'));
+      $view->setTitle(pht('Stopped on Redirect'));
 
       $dialog = new AphrontDialogView();
-      $dialog->setUser($user);
-      $dialog->setTitle('Stopped on Redirect');
+      $dialog->setUser($viewer);
+      $dialog->setTitle(pht('Stopped on Redirect'));
 
       $dialog->appendParagraph(
         pht(
@@ -68,7 +69,7 @@ public function buildResponseString() {
 
       $dialog->appendChild(
         id(new AphrontStackTraceView())
-          ->setUser($user)
+          ->setUser($viewer)
           ->setTrace($this->stackWhenCreated));
 
       $dialog->setIsStandalone(true);