Add some hotkeys for markers, and display them in tool tips.

[SuuperW]

Hotkeys:
Add marker (default M): Adds a marker to the emulated frame, same as the add marker button under the markers list.
Delete marker (default Ctrl+M): Deletes a marker on the emulated frame
Seek to prev/next marker (default Shift+PageUp/Down): Already existed, they are just now configurable.

Check if completed:

• I have run any relevant test suites
• I, the commit author, have read the licensing terms for contributors (last updated 2024-06-22) and am compliant

[YoshiRulz]

I don't like adding an event to Config. What if HandleHotkeyUpdate was a virtual method on ToolFormBase and you called it on all open tools at the end of this method?

BizHawk/src/BizHawk.Client.EmuHawk/MainForm.Events.cs

Lines 750 to 758 in adf8e38

	private void HotkeysMenuItem_Click(object sender, EventArgs e)
	{
	using var hotkeyConfig = new HotkeyConfig(Config);
	if (!this.ShowDialogWithTempMute(hotkeyConfig).IsOk()) return;
	AddOnScreenMessage("Hotkey settings saved");
	InitControls();
	InputManager.SyncControls(Emulator, MovieSession, Config);
	}

[SuuperW]

I think that would work, but what is wrong with using an event? Personally I think more things in BizHawk should be events. I don't like adding methods to base classes or interfaces just for them to be implemented in only a single class.

[YoshiRulz]

It's applicable to other tools too. (If it was just for TAStudio, why set up multicast?)
Events add overhead and are prone to creating subtle bugs.
To guarantee the serialisation remains good, you could use an Action property, but again it really needs to be multicast because other tools could use it.

[SuuperW]

A virtual method on all tools that most tools don't use (though I don't actually know how many would actually benefit from this particular one) also adds overhead.
Events are somewhat more prone to bugs though. (I really wish handlers would be automatically removed from the event when the owning object is disposed.)

I'll switch the implementation.

[vadosnaprimer]

I haven't checked the code but conceptually this PR makes sense. The only difference from the current workflow is that we're adding markers on selected frames using the menu, and to arbitrary frames using double-click. So these hotkeys are kinda unique in functionality by adding it on emulated frame instead. But I don't mind having options for all 3 methods of adding them.

[SuuperW]

There is already a button for adding a marker on the emulated frame, but not for removing on the emulated frame.
I could add one for adding to the selected frame too... but I feel like that's not as useful. It's also a bit ambiguous since you can have multiple frames selected. The context menu "Set Markers" option adds a marker to each selected frame which seems pointless but someone probably had a reason for implementing it.

[vadosnaprimer]

Yeah no need for extra stuff for now.