Update array create to pass the storage path in payload #5565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaunrd0
reviewed
Jul 2, 2025
| RETURN_NOT_OK(serialization::array_schema_serialize( | ||
| array_schema, serialization_type_, buff, false)); | ||
| array_schema, serialization_type_, buff, false, rest_uri.asset_storage)); |
There was a problem hiding this comment.
It wasn't part of your change, but wondering why client_side is explicitly set to false here? Is there any reason we would not want to set the array schema URI server side? Since this is false the field is unset when it reaches TileDB-Server.
If there's no reason to avoid setting this field server side, we may just be able to remove the if (client_side) check that sets the URI field.
| @@ -1190,7 +1196,8 @@ Status array_schema_serialize( | |||
| const ArraySchema& array_schema, | |||
| SerializationType serialize_type, | |||
| SerializationBuffer& serialized_buffer, | |||
| const bool client_side) { | |||
| const bool client_side, | |||
| std::optional<std::string> storage_uri) { | |||
There was a problem hiding this comment.
I can't comment in unchanged code, but we need to pass storage_uri to array_schema_to_capnp on 1206 below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new Server the storage path should not be passed in the request endpoint URL, so we need to specify it in the request payload. In Group create case this was already implemented, but for arrays it was not.
This PR attempts to fix it by setting the storage path in an existing
capnpfield, theuriof theArraySchema, only for array create. We need to implement the server side changes to see if that can work.TYPE: IMPROVEMENT
DESC: Update array create to pass the storage path in payload