Skip to content

Commit 49c40d2

Browse files
author
epriestley
committedFeb 15, 2013
Tokens v1
Summary: Features! - Giving tokens. - Taking tokens back. - Not giving tokens. Test Plan: See screenshots. Reviewers: chad, vrana Reviewed By: chad CC: aran, btrahan Maniphest Tasks: T2541 Differential Revision: https://secure.phabricator.com/D4964
1 parent f9f2925 commit 49c40d2

File tree

60 files changed

+1758
-452
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

60 files changed

+1758
-452
lines changed
 

‎externals/javelinjs/src/lib/Workflow.js

+8-3
Original file line numberDiff line numberDiff line change
@@ -88,14 +88,19 @@ JX.install('Workflow', {
8888
return;
8989
}
9090

91-
var t = event.getTarget();
91+
// Get the button (which is sometimes actually another tag, like an <a />)
92+
// which triggered the event. In particular, this makes sure we get the
93+
// right node if there is a <button> with an <img /> inside it or
94+
// or something similar.
95+
var t = event.getNode('jx-workflow-button') ||
96+
event.getNode('tag:button');
9297
if (t.name == '__cancel__' || t.name == '__close__') {
9398
JX.Workflow._pop();
9499
} else {
95-
96100
var form = event.getNode('jx-dialog');
97101
var data = JX.DOM.convertFormToListOfPairs(form);
98-
data.push([t.name, true]);
102+
103+
data.push([t.name, t.value || true]);
99104

100105
var active = JX.Workflow._getActiveWorkflow();
101106
var e = active.invoke('submit', {form: form, data: data});

‎resources/sprite/manifest/apps-large.json

+156-156
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)
Failed to load comments.