Skip to content

Commit 58ef3be

Browse files
AnhNhanepriestley
authored and
epriestley
committedFeb 26, 2013
made DiffusionHomeController use commit summaries
Summary: Latest commit in repositories are displayed together with their summaries if available Test Plan: Diffusion did not crash - a good sign commit summaries also only appear on Diffusion Home //only// - as expected Reviewers: epriestley, btrahan, chad Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5117
1 parent 5de7774 commit 58ef3be

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed
 

‎src/applications/diffusion/controller/DiffusionHomeController.php

+3-6
Original file line numberDiff line numberDiff line change
@@ -130,15 +130,15 @@ public function processRequest() {
130130
'href' => '/diffusion/'.$repository->getCallsign().'/',
131131
),
132132
$repository->getName()),
133-
$repository->getDetail('description'),
134133
PhabricatorRepositoryType::getNameForRepositoryType(
135134
$repository->getVersionControlSystem()),
136135
$size,
137136
$lint_count,
138137
$commit
139138
? DiffusionView::linkCommit(
140139
$repository,
141-
$commit->getCommitIdentifier())
140+
$commit->getCommitIdentifier(),
141+
$commit->getSummary())
142142
: '-',
143143
$date,
144144
$time,
@@ -166,7 +166,6 @@ public function processRequest() {
166166
$table->setHeaders(
167167
array(
168168
'Repository',
169-
'Description',
170169
'VCS',
171170
'Commits',
172171
'Lint',
@@ -177,11 +176,10 @@ public function processRequest() {
177176
$table->setColumnClasses(
178177
array(
179178
'pri',
180-
'wide',
181179
'',
182180
'n',
183181
'n',
184-
'n',
182+
'wide',
185183
'',
186184
'right',
187185
));
@@ -190,7 +188,6 @@ public function processRequest() {
190188
true,
191189
true,
192190
true,
193-
true,
194191
$show_lint,
195192
true,
196193
true,

‎src/applications/diffusion/view/DiffusionView.php

+6-1
Original file line numberDiff line numberDiff line change
@@ -113,11 +113,16 @@ final public static function nameCommit(
113113

114114
final public static function linkCommit(
115115
PhabricatorRepository $repository,
116-
$commit) {
116+
$commit,
117+
$summary = '') {
117118

118119
$commit_name = self::nameCommit($repository, $commit);
119120
$callsign = $repository->getCallsign();
120121

122+
if (strlen($summary)) {
123+
$commit_name .= ': ' . $summary;
124+
}
125+
121126
return phutil_tag(
122127
'a',
123128
array(

0 commit comments

Comments
 (0)
Failed to load comments.