Addressing some PHP8 incompatibilities - ProfileMenuItem

Summary:
Updates to all of the `ProfileMenuItem` classes to be compatible with PHP 8.

These changes were moved from D21862.

Refs T13588

Test Plan:
I loaded the profile page for a user and saw all the items I expected to see.
I navigated through the different profile nav items.
I loaded the settings page for a user and saw all the items I expected to see.
I navigated through the differnt setting nave items.
I added Cat Facts to my navigation.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T13588

Differential Revision: https://secure.phabricator.com/D21863

Author: neandrake

src/applications/home/menuitem/PhabricatorHomeLauncherProfileMenuItem.php

@@ -13,6 +13,12 @@ private function getDefaultName() {
     return pht('More Applications');
   }
 
+  public function getDisplayName(
+    PhabricatorProfileMenuItemConfiguration $config) {
+    $default = $this->getDefaultName();
+    return $this->getNameFromConfig($config, $default);
+  }
+
   public function getMenuItemTypeIcon() {
     return 'fa-ellipsis-h';
   }
@@ -27,17 +33,6 @@ public function canMakeDefault(
     return false;
   }
 
-  public function getDisplayName(
-    PhabricatorProfileMenuItemConfiguration $config) {
-    $name = $config->getMenuItemProperty('name');
-
-    if (strlen($name)) {
-      return $name;
-    }
-
-    return $this->getDefaultName();
-  }
-
   public function buildEditEngineFields(
     PhabricatorProfileMenuItemConfiguration $config) {
     return array(

src/applications/home/menuitem/PhabricatorHomeProfileMenuItem.php

@@ -13,6 +13,12 @@ private function getDefaultName() {
     return pht('Home');
   }
 
+  public function getDisplayName(
+    PhabricatorProfileMenuItemConfiguration $config) {
+    $default = $this->getDefaultName();
+    return $this->getNameFromConfig($config, $default);
+  }
+
   public function getMenuItemTypeIcon() {
     return 'fa-home';
   }
@@ -22,17 +28,6 @@ public function canMakeDefault(
     return true;
   }
 
-  public function getDisplayName(
-    PhabricatorProfileMenuItemConfiguration $config) {
-    $name = $config->getMenuItemProperty('name');
-
-    if (strlen($name)) {
-      return $name;
-    }
-
-    return $this->getDefaultName();
-  }
-
   public function newPageContent(
     PhabricatorProfileMenuItemConfiguration $config) {
     $viewer = $this->getViewer();

src/applications/people/menuitem/PhabricatorPeopleBadgesProfileMenuItem.php

@@ -13,20 +13,15 @@ private function getDefaultName() {
     return pht('Badges');
   }
 
-  public function canHideMenuItem(
+  public function getDisplayName(
     PhabricatorProfileMenuItemConfiguration $config) {
-    return true;
+    $default = $this->getDefaultName();
+    return $this->getNameFromConfig($config, $default);
   }
 
-  public function getDisplayName(
+  public function canHideMenuItem(
     PhabricatorProfileMenuItemConfiguration $config) {
-    $name = $config->getMenuItemProperty('name');
-
-    if (strlen($name)) {
-      return $name;
-    }
-
-    return $this->getDefaultName();
+    return true;
   }
 
   public function buildEditEngineFields(

src/applications/people/menuitem/PhabricatorPeopleCommitsProfileMenuItem.php

@@ -13,20 +13,15 @@ private function getDefaultName() {
     return pht('Commits');
   }
 
-  public function canHideMenuItem(
+  public function getDisplayName(
     PhabricatorProfileMenuItemConfiguration $config) {
-    return true;
+    $default = $this->getDefaultName();
+    return $this->getNameFromConfig($config, $default);
   }
 
-  public function getDisplayName(
+  public function canHideMenuItem(
     PhabricatorProfileMenuItemConfiguration $config) {
-    $name = $config->getMenuItemProperty('name');
-
-    if (strlen($name)) {
-      return $name;
-    }
-
-    return $this->getDefaultName();
+    return true;
   }
 
   public function buildEditEngineFields(

src/applications/people/menuitem/PhabricatorPeopleDetailsProfileMenuItem.php

@@ -15,13 +15,8 @@ private function getDefaultName() {
 
   public function getDisplayName(
     PhabricatorProfileMenuItemConfiguration $config) {
-    $name = $config->getMenuItemProperty('name');
-
-    if (strlen($name)) {
-      return $name;
-    }
-
-    return $this->getDefaultName();
+    $default = $this->getDefaultName();
+    return $this->getNameFromConfig($config, $default);
   }
 
   public function buildEditEngineFields(

src/applications/people/menuitem/PhabricatorPeopleManageProfileMenuItem.php

@@ -13,20 +13,15 @@ private function getDefaultName() {
     return pht('Manage');
   }
 
-  public function canHideMenuItem(
+  public function getDisplayName(
     PhabricatorProfileMenuItemConfiguration $config) {
-    return false;
+    $default = $this->getDefaultName();
+    return $this->getNameFromConfig($config, $default);
   }
 
-  public function getDisplayName(
+  public function canHideMenuItem(
     PhabricatorProfileMenuItemConfiguration $config) {
-    $name = $config->getMenuItemProperty('name');
-
-    if (strlen($name)) {
-      return $name;
-    }
-
-    return $this->getDefaultName();
+    return false;
   }
 
   public function buildEditEngineFields(

src/applications/people/menuitem/PhabricatorPeoplePictureProfileMenuItem.php

@@ -13,14 +13,14 @@ private function getDefaultName() {
     return pht('User Picture');
   }
 
-  public function canHideMenuItem(
+  public function getDisplayName(
     PhabricatorProfileMenuItemConfiguration $config) {
-    return false;
+    return $this->getDefaultName();
   }
 
-  public function getDisplayName(
+  public function canHideMenuItem(
     PhabricatorProfileMenuItemConfiguration $config) {
-    return $this->getDefaultName();
+    return false;
   }
 
   public function buildEditEngineFields(

src/applications/people/menuitem/PhabricatorPeopleRevisionsProfileMenuItem.php

@@ -13,20 +13,15 @@ private function getDefaultName() {
     return pht('Revisions');
   }
 
-  public function canHideMenuItem(
+  public function getDisplayName(
     PhabricatorProfileMenuItemConfiguration $config) {
-    return true;
+    $default = $this->getDefaultName();
+    return $this->getNameFromConfig($config, $default);
   }
 
-  public function getDisplayName(
+  public function canHideMenuItem(
     PhabricatorProfileMenuItemConfiguration $config) {
-    $name = $config->getMenuItemProperty('name');
-
-    if (strlen($name)) {
-      return $name;
-    }
-
-    return $this->getDefaultName();
+    return true;
   }
 
   public function buildEditEngineFields(

src/applications/people/menuitem/PhabricatorPeopleTasksProfileMenuItem.php

@@ -13,20 +13,15 @@ private function getDefaultName() {
     return pht('Tasks');
   }
 
-  public function canHideMenuItem(
+  public function getDisplayName(
     PhabricatorProfileMenuItemConfiguration $config) {
-    return true;
+    $default = $this->getDefaultName();
+    return $this->getNameFromConfig($config, $default);
   }
 
-  public function getDisplayName(
+  public function canHideMenuItem(
     PhabricatorProfileMenuItemConfiguration $config) {
-    $name = $config->getMenuItemProperty('name');
-
-    if (strlen($name)) {
-      return $name;
-    }
-
-    return $this->getDefaultName();
+    return true;
   }
 
   public function buildEditEngineFields(

src/applications/project/menuitem/PhabricatorProjectDetailsProfileMenuItem.php

@@ -13,6 +13,12 @@ private function getDefaultName() {
     return pht('Project Details');
   }
 
+  public function getDisplayName(
+    PhabricatorProfileMenuItemConfiguration $config) {
+    $default = $this->getDefaultName();
+    return $this->getNameFromConfig($config, $default);
+  }
+
   public function getMenuItemTypeIcon() {
     return 'fa-file-text-o';
   }
@@ -27,17 +33,6 @@ public function canMakeDefault(
     return true;
   }
 
-  public function getDisplayName(
-    PhabricatorProfileMenuItemConfiguration $config) {
-    $name = $config->getMenuItemProperty('name');
-
-    if (strlen($name)) {
-      return $name;
-    }
-
-    return $this->getDefaultName();
-  }
-
   public function buildEditEngineFields(
     PhabricatorProfileMenuItemConfiguration $config) {
     return array(

src/applications/project/menuitem/PhabricatorProjectManageProfileMenuItem.php

@@ -13,6 +13,12 @@ private function getDefaultName() {
     return pht('Manage');
   }
 
+  public function getDisplayName(
+    PhabricatorProfileMenuItemConfiguration $config) {
+    $default = $this->getDefaultName();
+    return $this->getNameFromConfig($config, $default);
+  }
+
   public function getMenuItemTypeIcon() {
     return 'fa-cog';
   }
@@ -27,17 +33,6 @@ public function canMakeDefault(
     return true;
   }
 
-  public function getDisplayName(
-    PhabricatorProfileMenuItemConfiguration $config) {
-    $name = $config->getMenuItemProperty('name');
-
-    if (strlen($name)) {
-      return $name;
-    }
-
-    return $this->getDefaultName();
-  }
-
   public function buildEditEngineFields(
     PhabricatorProfileMenuItemConfiguration $config) {
     return array(

src/applications/project/menuitem/PhabricatorProjectMembersProfileMenuItem.php

@@ -13,19 +13,14 @@ private function getDefaultName() {
     return pht('Members');
   }
 
-  public function getMenuItemTypeIcon() {
-    return 'fa-users';
-  }
-
   public function getDisplayName(
     PhabricatorProfileMenuItemConfiguration $config) {
-    $name = $config->getMenuItemProperty('name');
-
-    if (strlen($name)) {
-      return $name;
-    }
+    $default = $this->getDefaultName();
+    return $this->getNameFromConfig($config, $default);
+  }
 
-    return $this->getDefaultName();
+  public function getMenuItemTypeIcon() {
+    return 'fa-users';
   }
 
   public function buildEditEngineFields(

src/applications/project/menuitem/PhabricatorProjectPictureProfileMenuItem.php

@@ -13,6 +13,11 @@ private function getDefaultName() {
     return pht('Project Picture');
   }
 
+  public function getDisplayName(
+    PhabricatorProfileMenuItemConfiguration $config) {
+    return $this->getDefaultName();
+  }
+
   public function getMenuItemTypeIcon() {
     return 'fa-image';
   }
@@ -22,11 +27,6 @@ public function canHideMenuItem(
     return false;
   }
 
-  public function getDisplayName(
-    PhabricatorProfileMenuItemConfiguration $config) {
-    return $this->getDefaultName();
-  }
-
   public function buildEditEngineFields(
     PhabricatorProfileMenuItemConfiguration $config) {
     return array();

src/applications/project/menuitem/PhabricatorProjectPointsProfileMenuItem.php

@@ -13,6 +13,11 @@ private function getDefaultName() {
     return pht('Points Bar');
   }
 
+  public function getDisplayName(
+    PhabricatorProfileMenuItemConfiguration $config) {
+    return $this->getDefaultName();
+  }
+
   public function shouldEnableForObject($object) {
     $viewer = $this->getViewer();
 
@@ -35,11 +40,6 @@ public function shouldEnableForObject($object) {
     return true;
   }
 
-  public function getDisplayName(
-    PhabricatorProfileMenuItemConfiguration $config) {
-    return $this->getDefaultName();
-  }
-
   public function buildEditEngineFields(
     PhabricatorProfileMenuItemConfiguration $config) {
     return array(

src/applications/project/menuitem/PhabricatorProjectReportsProfileMenuItem.php

@@ -13,6 +13,12 @@ private function getDefaultName() {
     return pht('Reports (Prototype)');
   }
 
+  public function getDisplayName(
+    PhabricatorProfileMenuItemConfiguration $config) {
+    $default = $this->getDefaultName();
+    return $this->getNameFromConfig($config, $default);
+  }
+
   public function getMenuItemTypeIcon() {
     return 'fa-area-chart';
   }
@@ -42,17 +48,6 @@ public function shouldEnableForObject($object) {
     return true;
   }
 
-  public function getDisplayName(
-    PhabricatorProfileMenuItemConfiguration $config) {
-    $name = $config->getMenuItemProperty('name');
-
-    if (strlen($name)) {
-      return $name;
-    }
-
-    return $this->getDefaultName();
-  }
-
   public function buildEditEngineFields(
     PhabricatorProfileMenuItemConfiguration $config) {
     return array(