Addressing some PHP8 incompatibilities - Dashboard

Summary:
Using dashboard/panels and addressing PHP8 incompatibilities.

Refs T13588

Test Plan: Create a dashboard with multiple panels, including a tabbed panel. Update the tabbed panel to have multiple tabs of content. Try to have a tabbed panel contain itself.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T13588

Differential Revision: https://secure.phabricator.com/D21871

Author: neandrake

src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php

@@ -32,7 +32,7 @@ public function handleRequest(AphrontRequest $request) {
 
     $panel_ref = null;
     $panel_key = $request->getStr('panelKey');
-    if (strlen($panel_key)) {
+    if (phutil_nonempty_string($panel_key)) {
       $panel_ref = $ref_list->getPanelRef($panel_key);
       if (!$panel_ref) {
         return new Aphront404Response();
@@ -42,7 +42,7 @@ public function handleRequest(AphrontRequest $request) {
     }
 
     $column_key = $request->getStr('columnKey');
-    if (strlen($column_key)) {
+    if (phutil_nonempty_string($column_key)) {
       $columns = $ref_list->getColumns();
       if (!isset($columns[$column_key])) {
         return new Aphront404Response();
@@ -52,7 +52,7 @@ public function handleRequest(AphrontRequest $request) {
 
     $after_ref = null;
     $after_key = $request->getStr('afterKey');
-    if (strlen($after_key)) {
+    if (phutil_nonempty_string($after_key)) {
       $after_ref = $ref_list->getPanelRef($after_key);
       if (!$after_ref) {
         return new Aphront404Response();

src/applications/dashboard/controller/panel/PhabricatorDashboardPanelEditController.php

@@ -15,7 +15,7 @@ public function handleRequest(AphrontRequest $request) {
     // editing.
 
     $context_phid = $request->getStr('contextPHID');
-    if (strlen($context_phid)) {
+    if (phutil_nonempty_string($context_phid)) {
       $context = id(new PhabricatorObjectQuery())
         ->setViewer($viewer)
         ->withPHIDs(array($context_phid))

src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php

@@ -41,12 +41,12 @@ public function handleRequest(AphrontRequest $request) {
 
     $op = $request->getURIData('op');
     $after = $request->getStr('after');
-    if (!strlen($after)) {
+    if (!phutil_nonempty_string($after)) {
       $after = null;
     }
 
     $target = $request->getStr('target');
-    if (!strlen($target)) {
+    if (!phutil_nonempty_string($target)) {
       $target = null;
     }
 
@@ -103,7 +103,7 @@ public function handleRequest(AphrontRequest $request) {
 
     $context_phid = $request->getStr('contextPHID');
     $context = null;
-    if (strlen($context_phid)) {
+    if (phutil_nonempty_string($context_phid)) {
       $context = id(new PhabricatorObjectQuery())
         ->setViewer($viewer)
         ->withPHIDs(array($context_phid))

src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php

@@ -101,7 +101,7 @@ public function renderPanelContent(
       $subpanel = idx($panels, $panel_id);
 
       $name = idx($tab_spec, 'name');
-      if (!strlen($name)) {
+      if ($name === null || !strlen($name)) {
         if ($subpanel) {
           $name = $subpanel->getName();
         }

src/applications/dashboard/typeahead/PhabricatorDashboardPanelDatasource.php

@@ -28,7 +28,7 @@ public function buildResults() {
     $query = new PhabricatorDashboardPanelQuery();
 
     $raw_query = $this->getRawQuery();
-    if (preg_match('/^[wW]\d+\z/', $raw_query)) {
+    if ($raw_query !== null && preg_match('/^[wW]\d+\z/', $raw_query)) {
       $id = trim($raw_query, 'wW');
       $id = (int)$id;
       $query->withIDs(array($id));