Skip to content

Commit 8e703c8

Browse files
author
epriestley
committedMay 24, 2022
Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery"
Summary: Ref T13682. Many subclasses of "CursorPagedPolicyAwareQuery" have the same implementation of "loadPage()", and this is a sensible default behavior. Test Plan: Examined changes to verify that all removed methods have the same behavior. Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13682 Differential Revision: https://secure.phabricator.com/D21838
1 parent 5493f02 commit 8e703c8

File tree

112 files changed

+20
-442
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

112 files changed

+20
-442
lines changed
 

‎src/applications/almanac/query/AlmanacBindingQuery.php

-4
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,6 @@ public function newResultObject() {
4444
return new AlmanacBinding();
4545
}
4646

47-
protected function loadPage() {
48-
return $this->loadStandardPage($this->newResultObject());
49-
}
50-
5147
protected function willFilterPage(array $bindings) {
5248
$service_phids = mpull($bindings, 'getServicePHID');
5349
$device_phids = mpull($bindings, 'getDevicePHID');

‎src/applications/almanac/query/AlmanacDeviceQuery.php

-4
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,6 @@ public function newResultObject() {
5656
return new AlmanacDevice();
5757
}
5858

59-
protected function loadPage() {
60-
return $this->loadStandardPage($this->newResultObject());
61-
}
62-
6359
protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
6460
$where = parent::buildWhereClauseParts($conn);
6561

0 commit comments

Comments
 (0)
Failed to load comments.